Repository navigation
Name the Carried Skill and the Skipped Review Correctly - #3122
Conversation
The reviewer reference named the hub-only .agents/skills path for the rule a carrier applies, so it now names the pr-review-conduct skill without a path. The pr-review-conduct trigger said a reviewer is skipped where the review is, so it now says a review looks missing or skipped.
The sentence-length check flagged both sentences on the edited line, so each is now split.
|
A recorded local strict-review pass covers head |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review findings remain.
0 open findings
What changed in this PR
Corrects review documentation and skill wording, then regenerates distributed skill outputs.
Changes:
- Clarifies the carried
pr-review-conductskill reference. - Corrects “reviewer” to “review” in skipped-review wording.
- Regenerates skill copies and source digest metadata.
| File | Description |
|---|---|
docs/pr-reviewer-reference.md |
Corrected carried-skill wording and sentence structure. |
.github/skills/pr-review-conduct/SKILL.md |
Regenerated GitHub skill copy. |
.claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md |
Regenerated Claude skill copy. |
.claude-plugin/fleet-skills/.source-digests/pr-review-conduct |
Updated generated source digest. |
.agents/skills/pr-review-conduct/SKILL.md |
Corrected review description wording. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3122 +/- ##
==========================================
Coverage ? 63.92%
==========================================
Files ? 17
Lines ? 9145
Branches ? 0
==========================================
Hits ? 5846
Misses ? 3299
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
… Fixes to Main (#3146) - #3135 makes `gh-write-guard` read a gh write's subcommand and target the way gh parses them: the subcommand is found past flags before the command and before the subcommand, an `R` inside a short-option cluster is read as a target, `GH_REPO` is read as a target, a run-time repository owner on a write fails closed, and a run-time word where `pr` or `merge` goes fails closed beside `--admin` or where word splitting may split it - #3139 releases the bootstrap lock when a `bootstrap.ps1` run ends rather than when its process does, so a second run typed at the same pwsh prompt is no longer refused the lock - #3130 matches tool names and the `all` keyword by case in the Windows agents loaders, as the Linux loaders already do - #3128 reads CodeRabbit's rate limit on a reply to an explicit review command in `pr_review.py` - #3126 reconciles VSCode-Server-DotNetCore in the hub after its resync - #3124 logs the Docker task's build-base leg in to Docker Hub - #3122 names the carried skill and the skipped review correctly - #3120 states the subprocess encoding rule in `CODESTYLE.md`, where carriers read Python style - #3118 and #3111 move the release-guard tests' workflow-command checks onto `runner_commands`, and test the alternatives wiring at the `audit_repo` and `fidelity_pass` call sites - #3116 stops the doc gates' printed names forging workflow commands - #3113 adds a catalog snippet for the release-with-smoke caller - #3109 moves the `workflow_reuse` fetch onto `audit.contents_text` - #3105 accepts `.codecov.yml` as an alternative to `codecov.yml` - #3103 adds a pip ecosystem to the carried Dependabot snippet - #3100 prefers the venv's ruff and pyright for a declared pip directory - #3098 tracks composite action pins in Dependabot - #3096 reads an uppercase Markdown suffix as Markdown at every prose gate branch After this merges, the host-safety installer payload changes, so the maintainer runs the installer after promotion. Closes #1416 Closes #1425 Closes #1578 Closes #1874 Closes #1892 Closes #1899 Closes #2804 Closes #2850 Closes #2852 Closes #2854 Closes #2996 Closes #3065 Closes #3067 Closes #3069 Closes #3079 Closes #3080 Closes #3089 Closes #3093 Closes #3101 Closes #3106 Closes #3107 Closes #3137 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a pull-request smoke build that runs when relevant release files change and reports the combined validation and build status. * Repository audits now recognize `.codecov.yml` as an alternative to `codecov.yml`. * **Improvements** * Python linting and type checks use tools from declared project environments when available, with fallbacks for missing tools. * Workflow and lint reports safely display unusual filenames and command-like text. * GitHub write-target checks now account for additional command forms and fail closed when targets cannot be verified. * Rate-limit detection now recognizes another CodeRabbit response format. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Fixes the two live findings of #1416.
docs/pr-reviewer-reference.mdnamed the hub-only.agents/skills/pr-review-conduct/SKILL.mdpath as the home of a rule "carried into repositories that hold no copy of this file". The carried tree is the generated.github/skills, so the sentence now names thepr-review-conductskill without a path, the formAGENTS.mduses for hub-local skill paths. Its sentence and the paragraph's first sentence are split, since the sentence-length check flagged both on the edited line.pr-review-conductfrontmatter description said "when a reviewer looks missing or skipped". The review is what gets skipped, so it now reads "when a review looks missing or skipped". The section body no longer carries the wrong noun, so only the description changes.The generated
.github/skillsand.claude-plugintrees are regenerated withscripts/build_dist.py.Closes on promotion: #1416
Verification
python3 scripts/build_dist.py --check: current.prose_lint.py --diff <merge-base>, with and without--check sentence-length: clean.docker_lint.pyfor markdownlint and editorconfig-checker: 0 issues.repo_gate.py: 0 issues.spec/validate.py: OK.tests/test_build_dist.py: 89 passed.local-strict-review: round 1 raised no review findings, and its sentence-length run flagged two sentences on the edited line, split in cfa05b3. Round 2 raised none.🤖 Generated with Claude Code