Skip to content

Name the Carried Skill and the Skipped Review Correctly - #3122

Merged
ptr727 merged 2 commits into
developfrom
feature/auto-1416
Oct 16, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/auto-1416

Conversation

@ptr727

@ptr727 ptr727 commented Oct 16, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the two live findings of #1416.

  • Item 1. docs/pr-reviewer-reference.md named the hub-only .agents/skills/pr-review-conduct/SKILL.md path as the home of a rule "carried into repositories that hold no copy of this file". The carried tree is the generated .github/skills, so the sentence now names the pr-review-conduct skill without a path, the form AGENTS.md uses for hub-local skill paths. Its sentence and the paragraph's first sentence are split, since the sentence-length check flagged both on the edited line.
  • Item 2. The pr-review-conduct frontmatter description said "when a reviewer looks missing or skipped". The review is what gets skipped, so it now reads "when a review looks missing or skipped". The section body no longer carries the wrong noun, so only the description changes.
  • Item 3 is already fixed on develop. The skip-notice bullet already says to comment "the reviewer's documented review command", which ties the trigger to the reviewer that posted the notice, so it is left unchanged.

The generated .github/skills and .claude-plugin trees are regenerated with scripts/build_dist.py.

Closes on promotion: #1416

Verification

  • python3 scripts/build_dist.py --check: current.
  • prose_lint.py --diff <merge-base>, with and without --check sentence-length: clean.
  • docker_lint.py for markdownlint and editorconfig-checker: 0 issues.
  • repo_gate.py: 0 issues. spec/validate.py: OK. tests/test_build_dist.py: 89 passed.
  • local-strict-review: round 1 raised no review findings, and its sentence-length run flagged two sentences on the edited line, split in cfa05b3. Round 2 raised none.

🤖 Generated with Claude Code

The reviewer reference named the hub-only .agents/skills path for the rule a carrier applies, so it now names the pr-review-conduct skill without a path. The pr-review-conduct trigger said a reviewer is skipped where the review is, so it now says a review looks missing or skipped.
The sentence-length check flagged both sentences on the edited line, so each is now split.
Copilot AI lite review requested due to automatic review settings October 16, 2026 05:39
@ptr727

ptr727 commented Oct 16, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head cfa05b3286bc28ae6b76e24f9236e77d62d0778d, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review findings remain.

0 open findings

What changed in this PR

Corrects review documentation and skill wording, then regenerates distributed skill outputs.

Changes:

  • Clarifies the carried pr-review-conduct skill reference.
  • Corrects “reviewer” to “review” in skipped-review wording.
  • Regenerates skill copies and source digest metadata.
File Description
docs/​pr-reviewer-reference.md Corrected carried-skill wording and sentence structure.
.github/​skills/​pr-review-conduct/​SKILL.md Regenerated GitHub skill copy.
.claude-plugin/​fleet-skills/​skills/​pr-review-conduct/​SKILL.md Regenerated Claude skill copy.
.claude-plugin/​fleet-skills/​.source-digests/​pr-review-conduct Updated generated source digest.
.agents/​skills/​pr-review-conduct/​SKILL.md Corrected review description wording.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2d76efd9-7160-44a0-8cea-17d3afa799b2
📥 Commits

Reviewing files that changed from the base of the PR and between 0b9ec4f and cfa05b3.

⛔ Files ignored due to path filters: 3
  • .claude-plugin/fleet-skills/.source-digests/pr-review-conduct is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .github/skills/pr-review-conduct/SKILL.md is excluded by !.github/skills/**
📒 Files selected for processing: 2
  • .agents/skills/pr-review-conduct/SKILL.md
  • docs/pr-reviewer-reference.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@0b9ec4f). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3122   +/-   ##
==========================================
  Coverage           ?   63.92%           
==========================================
  Files              ?       17           
  Lines              ?     9145           
  Branches           ?        0           
==========================================
  Hits               ?     5846           
  Misses             ?     3299           
  Partials           ?        0           
Flag Coverage Δ
python-3.13 63.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Oct 16, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit c5ecaa6 into develop Oct 16, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/auto-1416 branch October 16, 2026 06:01
ptr727 added a commit that referenced this pull request Oct 16, 2026
… Fixes to Main (#3146)

- #3135 makes `gh-write-guard` read a gh write's subcommand and target
the way gh parses them: the subcommand is found past flags before the
command and before the subcommand, an `R` inside a short-option cluster
is read as a target, `GH_REPO` is read as a target, a run-time
repository owner on a write fails closed, and a run-time word where `pr`
or `merge` goes fails closed beside `--admin` or where word splitting
may split it
- #3139 releases the bootstrap lock when a `bootstrap.ps1` run ends
rather than when its process does, so a second run typed at the same
pwsh prompt is no longer refused the lock
- #3130 matches tool names and the `all` keyword by case in the Windows
agents loaders, as the Linux loaders already do
- #3128 reads CodeRabbit's rate limit on a reply to an explicit review
command in `pr_review.py`
- #3126 reconciles VSCode-Server-DotNetCore in the hub after its resync
- #3124 logs the Docker task's build-base leg in to Docker Hub
- #3122 names the carried skill and the skipped review correctly
- #3120 states the subprocess encoding rule in `CODESTYLE.md`, where
carriers read Python style
- #3118 and #3111 move the release-guard tests' workflow-command checks
onto `runner_commands`, and test the alternatives wiring at the
`audit_repo` and `fidelity_pass` call sites
- #3116 stops the doc gates' printed names forging workflow commands
- #3113 adds a catalog snippet for the release-with-smoke caller
- #3109 moves the `workflow_reuse` fetch onto `audit.contents_text`
- #3105 accepts `.codecov.yml` as an alternative to `codecov.yml`
- #3103 adds a pip ecosystem to the carried Dependabot snippet
- #3100 prefers the venv's ruff and pyright for a declared pip directory
- #3098 tracks composite action pins in Dependabot
- #3096 reads an uppercase Markdown suffix as Markdown at every prose
gate branch

After this merges, the host-safety installer payload changes, so the
maintainer runs the installer after promotion.

Closes #1416
Closes #1425
Closes #1578
Closes #1874
Closes #1892
Closes #1899
Closes #2804
Closes #2850
Closes #2852
Closes #2854
Closes #2996
Closes #3065
Closes #3067
Closes #3069
Closes #3079
Closes #3080
Closes #3089
Closes #3093
Closes #3101
Closes #3106
Closes #3107
Closes #3137

🤖 Generated with [Claude Code](https://claude.com/claude-code)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added a pull-request smoke build that runs when relevant release files
change and reports the combined validation and build status.
* Repository audits now recognize `.codecov.yml` as an alternative to
`codecov.yml`.

* **Improvements**
* Python linting and type checks use tools from declared project
environments when available, with fallbacks for missing tools.
* Workflow and lint reports safely display unusual filenames and
command-like text.
* GitHub write-target checks now account for additional command forms
and fail closed when targets cannot be verified.
* Rate-limit detection now recognizes another CodeRabbit response
format.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants