[ptr727]

Summary

Moves the remaining subprocess failures that were classified by message prose onto the CODESTYLE.md "Operations and Failure Messages" status-code rule.

• spec/audit.py gh(): with ok404, a failure now reads as absence only when the stderr carries the (HTTP 404) notation gh api prints. Bare "Not Found" or "HTTP 404" prose, another printed status, or no status at all, such as a network error, raises as an unexpected failure.

• scripts/skills_install.py: the expected "already there" case has its own operation now, the listing, instead of a match on "already" in a failed command's output. Where the marketplace listing already names this checkout, the installer skips claude plugin marketplace add. Where claude plugin list --json shows the plugin installed at user scope, it skips claude plugin install. Each command that does run is judged by its exit status alone. Where the plugin listing cannot be read, the install runs and its exit status decides.

• host-setup/linux/setup-github.sh gh_account() and host-setup/windows/setup-github.ps1 Get-GhAccount: the check for gh's --active flag (added in gh 2.57) is now the exit status of gh auth status --active --help rather than a match on unknown flag: --active. This is the same capability probe pr_review.py uses for --allow-escape-sequences. The PowerShell twin had the same prose match, so it moves too.

• host-setup/windows/setup-github.ps1 known-host checks: a local review pass found the same class at both ssh-keygen -F github.com sites, which matched found in the output. They now read the exit status, as the Linux twin already does. scripts/README.md "skills_install.py" names the add and install skips.

The scripts/pr_review.py unknown flag retry is #3365's and is not touched here.

Findings from the local pass, fixed on the pull request

• tests/test_setup_github.py (introduced, design): the new known-host harness repeated the existing Windows harness's parse-and-extract preamble. Fixed in a10982d, where one windows_harness builder writes it for both.

Dropped findings

• scripts/README.md:391 (style, pre-existing): four sentences this change did not write exceed the advisory sentence-length check.
• tests/test_install_tools.py and tests/test_bootstrap.py (consolidation, pre-existing): each carries its own copy of the same parse-and-dot-source pwsh preamble.

Closes on promotion: #3378

Verification

• New tests run on constructed output: GhAbsenceCase in tests/test_audit_helpers.py, the add, install and listing cases in tests/test_skills_install.py RegisterCase, the help-probe calls in both the Linux and the Windows (pwsh) classes of tests/test_setup_github.py, and TestWindowsKnownHost, which fails against the old -match 'found' read.
• A pwsh probe confirmed ssh-keygen -F exits 0 for a known host, 1 for an empty file, and 255 for a missing one.
• The capability probe was checked against the installed gh 2.103.2: gh auth status --active --help exits 0, and the same command with an unknown flag exits 1.
• Full suite under python -m unittest discover -s tests: 2909 tests pass, 7 skipped.
• ruff format --check, ruff check, mypy, the prose gate against origin/develop, and shellcheck, shfmt and PSScriptAnalyzer via scripts/docker_lint.py all pass.

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 2ba49a740cd684cc64ebbbae7fe2570c4bb67f28, the content this pull request carries at that commit against develop, and it recorded 1 finding.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: feature/auto-3378
• File: .coderabbit.yaml
• Commit: 85f0ce6
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6ce902f8-59e6-4133-aa41-2837b01c15d8

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ptr727]

A recorded local strict-review pass covers head a10982dc06d51a23b6f79cb75a76dccf6bd7c1ca, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[Copilot]

🟡 Changes recommended

An unresolved moderate test-coverage finding remains, along with two maintainability findings.

2 open issues

• Add Show-Status regression test for nonzero found output · New
• Share HTTP status parser between audit.py and pr_review.py · New

What changed in this PR

This pull request replaces subprocess failure handling based on message prose with exit-status checks, structured HTTP status parsing, and explicit listing operations across the audit, installer, and GitHub host setup tools.

Changes:

• Classifies gh api absence only from the (HTTP 404) status notation.
• Uses marketplace and plugin listings to determine whether Claude registration and installation are needed.
• Replaces prose-based capability and known-host checks with exit-status checks on Linux and Windows, with updated tests and documentation.

File	Description	Review comments
tests/​test_skills_install.py	Tests listing-based skips and status-based installation failures.	—
tests/​test_setup_github.py	Tests Linux and Windows capability probes and Windows known-host behavior.	Nit (P2, 4 votes): Share the duplicated PowerShell harness preamble.
tests/​test_audit_helpers.py	Tests structured 404 handling and unexpected failure cases.	—
spec/​audit.py	Reads marked HTTP status codes when classifying gh api failures.	Nit (P2, 4 votes): Reuse a shared HTTP-status parser with the existing implementation.
scripts/​skills_install.py	Uses marketplace and plugin listings before running Claude commands.	—
scripts/​README.md	Documents listing-based skips and status-based failure handling.	—
host-setup/​windows/​setup-github.ps1	Uses exit statuses for gh --active and known-host checks.	Moderate (2 votes): Add coverage for the Show-Status path with a nonzero ssh-keygen status and found output.
host-setup/​linux/​setup-github.sh	Probes gh --active support using exit status.	—

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@636ddff). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #3455   +/-   ##
==========================================
  Coverage           ?   80.89%           
==========================================
  Files              ?       23           
  Lines              ?     8845           
  Branches           ?        0           
==========================================
  Hits               ?     7155           
  Misses             ?     1690           
  Partials           ?        0           

Flag	Coverage Δ
python-3.13	80.89% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ptr727]

A recorded local strict-review pass covers head 85f0ce608c5aad2552c848a3dfcdd8ed7b27cad6, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[ptr727]

Answering the Copilot round's threadless nit on tests/test_setup_github.py, 'Share the duplicated PowerShell harness preamble': fixed in a10982d. One windows_harness(params, functions, body) builder now writes the parse-and-dot-source preamble for both the GitHub CLI harness and the known-host harness. Copies of the same pattern in tests/test_install_tools.py and tests/test_bootstrap.py are in files this change does not touch, so they appear under Dropped findings in the body.