Repository navigation
Say Only the Prose Gate Is Diff-Scoped in the Commit Hook - #3450
Merged
Merged
Conversation
The Lint-group comment in both VS Code task snippets, and the matching sentence in the husky and pre-commit snippet READMEs, said the hook runs the prose and EOL gates diff-scoped. The hook's EOL entry runs repo_gate.py --check eol over the whole tree, so only the prose gate is diff-scoped, and Lint: EOL runs the same check on demand rather than a whole-repo variant of it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ences GOVERNANCE.md called the hook's doc gates diff-scoped and described Lint: EOL as a whole-repo variant of a diff-scoped hook gate. Only the prose gate is diff-scoped, so both statements now say so. The two snippet README sentences this change lengthened are split. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ptr727
added
the
comments
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Owner
Author
|
A recorded local strict-review pass covers head |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed documentation and comments accurately reflect the implemented gate scopes, with no unresolved review issues.
No open issues 🎉
What changed in this PR
This pull request corrects documentation and task comments to distinguish the diff-scoped prose gate from the whole-tree EOL gate used by commit hooks and VS Code tasks.
Changes:
- Corrected both VS Code task snippet comments.
- Updated Husky and pre-commit documentation.
- Clarified the corresponding governance guidance.
| File | Description |
|---|---|
GOVERNANCE.md |
Corrects the documented scope of the hook and VS Code lint tasks. |
catalog/snippets/pre-commit/README.md |
Documents the separate prose and whole-tree EOL behavior. |
catalog/snippets/husky/README.md |
Documents the separate prose and whole-tree EOL behavior. |
catalog/snippets/configs/vscode-tasks.json |
Corrects the task comments for prose and EOL scope. |
catalog/snippets/configs/vscode-tasks-python.json |
Applies the same scope clarification to the Python task configuration. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3450 +/- ##
==========================================
Coverage ? 80.78%
==========================================
Files ? 23
Lines ? 8840
Branches ? 0
==========================================
Hits ? 7141
Misses ? 1699
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptr727
added a commit
that referenced
this pull request
Oct 25, 2026
…nd Nine Fixes to Main (#3472) ## Summary Promotes the pull requests merged into develop since release 2.0.1166. - [#3444](#3444): keeps untracked files out of the pre-commit snippet's prose gate. - [#3446](#3446): exempts the BuildKit `check=` parser directive in the prose gate. - [#3448](#3448): compares intent staleness against the hub's own copy and names the moved canonical. - [#3450](#3450): says only the prose gate is diff-scoped in the commit hook. - [#3453](#3453): reclassifies HolidayLights as an operational config repository in the registry. - [#3455](#3455): classifies the remaining subprocess failures by status rather than by prose. - [#3464](#3464): splits the semicolon series in WORKFLOW.md's filesystem output-seam bullet. - [#3466](#3466): audits a caller's `workflow-model` input against the registry. - [#3469](#3469): emits one snapshot shape from the skills report's cannot-read paths. - [#3462](#3462): splits `pr_review.py`'s pure check and round readers into the leaf modules `pr_review_checks.py` and `pr_review_rounds.py`. - [#3470](#3470): holds a covered held `wait` while any workflow run on the head has not completed. - [#3473](#3473): answers this promotion's review. The `wait` help and `scripts/README.md` now say what a held head's exit `0` does not prove: a `CHECKS UNREADABLE` payload, the conditions the unregistered-required-check hold reads, and the reach of the completed-run read. The exit code itself stays for #3471. Closes #3370 Closes #3372 Closes #3371 Closes #3369 Closes #3378 Closes #3454 Closes #3332 Closes #1759 Closes #3451 ## Constituent coverage Each change this promotion carries had coverage on its own pull request into develop, at its merged head: | Pull request | Merged head | Coverage | | --- | --- | --- | | [#3444](#3444) | `a61d1e2a` | attested local pass at the merged head, base `develop` | | [#3446](#3446) | `0a0efea1` | attested local pass at the merged head, base `develop` | | [#3448](#3448) | `c2c71ea7` | attested local pass at the merged head, base `develop` | | [#3450](#3450) | `4ec37c34` | attested local pass at the merged head, base `develop` | | [#3453](#3453) | `f20a543c` | a Copilot round on the merged head, its one changed file, no open findings | | [#3455](#3455) | `85f0ce60` | attested local pass at the merged head, base `develop` | | [#3464](#3464) | `fcd48e2d` | attested local pass at the merged head, base `develop` | | [#3466](#3466) | `3426a19c` | attested local pass at the merged head, base `develop` | | [#3469](#3469) | `ea4b0bb7` | attested local pass at the merged head, base `develop` | | [#3462](#3462) | `236eceab` | attested local pass at the merged head, base `develop` | | [#3470](#3470) | `3545ba46` | attested local pass at the merged head, base `develop` | | [#3473](#3473) | `46010530` | attested local pass at the merged head, base `develop`, and a Copilot table on an earlier head naming exactly the changed files | 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lint-group comment in both VS Code task snippets said the commit hook runs the prose and EOL gates diff-scoped. Only the prose gate is diff-scoped there. The hook's EOL entry runs
repo_gate.py --check eolwith no--diff, over the whole tree, soLint: EOLruns the hook's own check on demand rather than a whole-repo variant of it.catalog/snippets/configs/vscode-tasks.jsonandcatalog/snippets/configs/vscode-tasks-python.json: the two comment lines now say the prose gate is diff-scoped and the EOL gate whole-tree, with no line added.catalog/snippets/husky/README.mdandcatalog/snippets/pre-commit/README.md: the matching "same prose/EOL gates in whole-repo mode" sentences carried the same claim and are corrected and split.GOVERNANCE.md"Running the Linters Locally (Known-Working Invocations)": "the diff-scoped doc gates" becomes "the doc gates", and the VS Code Lint tasks bullet no longer callsLint: EOLa whole-repo version of a diff-scoped hook gate.The change edits comment lines, so it carries the
commentslabel.Pre-existing findings, not filed
GOVERNANCE.md:292, style: removing one word from that single-line bullet brings its existing long sentences (27 to 46 words) into the diff-scoped--check sentence-lengthread. The change wrote none of them, and the default prose gate passes.Closes on promotion: #3369
🤖 Generated with Claude Code