[ptr727]

Summary

• Excluded-files refusal (Copilot Refuses a Pull Request Carrying Only Default-Excluded Files, and No Rule Covers It #2180, decided via Decide: What closes Merge Gate item 2 for a pull request whose only changed files are in Copilot's default review exclusions (for example a lone uv.lock), when Copilot posts "wasn't able to review any files? #3740). Copilot's "wasn't able to review any files in this pull request" refusal now reads as its own excluded refusal kind in scripts/reviewers/copilot.json. It no longer blocks local_cover, so on a pull request into a non-default branch the attested local pass covers the head. wait exits 49 until that pass is attested and 0 after. Where no local pass can cover the head, as on a promotion, wait exits 41 with its own status=REVIEW_EXCLUDED_FILES_ONLY line. That line says neither re-requesting nor splitting clears it and hands it to the maintainer.
• The body-less liveness read takes a head refusal for a finished round. So when it reports the head done, wait reads the full payload once and reuses it for the final read. The new polled_past helper then decides whether an excluded-files refusal holds the head for its local pass, or waits on a pending request. A held head gets the same check poll as any other.
• Earlier-head refusal (Make pr_review.py and Merge Gate Item 2 Agree on an Earlier-Head Copilot Refusal #3571). The pr-review-conduct Merge Gate item 2 text now says what the code already does. On a pull request into a non-default branch, an attested local pass on a later head clears an earlier-head quota or error refusal, coverage=local. The wait help text says the same. A test pins the error-refusal case beside the existing quota one.
• Copilot label spellings (Read Copilot's "Review Findings Remain:" Label in pr_review.py #3732, Add Copilot's Open Review Findings Label to the Review Reader #3713). review findings remain: and open review findings: are added to the Copilot reader's labels and finding_lists, with test cases.
• Lineless-file allowance (State the Lineless-File Allowance Where the Prose Describes Copilot Table Coverage #3726). Item 2, the canonical .github/copilot-instructions.md coverage paragraph, and GOVERNANCE.md "PR Review Etiquette" now say a file table may leave out a file with no changed line, such as a binary. The same sentence was missing from that GOVERNANCE.md section, so it is fixed there too. The copilot-instructions paragraph also names the excluded-files refusal as the one refusal on the head that does not block the local-pass reading.
• The vocabulary test now checks that each reviewer file's refusal kinds are a subset of REFUSALS, with Copilot's file carrying all of them. That lets the CodeRabbit and Qodo files leave out a kind their reviewer never posts.

Local pass findings

• introduced, scripts/pr_review_rounds.py polled_past: the excluded branch did not require that no Copilot round covers the head. Fixed in 6a0b134, with a test that fails without it.

Deferred, filed

• introduced, scripts/pr_review_digest.py refusal_field: an excluded-files refusal prints refusal=YES, like a file-count one. Deferred to Describe the Excluded-Files Refusal Kind in scripts/README.md and the Digest's refusal= Field #3777, since that file sits outside this change's file claim.
• introduced, scripts/README.md lines 232 and 254: the refusal kinds list and the wait exit 41 paragraph leave out the excluded kind and the later-head local cover. Deferred to Describe the Excluded-Files Refusal Kind in scripts/README.md and the Digest's refusal= Field #3777 for the same reason.

Not fixed here

#3758 stays open. run_wait already requests nothing on a pull request into a non-default branch, attested or not (test_a_feature_pull_request_with_no_round_is_never_requested). On the recent feature pull requests sampled, the Copilot request lands about two seconds after the pull request is created, before any wait runs, and the develop ruleset carries no Copilot rule. So the request comes from the platform when the pull request is created rather than from pr_review.py. The evidence is on the issue.

Closes on promotion: #3571, #2180, #3732, #3713, #3726

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head beede88b7cfd27fac48754682fcf522503ad84df, the content this pull request carries at that commit against develop, and it recorded 1 finding.

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: feature/burn-3758
• File: .coderabbit.yaml
• Commit: 6a0b134
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: ad0dca53-43f4-48c4-93cc-18cf5c412bad

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[ptr727]

A recorded local strict-review pass covers head 6a0b134b0f5a2713eb7556c816a52c1699e4c970, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[Copilot]

🟡 Changes recommended

A moderate active finding remains in scripts/pr_review_rounds.py that can cause an unattested feature PR to rely on an excluded-files refusal and exit incorrectly instead of using the real head review.

1 open issue

• Don't skip a real head review for a later refusal · New

What changed in this PR

This pull request adds explicit handling for Copilot reviews refused because all files are excluded, aligns review-gate guidance with existing behavior, and expands Copilot finding-label recognition.

Changes:

• Adds the excluded refusal kind, dedicated wait statuses, local-pass handling, and regression tests.
• Documents earlier-head refusal coverage and lineless-file allowances across governance and review instructions.
• Adds Copilot finding-label spellings and validates reviewer refusal vocabulary.
• An unresolved edge case remains in polled_past: an excluded refusal after a genuine review of the current head can incorrectly force an unattested feature pull request to await a local pass.

This pull request requires changes.

File	Description
tests/​test_pr_review.py	Tests excluded-file refusals, local coverage, polling, and stale refusals.
tests/​test_pr_review_copilot.py	Tests refusal vocabulary and additional finding-list labels.
scripts/​reviewers/​copilot.json	Adds the excluded refusal kind and Copilot finding-label spellings.
scripts/​pr_review.py	Updates wait behavior, statuses, and excluded-refusal handling.
scripts/​pr_review_rounds.py	Adds excluded-refusal detection, polling behavior, and local coverage rules.
scripts/​pr_review_copilot.py	Adds excluded to the refusal vocabulary.
GOVERNANCE.md	Documents lineless-file table coverage.
.github/​skills/​pr-review-conduct/​SKILL.md	Aligns merge-gate guidance with refusal and coverage behavior.
.github/​copilot-instructions.md	Documents lineless-file allowances and excluded-refusal handling.
.claude-plugin/​fleet-skills/​skills/​pr-review-conduct/​SKILL.md	Updates the generated review-conduct skill distribution.
.claude-plugin/​fleet-skills/​.source-digests/​pr-review-conduct	Updates the generated skill source digest.
.agents/​skills/​pr-review-conduct/​SKILL.md	Updates the authored review-conduct skill source.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.34%. Comparing base (71194c9) to head (6a0b134).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3775      +/-   ##
===========================================
+ Coverage    82.31%   82.34%   +0.02%     
===========================================
  Files           28       28              
  Lines         9438     9454      +16     
===========================================
+ Hits          7769     7785      +16     
  Misses        1669     1669              

Flag	Coverage Δ
python-3.13	82.34% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.