Skip to content

Skip Released Claim Comments in the backlog-burndown Claim Lookup - #3781

Merged
ptr727 merged 1 commit into
developfrom
feature/burn-3778-fix3
Nov 1, 2026
Merged

ptr727 merged 1 commit into
developfrom
feature/burn-3778-fix3

Conversation

@ptr727

@ptr727 ptr727 commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Summary

The backlog-burndown claim lookup read a released claim comment as a live claim, because nothing gave a release a shape the lookup could match. This was raised on #3776 and in two rounds of #3778.

  • A release edit now opens with the fixed prefix **Released (<date>):** and why the claim holds no files, with the claim text kept below it. That is the shape the orchestrator already writes.
  • The lookup's jq adds (.body | startswith("**Released") | not), so a comment opening with a release no longer counts as a claim.
  • The generated trees are regenerated with scripts/build_dist.py, and --check passes.

Verification

The new lookup ran live and read-only through gh issue list --jq against the open issues. For a branch whose round-1 claims were released, the old predicate matched every issue holding a released claim. The new one matched only the issues where a write-access comment that does not open with **Released still names the branch.

Pre-existing findings, filed

Closes on promotion: #1275

🤖 Generated with Claude Code

A release edit now opens with the fixed prefix `**Released (<date>):**`,
and the backlog-burndown claim lookup's jq excludes a comment opening
with `**Released`, so the in-flight scan no longer reads a released
claim as live.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 1, 2026 20:55
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ptr727

ptr727 commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head e1d38f8b815cac90423e96953f61eb7315d87904, the content this pull request carries at that commit against develop, and it recorded 1 finding.

@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.34%. Comparing base (5190402) to head (e1d38f8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3781   +/-   ##
========================================
  Coverage    82.34%   82.34%           
========================================
  Files           28       28           
  Lines         9454     9454           
========================================
  Hits          7785     7785           
  Misses        1669     1669           
Flag Coverage Δ
python-3.13 82.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the claim-release lookup change is reflected across the canonical instructions, generated skill copies, and source digest.

No open issues 🎉

What changed in this PR

This pull request updates the backlog-burndown claim lookup so released claim comments are excluded from live-claim detection, while regenerating the distributed skill files and source digest.

Changes:

  • Defines the **Released (<date>):** prefix and released-claim behavior.
  • Excludes comments beginning with **Released from the claim lookup.
  • Regenerates the GitHub and Claude skill distributions and updates the source digest.
  • Includes one documentation wording nit clarifying the release description.
File Description
.github/​skills/​backlog-burndown/​SKILL.md Generated GitHub Copilot skill copy.
.claude-plugin/​fleet-skills/​skills/​backlog-burndown/​SKILL.md Generated Claude skill copy.
.claude-plugin/​fleet-skills/​.source-digests/​backlog-burndown Updated source digest for the generated distribution.
.agents/​skills/​backlog-burndown/​SKILL.md Canonical skill instructions defining released claims and filtering them from lookup.

Review effort: Lite

@ptr727
ptr727 merged commit 429294b into develop Nov 1, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/burn-3778-fix3 branch November 1, 2026 21:09
ptr727 added a commit that referenced this pull request Nov 1, 2026
…xcluded-Files Refusal, and Fix backlog-burndown and Prose Gate Gaps (#3778)

Promotes the changes merged into `develop` since promotion #3762 to
`main`, the first round of a backlog burndown.

- [#3764](#3764) reads a
bare push whose branch the write guard cannot read as writing every
protected default (`main`, `master`, `develop`), as `--all` is. That
covers a run-time `cd`, `git -C` or `env -C`, an exported `GIT_DIR`, and
a command that can switch the branch before the push. It also drops the
unused `_bare_push_branch` parameters. Naming the branch in the refspec
is the remedy, per the maintainer's decisions on #3729 and #3730.
- [#3765](#3765) has the
prose gate's diff mode report what a move adds by checking a moved file
at its old path and its new path, replacing the hand-kept
`path_readings` table. It also reads a script whole when an edited
shebang changes its lexer.
- [#3776](#3776) fixes
`backlog-burndown`'s ranking, claim, liveness and cleanup gaps:
  - An attended run holds an unapproved agent-safety issue.
- Claim comments name their branch in backticks and are released by an
edit.
  - A silent worker counts as finished only with a merged pull request.
  - The orchestrator removes a standalone clone after its merge.
  - An abandoned worker discards its own uncommitted edits.
- [#3775](#3775) reads
Copilot's excluded-files refusal as its own `excluded` kind, which an
attested local pass covers on a pull request into a non-default branch.
It aligns Merge Gate item 2 with the code on an earlier-head refusal,
adds two Copilot label spellings, and states the lineless-file allowance
where the prose describes table coverage.
- [#3779](#3779) deletes
an abandoned group's pushed branch with a checked remote delete before
its claim is released, and says the claim lookup's `<branch>` is
replaced before it runs. It answers this promotion's first review round.
- [#3781](#3781) has a
release open the claim comment with `**Released (<date>):**`, and has
the claim lookup skip a comment that opens with it. It answers this
promotion's second review round.
- [#3782](#3782) has
`pr_review.py wait` poll a pending review request past an excluded-files
refusal under `--request` as well. It answers this promotion's second
review round.

Fixes #3729
Fixes #3730
Fixes #3723
Fixes #3711
Fixes #3714
Fixes #3761
Fixes #1275
Fixes #1274
Fixes #1306
Fixes #1301
Fixes #3733
Fixes #3571
Fixes #2180
Fixes #3732
Fixes #3713
Fixes #3726

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants