Skip to content

x86: c-variadic functions don't use registers with -Zregparm - #163622

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:regparm-c-variadic
Oct 4, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:regparm-c-variadic

Conversation

@folkertdev

Copy link
Copy Markdown
Contributor

tracking issue: #131749

There are lots of other things wrong with the implementation, but that'll require a larger PR (and also GCC and clang currently disagree). May as well just lock this in now.

r? beetrees

@folkertdev folkertdev added the -Zregparm Unstable option: -Zregparm label Oct 1, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 1, 2026
@rustbot

rustbot commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

beetrees is currently at their maximum review capacity.
They may take a while to respond.

@beetrees beetrees left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1956fd1 has been approved by beetrees

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2026
@beetrees

beetrees commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

@bors rollup

rust-bors Bot pushed a commit that referenced this pull request Oct 4, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #161491 (Rip out old solver coherence)
 - #163533 (Run cg_gcc tests with the correct compiler)
 - #163223 (regression test for async handler normalization ICE)
 - #163367 (simplify rustc_log a bit)
 - #163622 (x86: c-variadic functions don't use registers with `-Zregparm`)
 - #163653 (callconv: mips64: Match GCC for alignment of 16-byte scalars)
 - #163665 (Parser: Refactor & better document `should_continue_as_assoc_expr` & `can_continue_expr_unambiguously`)
 - #163742 (Add the `movdir64b` and `movdiri` x86 target features)
 - #163752 (Revert "implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]")
@rust-bors
rust-bors Bot merged commit 29f9ea9 into rust-lang:main Oct 4, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 4, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 4, 2026
Rollup merge of #163622 - folkertdev:regparm-c-variadic, r=beetrees

x86: c-variadic functions don't use registers with `-Zregparm`

tracking issue: #131749

There are lots of other things wrong with the implementation, but that'll require a larger PR (and also GCC and clang currently disagree). May as well just lock this in now.

r? beetrees
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-Zregparm Unstable option: -Zregparm S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants