Repository navigation
ci(release): look past auto-changelog commits in the green-commit check - #6372
Merged
Merged
Conversation
Every merge to master is followed by an "chore(changelog): auto-add entry" commit, which runs no CI. The nightly checked only master HEAD, so it warned "no green required checks; this nightly is unverified" on almost every run, even when the merged PR passed. --check now walks back over release-bookkeeping commits (auto-changelog, version bumps, runtime publishes, [skip ci]) and judges the newest real change. The weekly scan uses the same list and now skips auto-changelog commits explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in today's nightly dry run (run 40398097782). It warned:
2a568f3f5is the auto-changelog commit for #6366. Every merge to master is followed by one of these, and they run no CI, so as things stand almost every nightly would carry this warning even though the merged PR passed.Change (
.github/scripts/find-green-commit.sh)--check(used by the nightly) walks back over release-bookkeeping commits and judges the newest real change. Bookkeeping commits are auto-changelog entries, version bumps, runtime publishes and[skip ci]commits. It still fails if that change's required checks are missing or not passing.is_bookkeepinglist, so auto-changelog commits are now skipped explicitly; before, they were only rejected after an API lookup. The selection result is unchanged.Tested against real master commits
--check 2a568f3f5(auto-changelog for #6366)6a740e59c--check 6a740e59c(#6366 merge)--check 7b11001b9(auto-changelog for #6363, the v3.0.0 tag)--check 2a568f3f5withREQUIRED_CHECKS="No Such Check"6a740e59c6a740e59c, skipping the changelog commit without an API callbash -npasses. The release workflow is still disabled; the schedule gets enabled after this merges.🤖 Generated with Claude Code