[taliesin-ai]

Merge before 15:00 UTC today, or the first scheduled nightly will fail.

Found in the weekly dry run (run 40401196251). It failed at "Verify changelog workflow evidence":

RuntimeError: Cannot determine whether changelog run commit 6a0733f… is in this release

Cause

• Auto Changelog runs on pull_request_target, so each run's head_sha is the PR branch head, here 6a0733f3a for ci(release): look past auto-changelog commits in the green-commit check #6372.
• PRs are squash-merged and the repo has delete_branch_on_merge=true, so that commit is neither in master's history nor fetchable by the release checkout.
• git merge-base --is-ancestor therefore errors, and the script fails closed. Any release containing a merged PR with a deleted branch is blocked, which covers nearly all of them, including tonight's nightly. The nightly dry run on Monday only passed because the docs(v3): full v3.0.0 release notes and correct the advisory claim #6363 to docs: open the same page on v2.wails.io from the 404 page #6366 branches still existed.

Fix (v3/scripts/check-changelog-runs.py)

• Only unsuccessful runs are looked up. A successful run never blocks. That alone fixes this failure, since ci(release): look past auto-changelog commits in the green-commit check #6372's run succeeded.
• Squash merges are handled. A run counts as part of the release when its commit, or the merge commit of the merged PR headed at it (via commits/{sha}/pulls), is an ancestor of the release snapshot. That's what the check was meant to verify.
• Still fails closed for an unknown commit with no merged PR.

Tested

• Unit tests: 8 pass, 6 of them new. They cover a deleted-branch PR merged into the snapshot, a PR merged after the snapshot, a commit outside the snapshot, failing closed, and no lookup for successful runs.
• The real check against live changelog runs passes at both the weekly snapshot 6a740e59c and master. 6a0733f3a resolves to ci(release): look past auto-changelog commits in the green-commit check #6372's merge commit d2ac69f24.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved release changelog checks so runs are matched more reliably to the release snapshot, including changes brought in through merged pull requests. Missing or unrelated commits are handled more accurately.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The script filters successful and skipped runs before checking snapshot membership. It recognizes commits through ancestry or an associated merged PR commit. Unknown commits without a matching merged PR raise an error.

Changes

Changelog snapshot matching

Layer / File(s)	Summary
Filter runs by conclusion v3/scripts/check-changelog-runs.py, v3/scripts/test_check_changelog_runs.py	Successful and skipped runs are filtered before snapshot checks. A test verifies that successful runs do not trigger ancestry lookup.
Resolve snapshot commits v3/scripts/check-changelog-runs.py, v3/scripts/test_check_changelog_runs.py	Commit matching checks ancestry and associated merged PR merge commits. Git ancestry errors return an unknown result. Tests cover snapshot membership, later merges, and unknown commits without a merged PR.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested labels: Bug, v3

Suggested reviewers: leaanthony

Merge Risk: Moderate · up to 75dd4

The release check can pass when a failed changelog run's merge commit can't be resolved locally, so it can let an incomplete release through. Treat unknown merge-commit ancestry as an error before merging. Also add a timeout to the new GitHub lookup so a stalled call doesn't hang the release job.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks each changelog run,
And skips the ones whose work is done.
Through commit trails and merged PRs,
It finds the snapshot where it stirs.
Unknown paths raise a clear alert,
Then hops away with checks kept curt.}

_{Comment @coderabbitai help to get the list of available commands.}