Skip to content

fix(release): run master's changelog evidence check in the weekly - #6374

Merged
leaanthony merged 1 commit into
masterfrom
ci/weekly-release-tools-from-master
Oct 26, 2026
Merged

leaanthony merged 1 commit into
masterfrom
ci/weekly-release-tools-from-master

Conversation

@taliesin-ai

@taliesin-ai taliesin-ai commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Needed before Sunday's first weekly. Without it, the weekly fails at "Verify changelog workflow evidence", as the dry run after #6373 showed (run 40402111631).

Cause

The weekly checks out the newest green master commit before releasing, and every later step then ran the release checks from that commit. CI-only PRs such as #6372 and #6373 never count as green, because the v3 test workflow doesn't run on them. So the snapshot (6a740e59c, #6366) predates #6373's fix, and the weekly ran the old evidence script ("Ran 2 tests") and failed on a deleted PR branch again.

Change (.github/workflows/nightly-release-v3.yml)

  • Before the snapshot checkout, copy master's check-changelog-runs.py and its tests to $RUNNER_TEMP/release-tools and run that copy. The nightly, which has no snapshot, still runs v3/scripts.
  • Unchanged:
    • The release gate and green-commit selection already run before the checkout, so they use master's versions.
    • The release script still runs on the snapshot, which its --tag-only mode needs: it commits the version bump on top of the green commit and tags that.

Verified

A weekly dry run using this branch's workflow, checking out and releasing from master (run 40402423945), succeeded end to end:

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated weekly release checks to keep changelog validation available when evaluating a specific commit. No user-facing changes.

The weekly checks out the newest green commit before releasing, and every
later step then ran the release checks from that commit. CI-only PRs never
become "green" (the v3 test workflow does not run on them), so the snapshot
can predate fixes to the checks: the weekly dry run after #6373 still ran
the old evidence script and failed on a deleted PR branch.

Copy master's check-changelog-runs.py and its tests before the snapshot
checkout and run that copy. The release gate and green-commit selection
already run before the checkout; the release script still runs on the
snapshot, which its tag-only mode needs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The weekly release workflow copies the changelog checker and its test before checking out the selected green SHA. The changelog-evidence step uses the copied tools when available and otherwise uses v3/scripts.

Changes

Weekly changelog tools

Layer / File(s) Summary
Copy and run changelog tools
.github/workflows/nightly-release-v3.yml
The weekly step copies the checker and its test to a temporary directory before the detached checkout and publishes the directory as tools. The changelog-evidence step uses that directory when set and otherwise uses v3/scripts.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: Bug, v3

Suggested reviewers: leaanthony

Merge Risk: Minimal · up to 87bce

No actionable merge-blocking risk is established for this workflow change.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit packs the scripts with care,
Before the green commit lands there.
The checker hops to its new place,
The test follows at a steady pace.
If tools are gone, the old path’s there!

Comment @coderabbitai help to get the list of available commands.

@leaanthony
leaanthony merged commit 80b4daf into master Oct 26, 2026
26 of 28 checks passed
@leaanthony
leaanthony deleted the ci/weekly-release-tools-from-master branch October 26, 2026 21:17
leaanthony pushed a commit that referenced this pull request Oct 26, 2026
…ter's changelog evidence check in the weekly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants