Repository navigation
fix(release): run master's changelog evidence check in the weekly - #6374
Conversation
The weekly checks out the newest green commit before releasing, and every later step then ran the release checks from that commit. CI-only PRs never become "green" (the v3 test workflow does not run on them), so the snapshot can predate fixes to the checks: the weekly dry run after #6373 still ran the old evidence script and failed on a deleted PR branch. Copy master's check-changelog-runs.py and its tests before the snapshot checkout and run that copy. The release gate and green-commit selection already run before the checkout; the release script still runs on the snapshot, which its tag-only mode needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. WalkthroughThe weekly release workflow copies the changelog checker and its test before checking out the selected green SHA. The changelog-evidence step uses the copied tools when available and otherwise uses ChangesWeekly changelog tools
Priority: Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Possibly related PRs
Suggested labels: Suggested reviewers: Merge Risk:
|
…ter's changelog evidence check in the weekly
Needed before Sunday's first weekly. Without it, the weekly fails at "Verify changelog workflow evidence", as the dry run after #6373 showed (run 40402111631).
Cause
The weekly checks out the newest green master commit before releasing, and every later step then ran the release checks from that commit. CI-only PRs such as #6372 and #6373 never count as green, because the v3 test workflow doesn't run on them. So the snapshot (
6a740e59c, #6366) predates #6373's fix, and the weekly ran the old evidence script ("Ran 2 tests") and failed on a deleted PR branch again.Change (
.github/workflows/nightly-release-v3.yml)check-changelog-runs.pyand its tests to$RUNNER_TEMP/release-toolsand run that copy. The nightly, which has no snapshot, still runsv3/scripts.--tag-onlymode needs: it commits the version bump on top of the green commit and tags that.Verified
A weekly dry run using this branch's workflow, checking out and releasing from
master(run 40402423945), succeeded end to end:6a740e59c.v3.0.0→v3.1.0, weekly,prerelease=false,make_latest=true, npm taglatest.🤖 Generated with Claude Code
Summary by CodeRabbit