Aclp sync25thmar - #651
Aclp sync25thmar#651venkymano-akamai wants to merge 31 commits into
Conversation
* fix: [UIE-10338] marketplace fixes * fix: [UIE-10338] added changeset * fix: [UIE-10338] fixed unit tests
…ent tab (linode#13501) * fix: [UIE-10352] Added capability to open links in markdown in different tab * fix: [UIE-10352] added changeset
…Alerting in Linode Edit flow (linode#13455) * Save progress * More changes and some clean up... * Handle unified and standalone linode updates * Fix the ACLP alerts accordion collapse transition issue * Remove unnecessary default margins when stacking Accordions in edit flow * General error handling + some styling fixes * More changes * Handle root errors as well * Add scrollErrorIntoViewV2 for unified errors * Some more changes * Save progress * New approach * Allow simultaneous alerting in linode edit flow * Some more changes * Update mocks and remove the remaining useIsLinodeAclpSubscribed references * Fix CloudPulse ContextualView test cases * Update comments * Fix stale state: reset ACLP alerts to empty when entering ACLP mode * Added changeset: Allow simultaneous v1 (Legacy) and v2 (ACLP) alerting in Linode edit flow * Added changeset: The `useIsLinodeAclpSubscribed` hook from the shared package * Added changeset: Simplify `UpdateLinodeAlertsSchema` to support simultaneous legacy and ACLP alerting * Update comment * Don't allow unified saving if aclp reusable component is not ready * Fix unit tests * Few changes to aclp components * Update comments for clarity * Update changeset and consolidate imports * Update comments and exclude fields from payload for bare metal type * Remove Bare Metal related logic from legacy Alerts
Fix browser tooltip error shown when updating `mysql.group_concat_max_len` with value `9007199254740990.6`
…hannels (linode#13495) * upcoming: [DPS-41183] - Migrate content to details for Notification Channels * add changesets
…g page (linode#13502) * Improve loading pattern * Added changeset: Improve loading pattern on Account Delegation landing page
…lds in Contact Sales Drawer (linode#13483) * fix: [UIE-10472] - Remove unintended validation on optional email fields in Contact Sales Drawer * trigger validation for additional email field * fix failing test * Added changeset: Remove unintended validation on optional email fields in Contact Sales Drawer * Added unit tests and comments for the clean up function
Bumps [simple-git](https://github.com/steveukx/git-js/tree/HEAD/simple-git) from 3.27.0 to 3.32.3. - [Release notes](https://github.com/steveukx/git-js/releases) - [Changelog](https://github.com/steveukx/git-js/blob/main/simple-git/CHANGELOG.md) - [Commits](https://github.com/steveukx/git-js/commits/simple-git@3.32.3/simple-git) --- updated-dependencies: - dependency-name: simple-git dependency-version: 3.32.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
…ker on enter (linode#13489) * change: [DPS-41214] - Stream and Destination Empty Landing pages flicker on enter * Added changeset: Streams and Destinations Landing page initial load spinner added before empty state * change: [DPS-41214] - CR changes 1 * Added changeset: Keep previous data in streams and destinations paginated queries
…node#13511) * test: [UIE-10422] - DBaaS - Fixing flaky ServiceURI.spec.ts tests * Adding changeset * Removing unnecessary changeset
…de#13499) * feat: add openclaw and deepseek quick deploy apps * Added changeset: Add DeepSeek-R1 and OpenClaw to Quick Deploy Apps * Added changeset: Add DeepSeek-R1 and OpenClaw to Quick Deploy Apps * Added changeset: Add DeepSeek-R1 and OpenClaw to Quick Deploy Apps * add changeset * remove dup changesets * Added changeset: Add DeepSeek-R1 and OpenClaw to Quick Deploy Apps * add changeset --------- Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
…vements (linode#13507) * upcoming: [DPS-36770] - Custom HTTPS form - UX and Tech Writing improvements * upcoming: [DPS-36770] - Code review changes * upcoming: [DPS-36770] - Prepare stream details on deactivate/activate stream fix * upcoming: [DPS-36770] - Prepare destination details fix * upcoming: [DPS-36770] - Stream form: filtering clusters by log generation fix
…udPulse metrics dashboards (linode#13497) * upcoming: [DPS-41595] - Utility setup changes for CSV downloader in widgets * upcoming: [DPS-41595] - Changeset * upcoming: [DPS-41595] - Integration of CSV downloader and utils, context setup * upcoming: [DPS-41595] - Pendo ID support * upcoming: [DPS-41595] - UT removal * upcoming: [DPS-41595] - Changeset * upcoming: [DPS-41595] - Refactor * upcoming: [DPS-41595] - Refactor * upcoming: [DPS-41595] - Update filters --------- Co-authored-by: santoshp210-akamai <159890961+santoshp210-akamai@users.noreply.github.com>
…ode#13505) Disable buttons to get credentials when the Database cluster is resuming
…Icons disabled tool tips (linode#13496) * upcoming: [DPS-41443] - Metrics widget dimension filter and Group By Icons disabled tool tips * add changesets * add changesets --------- Co-authored-by: venkatmano-akamai <vmangalr@akamai.com>
…node#13449) * test: [DI-30129] - Add spec for show details notification channel * Added changeset: Adding spec for show details notification channel * addressing review comments --------- Co-authored-by: shnagend-akamai <142887750+shnagend@users.noreply.github.com> Co-authored-by: dmcintyr-akamai <dmcintyr@akamai.com> Co-authored-by: santoshp210-akamai <159890961+santoshp210-akamai@users.noreply.github.com> Co-authored-by: venkatmano-akamai <vmangalr@akamai.com>
…rawer (linode#13512) * fix: [UIE-10337] updated error message * fix: [UIE-10337] added changeset
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.2.4 to 3.3.1. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.2.4...3.3.1) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.3.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
…ng for Linode Alerts and Metrics (linode#13509) * Configure New Feature Chip & Banner Messaging for aclp alerts and metrics * Update and add new tests * Added changeset: Configure new feature chip and banner messaging for ACLP Linode Alerts and Metrics * Added changeset: New `getFeatureChip` utility to shared package * Add and update LinodeAlerts tests * Add Utilities documentation in the shared pkg readme file * Add changeset in utilities pkg * Remove remaining beta references from var names in Summary.tsx * Remove beta from the comment * Minor refactoring * Update remaining beta naming references and add unit tests for newly added utility
- Add `<username>:` to the general Service URI in the Database Summary page - Display `ssl-mode=REQUIRED` for mysql clusters - Display placeholder text while hosts are still being retrieved
* build(deps): Bump jspdf from 4.2.0 to 4.2.1 Bumps [jspdf](https://github.com/parallax/jsPDF) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/parallax/jsPDF/releases) - [Changelog](https://github.com/parallax/jsPDF/blob/master/RELEASE.md) - [Commits](parallax/jsPDF@v4.2.0...v4.2.1) --- updated-dependencies: - dependency-name: jspdf dependency-version: 4.2.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Added changeset: Bump jspdf from 4.2.0 to 4.2.1 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alban Bailly <abailly@akamai.com>
…13526) * Fix LKE create test following APL feature flag flip * Added changeset: Fix test failures in lke-create.spec.ts following feature flag change
…hmar # Conflicts: # packages/manager/cypress/e2e/core/cloudpulse/alert-notification-channel-create.spec.ts # packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts # packages/manager/cypress/support/constants/cloudpulse.ts # packages/manager/cypress/support/intercepts/cloudpulse.ts # packages/manager/src/components/DownloadCSV/DownloadCSV.tsx # packages/manager/src/features/CloudPulse/Alerts/AlertsDetail/AlertDetailNotification.test.tsx # packages/manager/src/features/CloudPulse/Alerts/CreateAlert/NotificationChannels/RenderChannelDetails.test.tsx # packages/manager/src/features/CloudPulse/Alerts/CreateAlert/NotificationChannels/RenderChannelDetails.tsx # packages/manager/src/features/CloudPulse/Alerts/NotificationChannels/NotificationsChannelsListing/NotificationChannelTableRow.test.tsx # packages/manager/src/features/CloudPulse/Alerts/Utils/utils.ts # packages/manager/src/features/CloudPulse/Widget/CloudPulseWidget.tsx # packages/manager/src/features/CloudPulse/Widget/csv/CloudPulseWidgetCSVDownloader.tsx # pnpm-lock.yaml
There was a problem hiding this comment.
Pull request overview
This PR is a large “sync” bundle that updates multiple areas of the Manager monorepo, primarily around ACLP alerts/metrics UX and validation, Delivery Logs UX/validation, and feature-flagged navigation/routes (Reserved IPs), alongside several test, mock, and dependency updates.
Changes:
- Refactors ACLP Alerts/Metrics toggles/chips and unifies Linode Alerts editing (legacy + ACLP) flows.
- Improves Delivery Logs Custom HTTPS validation messages/UX and request payload normalization (incl. tls_hostname handling).
- Adds feature-flagged Reserved IPs route + nav entry, plus assorted Marketplace/DB/CloudPulse tweaks and test updates.
Reviewed changes
Copilot reviewed 147 out of 152 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/package.json | Bump simple-git dependency. |
| packages/validation/src/marketplace.schema.ts | Trim/validate optional Akamai email field. |
| packages/validation/src/linodes.schema.ts | Simplify Linode alerts validation requirements. |
| packages/validation/src/delivery.schema.ts | Improve Delivery form validation messages + URL regex. |
| packages/validation/.changeset/pr-13507-upcoming-features-1773834596237.md | Validation package changeset entry. |
| packages/validation/.changeset/pr-13455-upcoming-features-1772701959931.md | Validation package changeset entry. |
| packages/utilities/src/types/ManagerPreferences.ts | Rename preference key to isAclpMetricsMode. |
| packages/utilities/.changeset/pr-13509-changed-1774263411585.md | Utilities package changeset entry. |
| packages/shared/src/utilities/index.ts | Export shared utilities barrel. |
| packages/shared/src/utilities/getFeatureChip.tsx | Add getFeatureChip helper for beta/new chips. |
| packages/shared/src/utilities/getFeatureChip.test.tsx | Tests for getFeatureChip. |
| packages/shared/src/index.ts | Export utilities from shared package root. |
| packages/shared/src/hooks/useIsLinodeAclpSubscribed.ts | Remove deprecated ACLP subscription hook. |
| packages/shared/src/hooks/useIsLinodeAclpSubscribed.test.ts | Remove tests for deleted hook. |
| packages/shared/src/hooks/index.ts | Remove hook export. |
| packages/shared/README.md | Document utilities section for shared package. |
| packages/shared/.changeset/pr-13509-added-1773840779551.md | Shared package changeset entry. |
| packages/shared/.changeset/pr-13455-removed-1772701814738.md | Shared package changeset entry. |
| packages/queries/src/delivery/delivery.ts | Keep previous data for paginated delivery queries. |
| packages/queries/.changeset/pr-13489-changed-1773925015927.md | Queries package changeset entry. |
| packages/manager/src/routes/reservedIps/reservedIpsRoute.tsx | Add Reserved IPs route wrapper/flag gate. |
| packages/manager/src/routes/reservedIps/index.ts | Add Reserved IPs route tree + lazy index route. |
| packages/manager/src/routes/index.tsx | Register Reserved IPs route tree. |
| packages/manager/src/mocks/serverHandlers.ts | Extend ACLP alerting mocks and labels. |
| packages/manager/src/mocks/presets/crud/handlers/delivery.ts | Adjust destination create mock response handling. |
| packages/manager/src/features/ReservedIps/utils.ts | Add useIsReserveIpEnabled feature-flag hook. |
| packages/manager/src/features/ReservedIps/utils.test.ts | Tests for Reserved IPs flag hook. |
| packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLazyRoute.tsx | Lazy route for Reserved IPs landing. |
| packages/manager/src/features/ReservedIps/ReservedIpsLanding/ReservedIpsLanding.tsx | Reserved IPs placeholder landing UI. |
| packages/manager/src/features/OneClickApps/types.ts | Add “AI Agent” category type. |
| packages/manager/src/features/OneClickApps/oneClickApps.ts | Update/extend OCA entries and copy. |
| packages/manager/src/features/Marketplace/ProductDetails/ProductDetailsTabs.tsx | Allow rel + open links in new tab in Markdown. |
| packages/manager/src/features/Marketplace/ProductDetails/ContactSalesDrawer.tsx | Normalize payload, improve submit gating, copy, and UX. |
| packages/manager/src/features/Marketplace/ProductDetails/ContactSalesDrawer.test.tsx | Add tests for payload cleanup + updated UX behavior. |
| packages/manager/src/features/Marketplace/MarketplaceLanding/MarketplaceLanding.tsx | Adjust grid sizing + autocomplete UX tweaks. |
| packages/manager/src/features/Linodes/constants.ts | Expand banner/button copy for beta/new phases. |
| packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailNavigation.tsx | Replace BetaChip logic with getFeatureChip + new preference key. |
| packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailContext.tsx | Remove alerts beta-mode state from context. |
| packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/LinodeRebuildForm.test.tsx | Add tests for private image sharing UI variants + typo fixes. |
| packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/Image.tsx | Switch rebuild Image selector to table when flag enabled. |
| packages/manager/src/features/Linodes/LinodesDetail/LinodeMetrics/LinodeMetrics.tsx | Use renamed metrics preference key and simplified gating. |
| packages/manager/src/features/Linodes/LinodesDetail/LinodeAlerts/utilities.ts | Add helper for legacy alerts initial values. |
| packages/manager/src/features/Linodes/LinodesDetail/LinodeAlerts/LinodeAlerts.tsx | Implement unified legacy+ACLP alerts edit + unified save. |
| packages/manager/src/features/Linodes/LinodesDetail/LinodeAlerts/LinodeAlerts.test.tsx | Add unified-mode vs standalone-mode tests (mock ACLP component). |
| packages/manager/src/features/Linodes/LinodesDetail/LinodeAlerts/AlertsPanel.tsx | Restructure alerts panel into standalone/unified/create modes. |
| packages/manager/src/features/Linodes/LinodeCreate/utilities.ts | Rename ACLP options + add EMPTY_ACLP_ALERTS constant. |
| packages/manager/src/features/Linodes/LinodeCreate/index.tsx | Reset ACLP alerts defaults on mode toggle + option renames. |
| packages/manager/src/features/Linodes/LinodeCreate/Tabs/Images.tsx | Use new Pendo IDs constant for ImageSelectTable. |
| packages/manager/src/features/Linodes/LinodeCreate/Summary/Summary.tsx | Rename props/variables from beta to mode + keep assigned alerts summary. |
| packages/manager/src/features/Linodes/LinodeCreate/AdditionalOptions/Alerts.tsx | Use getFeatureChip, updated toggle props, and EMPTY_ACLP_ALERTS. |
| packages/manager/src/features/Linodes/LinodeCreate/AdditionalOptions/AdditionalOptions.tsx | Prop renames for ACLP alerts mode. |
| packages/manager/src/features/Linodes/LinodeCreate/Actions.tsx | Update payload builder options naming. |
| packages/manager/src/features/Linodes/AclpPreferenceToggle.tsx | Support beta/new labeling + renamed preferences + flag-driven copy. |
| packages/manager/src/features/IAM/Delegations/AccountDelegationsTable.tsx | Reduce loading skeleton rows. |
| packages/manager/src/features/IAM/Delegations/AccountDelegations.tsx | Improve loading handling (remove full-page spinner). |
| packages/manager/src/features/Delivery/deliveryUtils.ts | Omit empty/whitespace tls_hostname while keeping cert details. |
| packages/manager/src/features/Delivery/deliveryUtils.test.ts | Extend tests for tls_hostname omission behavior. |
| packages/manager/src/features/Delivery/Streams/StreamsLanding.tsx | Add initial load spinner + normalize update payload details. |
| packages/manager/src/features/Delivery/Streams/StreamForm/types.ts | Add ExtendedKubernetesCluster with regionLabel. |
| packages/manager/src/features/Delivery/Streams/StreamForm/StreamEdit.test.tsx | Use shared MASKED_VALUE constant. |
| packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.tsx | Update header copy + layout tweaks. |
| packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx | Update labels/copy to match form changes. |
| packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/DestinationCustomHTTPSDetailsSummary.tsx | Mask auth/private key, rename labels, add copyable cert display. |
| packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/DestinationCustomHTTPSDetailsSummary.test.tsx | Update tests for masked values + label changes. |
| packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/DestinationAkamaiObjectStorageDetailsSummary.tsx | Use shared MASKED_VALUE. |
| packages/manager/src/features/Delivery/Streams/StreamForm/Clusters/StreamFormClustersTableContent.tsx | Display region label instead of raw region id. |
| packages/manager/src/features/Delivery/Streams/StreamForm/Clusters/StreamFormClusters.tsx | Fix filtering by region + clarify log-generation filtering. |
| packages/manager/src/features/Delivery/Streams/StreamForm/Clusters/StreamFormClusters.test.tsx | Expand coverage for enabled/disabled log-generation filter. |
| packages/manager/src/features/Delivery/Shared/LabelValue.tsx | Add copyable values + improved layout/tooltip behavior. |
| packages/manager/src/features/Delivery/Shared/DestinationCustomHttpsDetailsForm.tsx | Rename labels + add help tooltips and layout updates. |
| packages/manager/src/features/Delivery/Shared/CustomHeaders.tsx | Add tooltips and improved header title layout. |
| packages/manager/src/features/Delivery/Destinations/constants.ts | Add shared MASKED_VALUE. |
| packages/manager/src/features/Delivery/Destinations/DestinationsLanding.tsx | Add initial load spinner; use isFetching for in-page spinner. |
| packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationForm.tsx | Disable destination type in edit mode. |
| packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx | Update labels/copy to match destination form changes. |
| packages/manager/src/features/Databases/constants.ts | Update disabled-password text + add DISABLE_CREDENTIAL_STATES constant. |
| packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.tsx | Adjust URI building + disable copy/reveal when suspended/resuming states. |
| packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.test.tsx | Update tests for username inclusion, mysql ssl param, disabled states. |
| packages/manager/src/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryConnectionDetails.tsx | Use DISABLE_CREDENTIAL_STATES for show-credentials gating. |
| packages/manager/src/features/Databases/DatabaseDetail/DatabaseStatusDisplay.tsx | Remove failed mapping after type removal. |
| packages/manager/src/features/Databases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseConfigurationItem.tsx | Add numeric input step to avoid edge tooltip issue. |
| packages/manager/src/features/CloudPulse/Widget/csv/CloudPulseWidgetCSVDownloader.tsx | Add Pendo tracking id to CSV download button. |
| packages/manager/src/features/CloudPulse/Widget/csv/CloudPulseWidgetCSVDownloader.test.tsx | Add tests for CSV downloader behavior. |
| packages/manager/src/features/CloudPulse/Widget/CloudPulseWidget.tsx | Minor formatting cleanup. |
| packages/manager/src/features/CloudPulse/Context/useCloudPulseContext.tsx | Add hook wrapper for CloudPulse context. |
| packages/manager/src/features/CloudPulse/Context/CloudPulseContextProvider.test.tsx | Add tests for CloudPulse context provider behavior. |
| packages/manager/src/features/CloudPulse/Alerts/Utils/utils.ts | Tighten channel details access (remove optional chaining). |
| packages/manager/src/features/CloudPulse/Alerts/NotificationChannels/NotificationsChannelsListing/NotificationChannelTableRow.test.tsx | Add coverage for Slack/PagerDuty/Webhook types. |
| packages/manager/src/features/CloudPulse/Alerts/CreateAlert/NotificationChannels/RenderChannelDetails.tsx | Minor formatting cleanup. |
| packages/manager/src/features/CloudPulse/Alerts/CreateAlert/NotificationChannels/RenderChannelDetails.test.tsx | Minor formatting cleanup. |
| packages/manager/src/features/CloudPulse/Alerts/ContextualView/AlertReusableComponent.tsx | Add readiness callback, paperSx, and relocate Manage Alerts button for linode. |
| packages/manager/src/features/CloudPulse/Alerts/ContextualView/AlertReusableComponent.test.tsx | Update tests for Manage Alerts placement differences. |
| packages/manager/src/features/CloudPulse/Alerts/ContextualView/AlertInformationActionTable.tsx | Hide internal save for services with external save; emit initial payload; contain layout. |
| packages/manager/src/features/CloudPulse/Alerts/ContextualView/AlertInformationActionTable.test.tsx | Update tests for serviceType behavior and linode external-save flow. |
| packages/manager/src/features/Account/Quotas/QuotasTable/QuotasTable.tsx | Treat “Not found” as empty state instead of error. |
| packages/manager/src/featureFlags.ts | Add reserveIp flag + ACLP alerting new flag; update banner location type. |
| packages/manager/src/factories/databases.ts | Remove failed from possible statuses. |
| packages/manager/src/dev-tools/FeatureFlagTool.tsx | Add reserveIp flag to dev tool list. |
| packages/manager/src/components/PrimaryNav/PrimaryNav.tsx | Add Reserved IPs nav item gated by flag. |
| packages/manager/src/components/PrimaryNav/PrimaryNav.test.tsx | Add test for Reserved IPs nav visibility. |
| packages/manager/src/components/MultipleIPInput/MultipleIPInput.tsx | Allow ReactNode button text. |
| packages/manager/src/components/Markdown/Markdown.tsx | Add openLinksInNewTab to force target/rel on links. |
| packages/manager/src/components/ImageSelect/constants.ts | Split ImageSelectTable Pendo IDs by flow (create vs rebuild). |
| packages/manager/src/components/ImageSelect/ImageSelectTableRow.tsx | Update pendoIDs typing for create/rebuild sets. |
| packages/manager/src/components/ImageSelect/ImageSelectTable.tsx | Add query param prefix + improve option rendering + responsive tweaks. |
| packages/manager/src/components/DownloadCSV/DownloadCSV.tsx | Add pendo id support; adjust iconStyles typing. |
| packages/manager/src/components/CopyTooltip/CopyTooltip.tsx | Add disabledReason tooltip support. |
| packages/manager/src/components/CopyTooltip/CopyTooltip.test.tsx | Add test coverage for disabledReason tooltip. |
| packages/manager/src/GoTo.tsx | Add Reserved IPs entry to GoTo list gated by flag. |
| packages/manager/public/assets/white/openclaw.svg | Add OpenClaw white logo asset. |
| packages/manager/public/assets/white/deepseek.svg | Add DeepSeek white logo asset. |
| packages/manager/public/assets/openclaw.svg | Add OpenClaw logo asset. |
| packages/manager/public/assets/deepseek.svg | Add DeepSeek logo asset. |
| packages/manager/package.json | Bump dompurify and jspdf. |
| packages/manager/cypress/support/constants/cloudpulse.ts | Reorder/add blockstorage mapping. |
| packages/manager/cypress/e2e/core/linodes/alerts-edit.spec.ts | Update constants for beta/new phase messaging. |
| packages/manager/cypress/e2e/core/linodes/alerts-create.spec.ts | Update constants for beta/new phase messaging. |
| packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts | Update APL expectations and comment formatting. |
| packages/manager/cypress/e2e/core/databases/update-database.spec.ts | Update expectation for disabled Show button. |
| packages/manager/cypress/e2e/core/cloudpulse/metrics-service-ld-flags.spec.ts | Fix “Linodes” label in tests. |
| packages/manager/cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts | Fix “Linodes beta” text assertions. |
| packages/manager/cypress/e2e/core/cloudpulse/alert-notification-channel-create.spec.ts | CloudPulse notification channel create spec updates. |
| packages/manager/cypress/e2e/core/cloudpulse/aclp-support.spec.ts | Update preference key + constants for beta/new phase messaging. |
| packages/manager/.changeset/pr-13526-tests-1774359841483.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13524-fixed-1774351558003.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13512-fixed-1791257453414.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13509-upcoming-features-1773840689079.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13507-upcoming-features-1773834491714.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13505-fixed-1773782546945.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13503-tech-stories-1774357306209.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13502-fixed-1773765480516.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13501-fixed-1774516931626.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13499-added-1773854043259.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13498-fixed-1782319675458.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13497-upcoming-features-1773644964686.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13496-upcoming-features-1774327007124.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13496-upcoming-features-1773424202209.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13495-upcoming-features-1773415251134.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13491-fixed-1773404088592.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13489-changed-1773395119430.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13486-upcoming-features-1773317968547.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13483-fixed-1773803172611.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13482-upcoming-features-1773352263642.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13465-fixed-1772658612856.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13455-upcoming-features-1772701630712.md | Manager changeset entry. |
| packages/manager/.changeset/pr-13449-tests-1772265280573.md | Manager changeset entry. |
| packages/api-v4/src/databases/types.ts | Remove failed from DatabaseStatus union. |
| packages/api-v4/.changeset/pr-13505-removed-1774025410092.md | api-v4 changeset entry. |
| packages/api-v4/.changeset/pr-13495-upcoming-features-1773415302171.md | api-v4 changeset entry. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <LabelValue | ||
| label="TLS Hostname" | ||
| value={client_certificate_details.tls_hostname!} | ||
| /> |
There was a problem hiding this comment.
client_certificate_details.tls_hostname is optional (and is now explicitly omitted when empty). Rendering it with a non-null assertion (!) can produce a blank/incorrect row (or hide real absence). Only render the TLS Hostname LabelValue when tls_hostname is present/non-empty.
| text="Certificate details are used to authenticate the audit log delivery service and verify the HTTPs destination during mutual TLS (mTLS( connections. This section is required only if the destination enforces client certificate authentication." | ||
| /> |
There was a problem hiding this comment.
Tooltip copy has typos/unbalanced parentheses: "HTTPs" and "(mTLS(". This reads incorrectly in the UI. Please correct the text (e.g. "HTTPS" and "(mTLS)"), and ensure parentheses are balanced.
| filename: string; | ||
| headers: { key: string; label: string }[]; | ||
| iconStyles?: React.CSSProperties; | ||
| iconStyles?: SxProps<Theme>; | ||
| onClick: (() => void) | ((e: React.MouseEvent<HTMLButtonElement>) => void); | ||
| sx?: SxProps<Theme>; |
There was a problem hiding this comment.
iconStyles is typed as SxProps<Theme>, but it’s later passed to the SVG component via the style prop (<DownloadIcon style={iconStyles} />). style expects a CSSProperties object, so this will be a type/runtime mismatch. Either keep iconStyles as React.CSSProperties, or apply MUI sx styling via a wrapper/component that supports sx.
| import type { | ||
| IMAGE_SELECT_TABLE_LINODE_CREATE_PENDO_IDS, | ||
| IMAGE_SELECT_TABLE_LINODE_REBUILD_PENDO_IDS, | ||
| } from './constants'; | ||
| import type { Image, ImageRegion, Region } from '@linode/api-v4'; |
There was a problem hiding this comment.
IMAGE_SELECT_TABLE_LINODE_CREATE_PENDO_IDS / ..._REBUILD_PENDO_IDS are value exports, but they’re imported with import type and then referenced via typeof in the prop type. TypeScript will error because typeof needs the value side of the symbol. Import these constants as values (non-type) or export a dedicated type alias from constants.ts and import that type instead.
| import type { | ||
| IMAGE_SELECT_TABLE_LINODE_CREATE_PENDO_IDS, | ||
| IMAGE_SELECT_TABLE_LINODE_REBUILD_PENDO_IDS, | ||
| } from './constants'; |
There was a problem hiding this comment.
IMAGE_SELECT_TABLE_LINODE_CREATE_PENDO_IDS / ..._REBUILD_PENDO_IDS are imported with import type, but the pendoIDs prop type uses typeof on them. That requires the value side, so this will fail typechecking. Import the constants as values or export/import a type alias instead.
| * This property indicates whether to show the "Download CSV" icon in the alert details page or not | ||
| */ | ||
| enableCSVDownload?: boolean; | ||
|
|
||
| /** |
There was a problem hiding this comment.
AclpFlag declares enableCSVDownload more than once (there is another enableCSVDownload declaration immediately below). This will cause a TypeScript duplicate property error. Remove the duplicate and keep a single definition/JSDoc.
| <<<<<<< HEAD | ||
| recipient_type: 'user', | ||
| ======= | ||
| >>>>>>> 28d5bf90e90cfcf0d97fcf80d3b17f554f3ccd07 |
There was a problem hiding this comment.
This spec file still contains unresolved git merge conflict markers (<<<<<<<, =======, >>>>>>>). The test suite will fail to parse/compile until these markers are removed and the intended details.email shape is restored.
| <<<<<<< HEAD | |
| recipient_type: 'user', | |
| ======= | |
| >>>>>>> 28d5bf90e90cfcf0d97fcf80d3b17f554f3ccd07 | |
| recipient_type: 'user', |
| authentication: { | ||
| ...(details as CustomHTTPSDetailsExtended).authentication, | ||
| details: authenticationDetails | ||
| ? omitProps(authenticationDetails, [ | ||
| 'basic_authentication_password', | ||
| ]) | ||
| : undefined, | ||
| details: undefined, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
In this MSW handler, Custom HTTPS destination responses set authentication.details to undefined. Per the API types, basic auth responses should still include basic_authentication_user and omit only the password. Preserving the username matters for edit flows that prefill the username field.
Description 📝
Highlight the Pull Request's context and intentions.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
Include a screenshot
<img src="" />or video<video src="" />of the change.🔒 Use the Mask Sensitive Data setting for security.
💡 For changes requiring multiple steps to validate, prefer a video for clarity.
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
Check all that apply
As an Author, before moving this PR from Draft to Open, I confirmed ✅