Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.1.97-7
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Frenkield 8595 pdf password #9141
- Add test to check for Contributor and Contributor+ Checklists #9772
- [No QA] Update to Webpack 5 and peer dependencies #10286
- Use
window.location.hreffor current URL #10494 - Refactor custom unit rate update #10557
- Fix search bug in IOU currency selector #10613
- Refactor of WorkspaceReimburseView to use new API #10692
- Fix cursor in image modal #10695
- Clear 2FA code from state when going back to login form #10702
- Lower case file extension for validation #10730
- Remove
unreadActionCount& Improve Global Indicators #10739 - Add offline UX for workspace #10749
- Fix for delete comment refactor #10764
- Revert "update react-native-svg version" #10775
- Use sequenceNumber and reportActionID for now #10779
- Show deleted messages with a strike-through when offline #10780
- Add resendLink message to successData #10783
- Follow up for checklist PR #10788
- Use node 16 in all GitHub actions #10791
- [No QA] Fix some
propTypewarnings #10797 - Cleanup from #10749 #10809
- [NO QA] Update iOS cert and provisioning profile #10844
- [No QA] Fetch full PR object to fix CPs #10856
- Attempt to workaround a workflow CP edge case #10867
Deploy Blockers:
- Reimburse expenses - The milage rate automatically changes to the initial value #10821
- Android - Attachment - PDF password form displayed lower than expected #10822
- Android - Workspace settings - Input fields are not grayed out when made changes offline #10825
- [$250] Android - App crashed when try to split bill for group. #10826
- mWeb - Global Unread Indicator - Global Unread Indicator doesn't decreases #10828
- Android - Global Unread Indicator - There is no Global Unread Indicator in Android App #10829
- Mileage rate is 0.00 for the newly created workspace instead of the rate set in the policy #10877
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Sep 5, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.97-2 🚀
mvtglobally commentedon Sep 5, 2022
@Julesssss still waiting for IOS build. Rest is almost completed
Julesssss commentedon Sep 6, 2022
Two blockers, but they don't seem too problematic. Will chase up the iOS build and work on the blockers after lunch
Julesssss commentedon Sep 6, 2022
The iOS release is blocked, but this is being resolved internally. Will share an update later.
AndrewGable commentedon Sep 6, 2022
Agreed ☝️
Julesssss commentedon Sep 6, 2022
I removed 10826 as a blocker because it is only affecting high-traffic Android devices, and even then has not been reproduced by us yet. Made the issue external and we'll continue to investigate.
Julesssss commentedon Sep 6, 2022
I just finished updating the Apple certs and provisioning profile, and we're awaiting the CP to see if the iOS build is successfull. This will hopefully unblock iOS Applause testing soon 🤞
Julesssss commentedon Sep 6, 2022
Unfortunately, I ran into a different error when running the CP. I wonder if it would make sense to begin a regression test on all platforms excluding iOS in the meantime, to save a bit of time tomorrow?
Julesssss commentedon Sep 6, 2022
Created a new issue for the CP issue here
mvtglobally commentedon Sep 6, 2022
@Julesssss All other platforms are done, we are just waiting for IOS to finish this run
Julesssss commentedon Sep 6, 2022
Ah that's great, I hadn't had a chance to review individual issues. In that case there's nothing else we can do until tomorrow morning, unfortunately. I'll be treating the iOS release blocker as a fire and will give you an update as soon as possible!
25 remaining items
Julesssss commentedon Sep 7, 2022
Just checked off the last blocker (10821), and added a screencast of the resolved issue.
mvtglobally commentedon Sep 7, 2022
Ok, so latest summary
#10739 - just finishing IOS. Rest is ok
PRs testing #10749 not waiting on the Web deploy of https://github.com/Expensify/Expensify/issues/224690. What do we do with #10809?
PR ##10780 logging an issue non-blocker. will check off once all platforms re-tested
mvtglobally commentedon Sep 7, 2022
1 more note. Some non-US testers did not receive new IOS build. I have just 2 slots pending in Test Rail for IOS 16 BETA (since those testers dont have build yet). We tested exact same steps on IOS 15/14. Let me know if you want to wait for build or we ok this time
https://expensify.testrail.io/index.php?/plans/view/8805
Julesssss commentedon Sep 7, 2022
I marked off #10809 as it cannot be tested yet... we're waiting on a Web-E PR.
Julesssss commentedon Sep 7, 2022
@mvtglobally excellent, thanks for the update. Let's wait for the remaining Apple invite. I'm happy to try resending manually if you have the email to hand.
mvtglobally commentedon Sep 7, 2022
Sent you details in Slack @Julesssss
mvtglobally commentedon Sep 7, 2022
#10877 when running #10692
Julesssss commentedon Sep 7, 2022
@chiragsalian would you mind taking a look at this today if you have a moment. Thanks 🙏
Julesssss commentedon Sep 7, 2022
Checking off #10749 because it's dependent on another PR that isn't merged.
Julesssss commentedon Sep 7, 2022
Checking off #10739 which tested flawlessly.
Julesssss commentedon Sep 7, 2022
No new crashes, marking off Firebase
Julesssss commentedon Sep 7, 2022
We discussed this internally and are happy to move forward given that we don't see any users on this specific iOS beta version.
Julesssss commentedon Sep 8, 2022
Closed the final remaining blocker 10877. Thanks so much, @yuwenmemon & @chiragsalian for your help.
Julesssss commentedon Sep 8, 2022