Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.4.56-8
Compare Changes: production...staging
This release contains changes from the following pull requests:
- HIGH: (Comment linking: Step 4) Main "glue" PR for Comment Linking #30269
- fix: Inconsistency of flashlight/torch behavior in Scan tab #34782
- Fix/34610: Remove NewDistanceRequestPage and EditRequestDistancePage #35302
- Room settings-Members added/deleted in a room in offline mode are not grayed out/crossed #35355
- feat: add policyReportFields to the policy object directly #36553
- [TS migration] Migrate 'withWritableReportOrNotFound.js' HOC to TypeScript #36628
- Use new isDeleted property for deleted actions #36747
- Fix: Render tooltip on Video Player Buttons #36945
- Track Expense flow #37282
- Disable Submit/Approve buttons when self approving is disabled and user is trying to self approve #37348
- [TS migration] Migrate VideoPlayerPreview, VideoPlayerControls and VideoPopoverMenu component files to TypeScript #37425
- fix: IOU - CMD+ENTER command takes you to the IOU confirmation page without selecting members #37460
- fix: prevent tab switch while swiping horizontally on map #37470
- [NO QA] migrate group 5 tests to ts #37482
- Fixes for selection list #37521
- Migrate NVPs to their new keys #37556
- Add support for inline image Markdown #37566
- Don't categorize when searching in report fields selection page #37583
- Fix - Don't show RBR on the LHN for transaction threads with violations if the report has already been reimbursed/settled #37767
- Handle emoji tooltip and fix regression #37814
- [No QA][TS Migration] Migrate 'OptionRow.stories.js', 'MenuItem.stories.js', 'CheckboxWithLabel.stories.js' , 'SubscriptAvatar.stories.js', 'PopoverMenu.stories.js' stories #37816
- [TS migration] Migrate RoomHeaderAvatars component files to TypeScript #37829
- Fix/37098: In app sound is played if user not viewing chat #37872
- fix: Workspace Avatar Error is impossible to dismiss #37874
- Ensure that disabled feature page cannot be accessed using deep-link #37902
- [No QA] Fix optimistic reports getting cleared by unnecessary OpenReport calls #37930
- fix: Hold Request - Keyboard is up but the field is not focused with error message showing #37955
- Upgrading react-content-loader #38016
- Fix: 3 dot menu in WS listing/WS chat stops working after viewing WS avatar #38098
- Desktop - Login - Unable to enter the 2FA code or exit the screen #38142
- Fix/37732: Error is not cleared after coming back to Connect manually empty form. #38148
- add JS snippet to mark reports on a policy as read #38194
- [Simplified Collect][Taxes] Tax editing and bulk actions #38208
- feat: policy distance rates edit #38237
- "Waiting for you to pay these expenses" is briefly displayed for approver #38244
- Fix video file preview not displaying after selecting video from device gallery #38302
- [Wave Collect] [Workflows] Display meaningful message when currency is not available for Direct Reimbursement #38318
- Fix: Save button loops between Rate/Unit and Track distance after refreshing Rate/Unit page #38323
- Fix: Inviter user name not show in invitee LHN #38391
- Fix: Scan- After uploading a corrupted file, user needs to dismiss error from 2 reports #38397
- Fix: Unread favicon not show #38433
- [NoQA] Add performance tests for BaseOptionsList #38435
- Read GH Secrets to set env vars #38442
- [FIX]: Bank account - Different error is displayed on Validate you bank account page #38457
- Fix: Status bar color is not correct on deeplink #38460
- fix: user can edit category and description if paid #38461
- Extract sidebarAvatarSize to variable #38463
- Create Create-a-group-workspace.md #38473
- Create Assign-billing-owner-and-payment-account.md #38484
- Create Set-up-your-individual-workspace.md #38485
- Fix showing not found page after deleting a workspace #38488
- fix: Error in JS console when right-clicking in the app #38494
- Update redirects.csv #38512
- Create Track-group-expenses.md #38534
- [Simplified Collect][Taxes] Add validation for custom tax name field #38555
- Add
policy?.autoReportingcheck to correct "is instant submit enabled" function #38563 - Fix: group conversation header display 5 participants #38568
- Fix: The last description in the Hold educational modal is truncated. #38569
- Fix workspace list page status bar style #38574
- [NO QA] [TS migration] Migrate remaining Test files to TypeScript #38536 #38589
- Create Add-expenses-to-a-report.md #38593
- Create Export-expenses.md #38597
- Change invite link inside share Workspace #38604
- [Simplified Collect] [Workflows] Connect bank account label is too small in Workspace > Workflows #38611
- feat: add bulk tag delete / enable / disable options #38647
- fix: An extra space is created at the top of the chat list when pin and unpin #38656
- Fix: 404 error on opening thread #38657
- resolve crash for high resolution images #38671
- [NoQA] Update ios provisioning profile #38677
- Fix crash on SetWorkspaceAutoReportingOffset #38684
- [No QA] Skip deploy action if PR is coming from a fork #38690
- 35756 close emoji when navigation back #38693
- Fix: remove border bug on report previews with 3+ receipts #38710
- Update Introducing-Expensify-Chat.md #38713
- [Simplified Collect][Taxes] Fix for crashing if you try to add a custom name without having any taxes #38732
- [NO QA] Reassure fix #38736
- [Held requests] break held message into separate system message + comment #38738
- [No QA] fix crash on sidebarutils #38741
- Hide new workspace button when we have chat-enabled ones #38750
- Fixed wrong subtitle for some reports #38754
- Optimistically create enabled tags #38763
- Update Workday.md to reflect accurate permissions #38784
- Fix skeleton display on transaction thread report in offline #38829
- Don't show 404 on ReportScreen if isLoading is true #38856
- Fix: Sender info disappears when delete one of consecutive messages #38945
- make gcp environment variable available to electron main process #38953
- Fix filter based on reportField.disabledOptions #38958
- [CP Stg] Make getContinuousReportActionChain consider any optimistic action #38968
- Remove optimistic CLOSED actions on success #39008
- Fix rogue action #39021
Deploy Blockers:
- [HOLD for payment 2024-04-05] [$500] Skeleton is displayed when navigating to a transaction thread created offline #38781
- [HOLD for payment 2024-04-15] [$500] Chat - App shows skeleton loading after clicking on message link #38813
- [HOLD for payment 2024-04-15] [$500] Distance - Unable to save second distance edit offline #38814
- [HOLD for payment 2024-04-05] [Simplified Collect][Distance rates] - Error shows up when disabling and renaming distance rate #38815
- Avatar - Profile avatar is broken when open in offline mode #38817
- Web - Creating new chat is lagging #38818
- [HOLD for payment 2024-05-02] [VIP-VSB] Thumbnail - Thumbnail of a markdown image flickers #38819
- Android - Track expenses - Deleting track expense showing skeleton in preview. #38820
- [HOLD for payment 2024-04-15] [$500] Room - Members added and deleted offline are not crossed out #38821
- Track Expense – Description grayed out when create Scan Track Expense #38822
- [HOLD for payment 2024-04-09] [$500] Workspace - The left side bar remains as chat when clicking on WS invitation link #38824
- [HOLD for payment 2024-04-05] Sign up - Hmmm its not here page is displayed for a moment on sign up #38826
- [HOLD for payment 2024-04-05] [Simplified Collect][Taxes] - Tax value is blank when returning online after editing it offline #38827
- [HOLD for payment 2024-04-05] [$500] Avatar of user who sent message disappears after deleting comment #38830
- [HOLD for payment 2024-06-11] [$500] Private notes - Hmm its not here page displayed when clicking on thumbnail #38835
- [HOLD for payment 2024-04-05] [Simplified Collect][Taxes] - Tax rate editor is not auto-focused #38836
- Carousel - Next button is displayed when opening last image in report #38837
- Hold for #38909 [$500] IOU - Map is blinking when navigate to Distance request #38838
- [HOLD for payment 2024-04-05] [$500] Workspace - #admin room with messages shows skeleton loading after workspace is deleted #38839
- [HOLD for payment 2024-04-05] Android - Chat - When offline, if a user requests money and then deletes the message, the page keeps loading #38844
- [$500] Web- IOU - The IOU is blank when creating a scan IOU with a corrupted image #38845
- [$500] Chat – New message button appears when create IOU #38848
- [$500] Distance - Distance editor still shows new waypoint after dismissing the editor without saving #38853
- [$500] Chat - Chat is not scrolled to the new message on a newly created WS chat after whisper message #38855
- [HOLD for payment 2024-04-05] [$500] [HOLD #38375][Simplified Collect][Taxes] "Custom tax name" does not change the name repeatedly #38859
- Paid expense - Owner for expense preview and paid system message is displayed incorrectly #38860
- [$500] Bank account - Error "You must accept the terms" shows up when the terms are accepted #38862
- [HOLD for payment 2024-05-02] Distance - Map reloads with "Route pending" when clicking Save button without any changes #38864
- Taxes - Error shows up when disabling tax rate #38866
- Track expense-Scan track expense shows no option to enter details manually #38868
- [HOLD for payment 2024-04-05] Expense - Expense preview shows skeleton loading after paying with Expensify #38869
- Public room - new messages button is displayed for anon user and it can not be dismissed #38870
- [HOLD for payment 2024-04-05] [$250] [Simplified Collect][Distance rates] - Back icon not functioning and close to status bar on rate edit screen #38871
- CRITICAL: [Track expense] Receipt leads to not here page when the scanning fails #38873
- [$500] IOU - IOU Detail Scrolls When Opened #38874
- Image MD - Download icon on image view from image mark down opens image in a new tab #38875
- [HOLD for payment 2024-04-05] [$250] [Simplified Collect][Distance rates] No pop-over after bulk-selecting rates and trying to disable/delete them #38876
- payment due [$500] Image MD - LHN preview shows "Attachment" instead of "Text [Attachment]" after reopening chat #38877
- [HOLD for payment 2024-04-09] [$500] Composer defocuses when editing parent message in thread #38878
- [Backwards Compatibility] Workspace chat shows skeleton loading when changing report from Invoice to Expense #38888
- [HOLD for payment 2024-04-05] Web - Expense report - Approve button not disabled if selected before enabling Self-approval #38889
- Desktop - IOU - The Distance IOU is unable to determine the user's coordinates #38895
- Workspace features - App redirects to not here page when the feature is disabled #38896
- [$250] [Simplified Collect][More features] Unable to toggle on a feature when second tab is open #38897
- [$250] [HOLD for payment 2024-04-05] Workspace - One of the dropdown options configured in OD is missing from ND #38898
- [Pay 4/30][$500] Workspaces - Unsynchronized transition of left and right page when deleting workspace #38922
- [HOLD for payment 2024-04-05] [Simplified Collect][Workflows] "Make or track payments" section is no longer grayed out after updating to USD #38926
- [$250] [HOLD for payment 2024-04-05] [Simplified Collect][Taxes] - App crashes when opening Foreign currency default row after deleting the selected tax #38931
- [HOLD for payment 2024-04-09] [$500] Expense - Page scrolls back down when dismissing add receipt RHP in transaction thread #38935
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
luacmartins commentedon Mar 22, 2024
Checking off #38815. Demoted to NAB.
amyevans commentedon Mar 22, 2024
Demoting #38822 as NAB
francoisl commentedon Mar 22, 2024
Demoting 38821 as NAB.
OSBotify commentedon Mar 22, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.56-0 🚀
jasperhuangg commentedon Mar 22, 2024
Checking off #38838 NAB
roryabraham commentedon Mar 23, 2024
Verified #38781 is fixed, checking it off
kavimuru commentedon Mar 25, 2024
Regression is 7% left in the TestRail.
#37282 failing with #38822
#37425 failing with #38831 Repro in PROD, checking it off
#38397 failing with #38845 and #38846
#35355 failing with #31764, bug is not fixed #35355 (comment)
kavimuru commentedon Mar 25, 2024
Regression is 1% left in the TestRail.
#37902 is failing with #38896
#38208 failing with #38931 and #38896
#38244 failing with #37866 not fixed and repro in all the platforms #38244 (comment)
#37282 failing with #38822
#38397 failing with #38845 and #38846
#35355 failing with #31764, bug is not fixed #35355 (comment)
luacmartins commentedon Mar 25, 2024
Checking off #38896. Expected behavior.
luacmartins commentedon Mar 25, 2024
Checking off #38897. Demoted to NAB.
bondydaa commentedon Mar 25, 2024
for blocker #38830
Internal convo is here: https://expensify.slack.com/archives/C07J32337/p1711379851443479
And public convo is here, seeing if the contributor is still available to get a PR during US hours or not https://expensify.slack.com/archives/C01GTK53T8Q/p1711380004801189
luacmartins commentedon Mar 25, 2024
Checking off #38931. Demoted to NAB.
roryabraham commentedon Mar 25, 2024
#38826 resolved, checking it off
francoisl commentedon Mar 25, 2024
Checking off 38889, demoted as regular fix.
amyevans commentedon Mar 25, 2024
Checked off 38878 as demoted
marcaaron commentedon Mar 25, 2024
Demoting #38845 as it is affecting an edge case flow IMO.
marcaaron commentedon Mar 25, 2024
Demoting #38853 as it seems minor and sounds like there is a draft PR here which might fix it.
yuwenmemon commentedon Mar 26, 2024
Checking off #38935 as it's minor, and should not hold up the deploy.
perunt commentedon Mar 26, 2024
Left a comment with a temporary solution for this #38935
roryabraham commentedon Mar 26, 2024
#38844 is fixed, checking it off
yuwenmemon commentedon Mar 27, 2024