Skip to content

chore(pages): remove the pages feature flag - #7777

Merged
saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/remove-pages-flag
Sep 24, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/remove-pages-flag

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Pages is GA, so the pages feature flag checks come out of desktop and web; pages are always on.
  • The web viewer's access check reduces to "signed in", and dropUnavailablePanes, which only existed to strip page panes when the flag was off, is deleted.

Why / Context

The PostHog flag has been at 100% with no conditions since 2026-09-07, so every gate on it is dead code.

How It Works

  • Desktop: removed useFeatureFlagEnabled(FEATURE_FLAGS.PAGES) from the sidebar, the pages routes, the workspace pages menu, the page pane registration, terminal/file/browser page-link handling and deep-link consumption. isPagesEnabled no longer gets passed through runUrlLinkAction / TerminalLinkActionDeps.
  • Web: getPagesAccess becomes a cached getSession. Signed in → full viewer; signed out → public view or PageUnavailable. That matches today's behaviour at 100%.
  • Shared: removed FEATURE_FLAGS.PAGES.

Manual QA Checklist

  • Desktop: sidebar Pages button opens /pages; /pages/<slug> renders
  • Desktop: workspace pages menu shows; page pane opens and restores after restart
  • Desktop: clicking a page URL in a terminal, a file and the in-app browser opens the page pane
  • Web: /page/<slug> signed in shows the full viewer; signed out shows the public view or a sign-in prompt

None of these have been run yet; typecheck and tests only so far.

Testing

  • bun run typecheck in apps/desktop (clean), tsc --noEmit in apps/web (clean)
  • bun test over the v2-workspace, OpenBrowserPageInAppButton and main/lib desktop suites: 1053 pass
  • biome check on changed files

Risks / Rollout

  • Don't delete the PostHog flag after merging. Desktop builds from before this change still evaluate it, and a deleted flag reads as off, which would hide Pages for them. Delete it once those builds have aged out. Web is safe as soon as it deploys.
  • Rollback: revert the PR. The flag is still at 100%, so nothing changes for users either way.

Summary by cubic

Removes the pages feature flag now that Pages is GA; the PostHog flag has been at 100% with no conditions since 2026-09-07, so every gate on it is dead code. Desktop and web now treat pages as always on, and the web viewer's access check reduces to signed in — signed-out users get the public view or PageUnavailable.

Rollout

  • Don't delete the PostHog flag after merging; pre-change desktop builds still evaluate it, and a deleted flag reads as off and would hide Pages for them. Delete it once those builds age out.

Written for commit b14a30a. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features
    • Pages are now available throughout the desktop app, including in the sidebar, workspace menus, and pane layouts. Page links open as pages without a feature-flag requirement.
    • Published pages now show a public view to visitors without a session when one is available; signed-in visitors continue to see the authenticated page.
  • Bug Fixes
    • Page metadata for visitors without a session now uses the sign-in title and description.

Pages is GA: the PostHog flag has been at 100% with no conditions since
2026-09-07, so every gate on it is dead code. Desktop and web now treat
pages as always on; the web viewer's access check reduces to "signed in".

dropUnavailablePanes only existed to strip page panes when the flag was
off, so it goes too.

Keep the flag live in PostHog until pre-change desktop builds age out —
they still evaluate it, and a deleted flag reads as off.
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e7ec52ac-8003-4ffe-9491-5ae65e0cdd47

📥 Commits

Reviewing files that changed from the base of the PR and between 033439d and b14a30a.

📒 Files selected for processing (21)
  • apps/desktop/src/renderer/components/OpenBrowserPageInAppButton/OpenBrowserPageInAppButton.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarHeader/DashboardSidebarHeader.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/pages/$slug/page.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/pages/page.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useConsumePageOpenLink/useConsumePageOpenLink.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/FilePane/FilePane.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/PagePane/PagePane.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/TerminalPane.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/usePaneRegistry.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/utils/runTerminalLinkAction/runTerminalLinkAction.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useV2WorkspacePaneLayout/useV2WorkspacePaneLayout.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useV2WorkspacePaneLayout/utils/dropUnavailablePanes/dropUnavailablePanes.test.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useV2WorkspacePaneLayout/utils/dropUnavailablePanes/dropUnavailablePanes.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useV2WorkspacePaneLayout/utils/dropUnavailablePanes/index.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/page.tsx
  • apps/web/src/app/page/[slug]/page.tsx
  • apps/web/src/app/page/[slug]/utils/getPagesAccess/getPagesAccess.ts
  • apps/web/src/app/page/[slug]/utils/getPagesAccess/index.ts
  • apps/web/src/app/page/[slug]/utils/getSession/getSession.ts
  • apps/web/src/app/page/[slug]/utils/getSession/index.ts
  • packages/shared/src/constants.ts
💤 Files with no reviewable changes (8)
  • apps/web/src/app/page/[slug]/utils/getPagesAccess/index.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useV2WorkspacePaneLayout/utils/dropUnavailablePanes/dropUnavailablePanes.test.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/pages/page.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/pages/$slug/page.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useV2WorkspacePaneLayout/utils/dropUnavailablePanes/dropUnavailablePanes.ts
  • apps/web/src/app/page/[slug]/utils/getPagesAccess/getPagesAccess.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useV2WorkspacePaneLayout/utils/dropUnavailablePanes/index.ts
  • packages/shared/src/constants.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The PAGES feature-flag gates were removed from desktop navigation, routes, workspace panes, and page-link handling. The web published-page route now uses the user session to select authenticated page lookup or public-page fallback.

Changes

Pages access

Layer / File(s) Summary
Desktop Pages entry points
packages/shared/src/constants.ts, apps/desktop/src/renderer/components/OpenBrowserPageInAppButton/OpenBrowserPageInAppButton.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarHeader/DashboardSidebarHeader.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/pages/*, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/page.tsx
The PAGES feature-flag constant and its checks were removed. Desktop Pages navigation, page routes, and the workspace Pages menu now render without those checks.
Workspace page panes and layouts
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/usePaneRegistry.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useV2WorkspacePaneLayout/*
The page pane is registered unconditionally. Stored layouts retain page panes. The unavailable-pane utility and its tests were removed.
Workspace page-link handling
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useConsumePageOpenLink/*, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/*Pane/*, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/utils/runTerminalLinkAction/*
Workspace link handlers now parse page URLs without checking the PAGES flag. The link-action dependency type no longer includes the flag.
Web published-page session access
apps/web/src/app/page/[slug]/page.tsx, apps/web/src/app/page/[slug]/utils/getPagesAccess/*, apps/web/src/app/page/[slug]/utils/getSession/*
The route now uses a cached session helper instead of getPagesAccess. Without a session, it returns the public view when available or PageUnavailable; authenticated page lookup and metadata generation use the session. The page header receives session.user.id.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: kitenite

Merge Risk: ⚪ Minimal · up to b14a3

The Pages flag removal appears mergeable after normal checks. Keep the remote flag available for older desktop builds until they have aged out.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 15.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 13 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing the Pages feature flag. It follows the repository's conventional commit format.
Description check ✅ Passed The description explains what changed, why the flag is being removed, implementation details for desktop, web, and shared code, testing performed, manual QA status, and rollout risks. It provides the …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@expo

expo Bot commented Sep 23, 2026

Copy link
Copy Markdown

No installed development build can load this pull request as an update: its native fingerprint is 397d86f0ea64 and no development build has it. Add the mobile-build label to build one.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit dcee575 into main Sep 24, 2026
22 checks passed
Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.

This branch was previously deployed

1 inactive deployment
preview — b14a30a0 Deployed Sep 23, 2026 by saddlepaddle via Deploy Marketing #10266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant