Skip to content

fix(desktop): allow reordering beside workspace pills - #7833

Merged
Kitenite merged 3 commits into
mainfrom
fix-section-pill-drag
Sep 24, 2026
Merged

Kitenite merged 3 commits into
mainfrom
fix-section-pill-drag

Conversation

@Kitenite

@Kitenite Kitenite commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Dragging the empty space beside a workspace's agent or port pills did not start reordering because the entire pill strip stopped mouse and touch events. Allow starts from the strip's empty space through to the sortable row, while continuing to block starts from pill buttons (including disabled buttons and their children) and floating details panels.

Validation:

  • Reproduced in the signed-in Electron dev app before the change: the same drag beside a two-agent pill did not activate or change order; dragging the title did activate.
  • After the change, the same gesture activates and reorders the workspace. Verified mouse/touch, pill clicks, keyboard activation, workspace navigation, repeated boundary crossings, pauses, autoscroll, and induced main-thread stalls. No console errors; original workspace order restored.
  • 183 sidebar tests pass, including an isolated fixture with 14 interaction cases. Confirmed the empty-space mouse and touch regression cases fail against the original implementation.
  • Repository lint and all 42 typecheck tasks pass locally. The full local test run reports 34 failures in Git/worktree and shell-environment tests; the chip fixture and sidebar suite pass. The full CI Test job passes on Linux, along with lint, typecheck, version sync, Sherif, and prose lint.

Before/after screenshots were captured locally. They contain the signed-in user's workspace names and are not published here.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e1e3f913-de7b-4395-abd5-400a8cd372f4

📥 Commits

Reviewing files that changed from the base of the PR and between 807a93b and 70fdd83.

📒 Files selected for processing (3)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/DashboardSidebarWorkspaceChips.test.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/DashboardSidebarWorkspaceChips.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/fixtures/checks.test.fixture.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workspace chips component now conditionally stops mouse and touch drag-start events. Tests cover event propagation and workspace selection for empty space and chip content.

Changes

Workspace chip events

Layer / File(s) Summary
Conditional drag-start propagation
.../DashboardSidebarWorkspaceChips.tsx, .../DashboardSidebarWorkspaceChips.test.tsx, .../fixtures/checks.test.fixture.tsx
The component stops drag-start propagation when the event target is outside the current element or inside a button. Other drag-start events bubble. Fixture tests cover mouse and touch propagation, portaled agent details, and workspace selection. The test runner launches the fixture in a child Bun process with NODE_ENV=test.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 70fdd

The change appears mergeable after the normal checks, including clean CI results for the reported test-environment failures.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses conventional commit format and clearly describes the primary fix: enabling workspace reordering beside workspace pills.
Description check ✅ Passed The description explains the problem, the implemented behavior, and extensive validation results. It does not include the repository checklist section, but the required change and testing details are …
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kitenite
Kitenite merged commit ca492f5 into main Sep 24, 2026
13 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch

Thank you for your contribution! 🎉

AviPeltz added a commit that referenced this pull request Sep 26, 2026
Concludes the workspace-agents-row experiment by removing the chip that
showed running agents (agent icon + count) under sidebar workspace rows,
along with its "Workspace agents" toggle in Settings > Experimental.

- Delete DashboardSidebarAgentsChip, its avatar and hover-row components,
  the useDashboardSidebarWorkspaceRunningAgents hook, and the
  workspace-agents-row store. The chips strip now renders only ports.
- Move the "workspace-agents-row" localStorage key to DEAD_KEYS so the
  boot sweep clears it from existing profiles.
- Drop `statuses` from the sidebar status entry; the chip was its only
  reader. It stays a local that derives `status` and `isUnread`, so rows
  no longer re-render for per-terminal changes nothing displays.
- Keep the provider's subagent refetchInterval: it shares a query key
  with useTerminalAgentBindings, and the pane header's subagents menu
  relies on it to drop expired subagents.
- Move the chips regression fixture (#7833) onto the ports chip, keeping
  its enabled + portaled and disabled chip cases.
- Regenerate the Lingui catalogs (5 messages removed in every locale).
Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant