Skip to content

refactor(desktop): remove the sidebar workspace agents chip - #7870

Merged
AviPeltz merged 1 commit into
mainfrom
remove-agents-indicator
Sep 26, 2026
Merged

AviPeltz merged 1 commit into
mainfrom
remove-agents-indicator

Conversation

@AviPeltz

@AviPeltz AviPeltz commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Removes the agents chip (agent icon + running count) shown under sidebar workspace rows, along with its Workspace agents toggle in Settings → Experimental. The ports chip on the same line is unchanged.

Why / Context

The chip was the workspace-agents-row experiment, on by default. This concludes the experiment by removing it, following the removal checklist in the store's own doc comment: the store, the settings toggle and its search entry, and the chip branch in DashboardSidebarWorkspaceChips.

How It Works

  • Deletes DashboardSidebarAgentsChip (with DashboardSidebarAgentAvatar and DashboardSidebarAgentHoverRow), useDashboardSidebarWorkspaceRunningAgents, and stores/workspace-agents-row.ts. DashboardSidebarWorkspaceChips now renders only the ports chip.
  • Moves workspace-agents-row from the persisted-key registry to DEAD_KEYS, so the boot sweep clears the stored toggle from existing profiles (persisted-state policy in apps/desktop/AGENTS.md).
  • Drops statuses from SidebarWorkspaceStatusEntry; the chip was its only reader. The map stays a local that derives status and isUnread, which are still compared, so rows only stop re-rendering for per-terminal changes nothing displays.
  • Moves the chips regression fixture from fix(desktop): allow reordering beside workspace pills #7833 onto the ports chip, keeping its enabled + portaled and disabled chip cases.
  • Removes the 5 now-unused messages from every locale catalog (bun run check:i18n, deletions only).

Manual QA Checklist

  • Workspace with 2+ running agents (or one agent running subagents): no chip under the row
  • Workspace with a detected port: ports chip still renders, its hover card opens, and dragging from the empty space beside it still reorders
  • Settings → Experimental has no "Workspace agents" toggle, and settings search doesn't surface it
  • Sidebar status indicators and unread marks behave as before
  • Terminal pane header's "N subagents" menu still appears and clears once subagents finish

Testing

  • bun x tsc --noEmit in apps/desktop: pass
  • bun run lint: pass
  • bun test on the chips fixture, lib/persisted-keys, and settings-search: 27/27. The fixture alone is 14/14; with stopChipDragStart turned into a no-op, all 10 drag cases fail, so it still guards fix(desktop): allow reordering beside workspace pills #7833.
  • bun test over the DashboardSidebar and settings directories: 263 pass. 2 files fail only in that combined run (useSidebarDnd, DashboardSidebarWorkspaceHoverCardContent) because V2ProjectSettings.test.tsx's partial @tanstack/react-router mock leaks across files; both pass alone.
  • bun test in packages/i18n: 157/157. bun run check:i18n: 0 missing in all 17 locales.
  • Not yet exercised in the running app, so the manual QA above is unchecked.

Design Decisions

  • Kept the status provider's subagent refetchInterval: it reads as chip-only, but it shares the terminal-agent-bindings query key with useTerminalAgentBindings, which has no interval of its own. It is what drops expired subagents from the pane header's "N subagents" menu.

Follow-ups

  • DashboardSidebarChipStrip already had no importers before this PR, and its doc still mentions agents. Left alone to keep this focused.

Summary by cubic

Removes the sidebar workspace agents chip and its "Workspace agents" experiment toggle, so workspace rows now show only the ports chip.

  • Deletes the chip components, running-agents hook, and workspace-agents-row store.
  • Registers workspace-agents-row as a dead key so the boot sweep clears the stored toggle from existing profiles.
  • Drops statuses from the workspace status entry; the chip was its only reader, and rows no longer re-render for per-terminal changes.
  • Keeps the subagent refetchInterval, which shares a query key with useTerminalAgentBindings that the pane header's "N subagents" menu depends on.
  • Moves the chips drag regression fixture onto the ports chip and removes 5 now-unused messages from every locale catalog.

Written for commit 9421ec5. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Changes
    • Running-agent and subagent indicators, counts, and detail views have been removed from workspace sidebar rows.
    • The “Workspace agents” experimental setting is no longer available.
    • Workspace rows continue to show port information when ports are present.

Concludes the workspace-agents-row experiment by removing the chip that
showed running agents (agent icon + count) under sidebar workspace rows,
along with its "Workspace agents" toggle in Settings > Experimental.

- Delete DashboardSidebarAgentsChip, its avatar and hover-row components,
  the useDashboardSidebarWorkspaceRunningAgents hook, and the
  workspace-agents-row store. The chips strip now renders only ports.
- Move the "workspace-agents-row" localStorage key to DEAD_KEYS so the
  boot sweep clears it from existing profiles.
- Drop `statuses` from the sidebar status entry; the chip was its only
  reader. It stays a local that derives `status` and `isUnread`, so rows
  no longer re-render for per-terminal changes nothing displays.
- Keep the provider's subagent refetchInterval: it shares a query key
  with useTerminalAgentBindings, and the pane header's subagents menu
  relies on it to drop expired subagents.
- Move the chips regression fixture (#7833) onto the ports chip, keeping
  its enabled + portaled and disabled chip cases.
- Regenerate the Lingui catalogs (5 messages removed in every locale).
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 52ef5aa2-974f-444b-8e57-38d9ffd98b2f

📥 Commits

Reviewing files that changed from the base of the PR and between d3cebba and 9421ec5.

📒 Files selected for processing (33)
  • apps/desktop/src/renderer/lib/persisted-keys/persisted-key-registry.test-data.ts
  • apps/desktop/src/renderer/lib/persisted-keys/persisted-keys.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/DashboardSidebarWorkspaceChips.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/DashboardSidebarAgentsChip.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/components/DashboardSidebarAgentAvatar/DashboardSidebarAgentAvatar.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/components/DashboardSidebarAgentAvatar/index.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/components/DashboardSidebarAgentHoverRow/DashboardSidebarAgentHoverRow.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/components/DashboardSidebarAgentHoverRow/index.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/index.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/fixtures/checks.test.fixture.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/hooks/useDashboardSidebarWorkspaceRunningAgents/index.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/hooks/useDashboardSidebarWorkspaceRunningAgents/useDashboardSidebarWorkspaceRunningAgents.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/providers/DashboardSidebarWorkspaceStatusProvider/DashboardSidebarWorkspaceStatusProvider.tsx
  • apps/desktop/src/renderer/routes/_authenticated/settings/experimental/components/ExperimentalSettings/ExperimentalSettings.tsx
  • apps/desktop/src/renderer/routes/_authenticated/settings/utils/settings-search/settings-search.ts
  • apps/desktop/src/renderer/stores/workspace-agents-row.ts
  • packages/i18n/locales/cs/messages.po
  • packages/i18n/locales/de/messages.po
  • packages/i18n/locales/en/messages.po
  • packages/i18n/locales/es/messages.po
  • packages/i18n/locales/fr/messages.po
  • packages/i18n/locales/id/messages.po
  • packages/i18n/locales/it/messages.po
  • packages/i18n/locales/ja/messages.po
  • packages/i18n/locales/ko/messages.po
  • packages/i18n/locales/nl/messages.po
  • packages/i18n/locales/pl/messages.po
  • packages/i18n/locales/pt-BR/messages.po
  • packages/i18n/locales/ru/messages.po
  • packages/i18n/locales/tr/messages.po
  • packages/i18n/locales/vi/messages.po
  • packages/i18n/locales/zh-CN/messages.po
  • packages/i18n/locales/zh-TW/messages.po
💤 Files with no reviewable changes (29)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/index.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/components/DashboardSidebarAgentAvatar/index.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/hooks/useDashboardSidebarWorkspaceRunningAgents/index.ts
  • apps/desktop/src/renderer/lib/persisted-keys/persisted-key-registry.test-data.ts
  • apps/desktop/src/renderer/routes/_authenticated/settings/utils/settings-search/settings-search.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/components/DashboardSidebarAgentHoverRow/index.ts
  • apps/desktop/src/renderer/stores/workspace-agents-row.ts
  • packages/i18n/locales/vi/messages.po
  • packages/i18n/locales/nl/messages.po
  • apps/desktop/src/renderer/routes/_authenticated/settings/experimental/components/ExperimentalSettings/ExperimentalSettings.tsx
  • packages/i18n/locales/tr/messages.po
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/components/DashboardSidebarAgentHoverRow/DashboardSidebarAgentHoverRow.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/DashboardSidebarAgentsChip.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/components/DashboardSidebarAgentsChip/components/DashboardSidebarAgentAvatar/DashboardSidebarAgentAvatar.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/components/DashboardSidebarWorkspaceChips/hooks/useDashboardSidebarWorkspaceRunningAgents/useDashboardSidebarWorkspaceRunningAgents.ts
  • packages/i18n/locales/en/messages.po
  • packages/i18n/locales/ru/messages.po
  • packages/i18n/locales/ja/messages.po
  • packages/i18n/locales/de/messages.po
  • packages/i18n/locales/cs/messages.po
  • packages/i18n/locales/pt-BR/messages.po
  • packages/i18n/locales/fr/messages.po
  • packages/i18n/locales/it/messages.po
  • packages/i18n/locales/zh-TW/messages.po
  • packages/i18n/locales/pl/messages.po
  • packages/i18n/locales/es/messages.po
  • packages/i18n/locales/id/messages.po
  • packages/i18n/locales/zh-CN/messages.po
  • packages/i18n/locales/ko/messages.po

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The change removes workspace-agent settings, persisted state, running-agent sidebar components, and related translations. The dashboard sidebar continues to render its ports chip, and workspace status entries no longer store per-terminal status maps.

Changes

Workspace agents removal

Layer / File(s) Summary
Remove workspace-agents setting and persisted state
apps/desktop/src/renderer/stores/workspace-agents-row.ts, apps/desktop/src/renderer/lib/persisted-keys/*, apps/desktop/src/renderer/routes/_authenticated/settings/..., packages/i18n/locales/*/messages.po
Removes the experimental setting, search entry, and persisted store. Adds workspace-agents-row to DEAD_KEYS and removes related locale messages.
Remove running-agent sidebar display
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/...
Removes the running-agent hook and agent chip components. The workspace chips component renders the ports chip when ports are present. Its fixture updates port-chip mocks and related checks. The workspace status provider stops storing per-terminal status maps but continues to compute aggregate status and unread state.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: kitenite

Merge Risk: ⚪ Minimal · up to 9421e

No actionable merge-blocking risk is established; proceed with normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 9421e

The current version removes the agents display without expanding access to agent or port actions. A downgrade could, however, restore the old display for someone who had turned it off, because the update deletes that preference.

Retained concerns

  • Low · security · inferred: Deleting an opted-out display preference can re-enable the old agents chip if the application is downgraded: the prior store defaults to enabled when its persisted value is absent.
Security review details

Security Blast Radius

  • inferred — The identified rollback exposure is confined to the prior version’s local sidebar display and persisted profile preference; the reviewed changes do not establish a new service, tenant, credential, or privileged-action path.

Security Findings and Attack Paths

  • inferred — If a user previously disabled the chip, runs this update, and then restores the prior build, the deleted preference no longer suppresses the enabled-by-default display. No remote attacker path or exposure in the current build was established.

Trust Boundaries and Controls

  • observed — The cleanup uses exact-key matching rather than a prefix for this preference, and the retained ports chip remains on the existing workspace-scoped rendering path.

Resilience and Maintainability Implications

  • observed — The sweep continues boot after a storage error, and a repeated successful sweep finds no already-removed key. It does not coordinate removal with an older writer.

Hardening Proposals

  • proposed — If downgrade support must preserve an explicit opt-out, retain or migrate the disabled value through the rollback window rather than deleting it on first boot.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly identifies the main change: removal of the desktop sidebar workspace agents chip.
Description check ✅ Passed The description explains what changed, why it changed, implementation details, testing results, manual QA status, and design decisions. It does not reproduce the template headings or checklist exactly…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@expo

expo Bot commented Sep 25, 2026

Copy link
Copy Markdown

No installed development build can load this pull request as an update: its native fingerprint is 63273df0c28c and no development build has it. Add the mobile-build label to build one.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@AviPeltz
AviPeltz merged commit 804cc3a into main Sep 26, 2026
22 checks passed
AviPeltz added a commit that referenced this pull request Sep 26, 2026
…7870)" (#7871)

This reverts commit 804cc3a.

Restores the agents chip under sidebar workspace rows, its hover card
(jump to an agent's terminal, open a subagent's transcript), and the
"Workspace agents" toggle in Settings > Experimental. Open PRs #7496 and
#7143 build on the chip.
Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.

This branch was previously deployed

1 inactive deployment
preview — 9421ec5a Deployed Sep 25, 2026 by AviPeltz via Deploy Marketing #10425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant