Skip to content

The internal golden carries psql, ntn, lim and the Stripe CLI - #7911

Merged
saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/internal-box-clis
Sep 28, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/internal-box-clis

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Adds the day-to-day CLIs a Superset engineer's box still lacked, found by tallying commands across ~1,400 agent sessions over 60 days.

Changes

  • internal-setup.sh installs postgresql-client, ntn (Notion) and lim (Limrun) from npm, and stripe from Stripe's signed apt repo.
  • release.ts checks each is on the golden, so a broken install fails the release instead of shipping.

Internal environment only: the shared image and the Default environment every other org uses are unchanged.

Credentials

Already on the internal environment: NOTION_API_TOKEN, LIM_API_KEY. STRIPE_API_KEY (a read-only restricted key) is pending a passkey confirmation.

Verification

  • The four install lines ran in node:24-bookworm-slim on linux/amd64 (the image's base): psql 15.19, ntn 0.23.10, lim 0.34.0, stripe 1.52.0.
  • bash -n and biome clean. Not yet verified on a real golden; the release probe does that on merge.

Summary by cubic

Adds psql, ntn, lim, and the Stripe CLI to the internal golden so a Superset engineer's box has the day-to-day tools it lacked, found by tallying commands across ~1,400 agent sessions over 60 days. internal-setup.sh installs them, and the release probe now fails if any is missing.

  • Only the internal environment changes; the shared image and the Default environment are untouched.
  • Each tool reads its credential from existing env vars (NOTION_API_TOKEN, LIM_API_KEY, STRIPE_API_KEY); STRIPE_API_KEY is a pending read-only restricted key.
  • Verified on node:24-bookworm-slim linux/amd64; golden verification happens via the release probe on merge.

Written for commit 8410311. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features
    • Sandbox environments now include the PostgreSQL command-line client, along with the ntn, lim, and Stripe command-line tools. These tools are available for use in supported sandbox workflows.
    • Environment validation now checks that the PostgreSQL, ntn, lim, and Stripe command-line tools are installed and report valid version numbers.

These are the tools a Superset engineer reaches for daily that a box
lacked: psql for the workspace's Neon branch (neonctl's only way to run
SQL is to launch it), ntn for Notion, lim for Limrun's remote simulators,
and stripe. Each reads its credential from the internal environment's
variables: NOTION_API_TOKEN, LIM_API_KEY, STRIPE_API_KEY.

Only the internal environment's setup hook changes; the shared image and
the Default environment are untouched. The release probe now fails if any
of the four is missing from the golden.
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 13ecbfea-a6a1-4c2c-af25-21f34cceaf05

📥 Commits

Reviewing files that changed from the base of the PR and between a658fd8 and 8410311.

📒 Files selected for processing (2)
  • packages/sandbox/src/environments/internal-setup.sh
  • packages/sandbox/src/environments/release.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The sandbox setup hook now installs PostgreSQL, ntn, lim, and Stripe CLI tools. The golden-environment probe checks the versions of these tools.

Changes

Sandbox CLI Provisioning

Layer / File(s) Summary
Install CLI tools
packages/sandbox/src/environments/internal-setup.sh
The setup hook adds postgresql-client, installs ntn and lim through npm, and configures the Stripe apt repository and CLI installation. The npm and Stripe installation commands exit with status 1 on failure.
Validate CLI versions
packages/sandbox/src/environments/release.ts
The golden-environment probe checks psql, ntn, lim, and stripe version output, requiring two numeric components for psql and three for the other CLIs.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 84103

The internal golden gains the four CLI tools, with setup failures and version-check failures stopping release. Available evidence shows no concrete merge-blocking issue; the change is ready for normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 84103

The change affects 1 system.

Changed systems: packages/sandbox

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/sandbox (library) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in packages/sandbox/src/environments/internal-setup.sh: The apt package list now includes postgresql-client.
  • observed — Modified behavior in packages/sandbox/src/environments/internal-setup.sh: Adds installation of ntn and lim via npm, exiting with status 1 if that install fails. Adds Stripe’s signing key and apt source, then updates apt and installs stripe; failure in the update/install chain logs an error and exits with status 1.
  • observed — Modified behavior in packages/sandbox/src/environments/release.ts: Adds golden-environment checks for psql, ntn, lim, and stripe, matching version output with two, three, three, and three numeric components respectively.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding psql, ntn, lim, and Stripe CLI to the internal golden environment.
Description check ✅ Passed The description explains what changed, why it changed, scope, credentials, and verification results. It does not include the template's checklist or use the exact “What & why” and “How I tested it” he…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit c9f23e8 into main Sep 28, 2026
24 checks passed
Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.

This branch was previously deployed

1 inactive deployment
preview — 84103117 Deployed Sep 28, 2026 by saddlepaddle via Deploy Admin #10494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant