Skip to content

docs(adr): 0119 signal GitHub Actions events to a running cycle - #9029

Open
waynesun09 wants to merge 1 commit into
mainfrom
steer-adr-0118
Open

waynesun09 wants to merge 1 commit into
mainfrom
steer-adr-0118

Conversation

@waynesun09

@waynesun09 waynesun09 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Reading order: start with #9030 (ADR 0117), then #9028 (0118) → #9029 (0119) → #9031 (0120) → #9032 (0121). PR numbers do not follow ADR numbers, because the ADRs were renumbered into dependency order; this PR is ADR 0119.

Summary

ADR 0119 of five that rebuild the steering design (#6957) on the entity ADRs now on main (0133, 0141, 0144, 0147–0149, 0151). Docs only.

Decision: On GitHub Actions, the invocation layer may list its shim workflow's run records as an in-memory change signal for the running cycle. It never consumes pending work.

Steering hands a work-item update to the agent that is still running, so it can adjust before finishing on stale state. After ADR 0144 the next sandbox cycle is the correctness backstop; steering is a fast path inside one cycle.

The series

ADR Title PR
0117 Steer a running cycle with admitted entity updates #9030
0118 Steer runtime interface #9028
0119 Signal GitHub Actions events to a running cycle this PR
0120 Record absorbed steers as agent-run receipts #9031
0121 Steering on by default #9032
  • Merge order: 0117 → 0118 → 0119 → 0120 → 0121. Numbers follow dependency: each ADR cites only lower-numbered ones. Each PR passes the docs checks on its own; links to siblings that are not on main yet are plain text ("ADR 0117 (proposed)") and can become links once they merge.
  • Accepted ADRs touched: Status note on ADR 0144: partially superseded by 0119 for this one read. Listing the shim's runs includes the queued pending run, which 0144 says the bound process never polls.

Implementation dependencies

No code here. Implementation lands with or after:

  • ADR 0151 human_min_role admission;
  • the ADR 0141 filter pipeline and host-side extension path;
  • the ADR 0144 bound-run lifecycle;
  • entity-context-snapshot v2 for the receipt fields (ADR 0120).

The runtime interface (0118) and the run-record signal (0119) can be built first; they have no caller until the rest exists.

Lineage

These replace drafts in the earlier steering stack, which predate the entity ADRs.

Never cancelling the in-flight run (#7007) is already ADR 0106's decision, so it needs no new ADR.

Evidence

Current-behaviour claims in ADR 0119, with the code that implements them:

Testing

  • pre-commit run --from-ref origin/main --to-ref HEAD: all hooks pass (ADR status, number and front-matter linters, markdown links, secrets).
  • make lint-md-links: 0 errors.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Document GitHub Actions run records as steering signals

📝 Documentation 🕐 20-40 Minutes

Grey Divider

AI Description

• Define how shim workflow run records can signal changes to a running GitHub Actions cycle.
• Keep run-record reads separate from pending-work ownership and authorization.
• Clarify ADR 0144’s bound-process rule for this GitHub Actions read.
Diagram

graph TD
  S["Shim workflow"] --> R["Run records"] --> I["Invocation layer"] --> F{"Matching record?"}
  F -->|Yes| W["In-memory wake"] --> C["Steer or check"]
  S --> Q["Queued next cycle"]
Loading
High-Level Assessment

The proposed run-record signal fits GitHub Actions’ lack of an inbound path to running jobs while preserving queued execution as the correctness backstop. The ADR considers event polling, a relay, and timer-only checks; each adds infrastructure or fails to cover event-only harnesses.

Files changed (2) +143 / -0

Documentation (2) +143 / -0
0118-signal-github-actions-events-to-a-running-cycle.mdDefine GitHub Actions run-record steering signals +139/-0

Define GitHub Actions run-record steering signals

• Adds an accepted ADR specifying how the invocation layer identifies relevant shim workflow runs and signals an active cycle. It defines cadence, permission fallback, forge scope, and the boundary between a scheduling hint and verified pending work.

docs/ADRs/0118-signal-github-actions-events-to-a-running-cycle.md

0144-reuse-poll-and-entity-bound-run-processes.mdRecord ADR 0118’s exception to the bound-process rule +4/-0

Record ADR 0118’s exception to the bound-process rule

• Adds a status note identifying the GitHub Actions run-record signal as a partial supersession of ADR 0144.

docs/ADRs/0144-reuse-poll-and-entity-bound-run-processes.md

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:59 PM UTC · Completed 7:11 PM UTC

Commit: 99aa1fc · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.14

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://05b2b4ff-site.fullsend-ai.workers.dev

Commit: 6da8065d27620723bf3cf8f4c1fa6c28788d376d

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Nov 2, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR additions with zero protected or security-sensitive paths, elevated to moderate risk due to recent commit churn and historical co-commit coupling on modified documentation files.

Previous run

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR additions with zero protected or security-sensitive paths, elevated to moderate risk due to recent commit churn and historical co-commit coupling on modified documentation files.

Previous run (2)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR additions with zero protected or security-sensitive paths, elevated to moderate risk due to recent commit churn and high historical co-commit coupling on modified documentation files.

Previous run (3)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR additions with zero protected or security-sensitive paths, elevated to moderate risk due to recent commit churn and high historical co-commit coupling on ADR 0144.

Previous run (4)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR additions with zero protected or security-sensitive paths, elevated to moderate risk due to recent commit churn and high historical co-commit coupling on ADR 0144.

Previous run (5)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR additions with zero protected or security-sensitive paths, elevated to moderate risk due to recent commit churn and high historical co-commit coupling on ADR 0144.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review

Findings

Low

  • [doc-style] docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:121 — The "Credential" bullet line is about 90 columns, past the ~80-column wrapping guidance in docs/contributing/documentation.md.
    Remediation: Rewrap the bullet to about 80 columns.
  • [doc-style] docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:130 — The "No cursor" bullet line is about 92 columns, past the same guidance.
    Remediation: Rewrap the bullet to about 80 columns.
Previous run

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMTktc2lnbmFsLWdpdGh1Yi1hY3Rpb25zLWV2ZW50cy10by1hLXJ1bm5pbmctY3ljbGUubWQiLCJpZCI6ImZfNDVjMjM0MTU3NGNjZTA5YiIsImxpbmUiOjczLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJkb2NzL0FEUnMvMDExOC1zaWduYWwtZ2l0aHViLWFjdGlvbnMtZXZlbnRzLXRvLWEtcnVubmluZy1jeWNsZS5tZCIsImlkIjoiZl8xMjE3Yjc2YTQxYjFiMzQxIiwibGluZSI6OTgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfYjM0NmNkMmZlNzZkNTc3MyIsImxpbmUiOjQzNSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL0FEUnMvMDExOC1zaWduYWwtZ2l0aHViLWFjdGlvbnMtZXZlbnRzLXRvLWEtcnVubmluZy1jeWNsZS5tZCIsImlkIjoiZl9mZmQyNGJkMzMzYjY4NTQyIiwibGluZSI6MTMwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImRvY3MvQURScy8wMTE4LXNpZ25hbC1naXRodWItYWN0aW9ucy1ldmVudHMtdG8tYS1ydW5uaW5nLWN5Y2xlLm1kIiwiaWQiOiJmX2ZkN2U4OTBiODA4ZGY2MjAiLCJsaW5lIjo5NSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDExOS1zaWduYWwtZ2l0aHViLWFjdGlvbnMtZXZlbnRzLXRvLWEtcnVubmluZy1jeWNsZS5tZCIsImlkIjoiZl84NGYzMGMxMGU3YzcwOTU2IiwibGluZSI6MTA0LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMTktc2lnbmFsLWdpdGh1Yi1hY3Rpb25zLWV2ZW50cy10by1hLXJ1bm5pbmctY3ljbGUubWQiLCJpZCI6ImZfZmYwMGZkMjMwMzBjMWMwNyIsImxpbmUiOjEwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTE5LXNpZ25hbC1naXRodWItYWN0aW9ucy1ldmVudHMtdG8tYS1ydW5uaW5nLWN5Y2xlLm1kIiwiaWQiOiJmXzI0OTUxZTUxNjZiMWRjN2MiLCJsaW5lIjo1NywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTE5LXNpZ25hbC1naXRodWItYWN0aW9ucy1ldmVudHMtdG8tYS1ydW5uaW5nLWN5Y2xlLm1kIiwiaWQiOiJmX2Q1NTQzZmIxYTg3NjVjZjMiLCJsaW5lIjo5OSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl84NGYzMGMxMGU3YzcwOTU2Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfZmYwMGZkMjMwMzBjMWMwNyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzI0OTUxZTUxNjZiMWRjN2MiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9kNTU0M2ZiMWE4NzY1Y2YzIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMTIxN2I3NmE0MWIxYjM0MSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IzNDZjZDJmZTc2ZDU3NzMiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9mZmQyNGJkMzMzYjY4NTQyIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfZmQ3ZTg5MGI4MDhkZjYyMCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= -->

Review

Findings

Low

  • [doc-style] docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:73 — Line 73 is 93 columns long, exceeding the repository standard of wrapping Markdown prose at about 80 columns (docs/contributing/documentation.md, "Line wrapping").
    Remediation: Rewrap lines 72-74 so continuation lines stay near 80 columns (break after "ADR 0144.").

Earlier findings

  • docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md (security), auth-bypass — resolved: the current text states the run-record signal carries no authority for admission, CEL evaluation, or sandbox execution (lines 84-86) and defers to fresh admission (lines 101-103).
  • docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:103, doc-style — resolved: the current wrap at lines 102-103 follows the repository wrapping guidance.
  • docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:57, doc-style — resolved: line 57 is a table row, which docs/contributing/documentation.md exempts from wrapping.
  • docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:99, doc-style — resolved: the line is a valid relative ADR link within the column guide.
Previous run (2)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDExOS1zaWduYWwtZ2l0aHViLWFjdGlvbnMtZXZlbnRzLXRvLWEtcnVubmluZy1jeWNsZS5tZCIsImlkIjoiZl84NGYzMGMxMGU3YzcwOTU2IiwibGluZSI6MTA0LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMTktc2lnbmFsLWdpdGh1Yi1hY3Rpb25zLWV2ZW50cy10by1hLXJ1bm5pbmctY3ljbGUubWQiLCJpZCI6ImZfZmYwMGZkMjMwMzBjMWMwNyIsImxpbmUiOjEwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTE5LXNpZ25hbC1naXRodWItYWN0aW9ucy1ldmVudHMtdG8tYS1ydW5uaW5nLWN5Y2xlLm1kIiwiaWQiOiJmXzI0OTUxZTUxNjZiMWRjN2MiLCJsaW5lIjo1NywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTE5LXNpZ25hbC1naXRodWItYWN0aW9ucy1ldmVudHMtdG8tYS1ydW5uaW5nLWN5Y2xlLm1kIiwiaWQiOiJmX2Q1NTQzZmIxYTg3NjVjZjMiLCJsaW5lIjo5OSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMTgtc2lnbmFsLWdpdGh1Yi1hY3Rpb25zLWV2ZW50cy10by1hLXJ1bm5pbmctY3ljbGUubWQiLCJpZCI6ImZfMTIxN2I3NmE0MWIxYjM0MSIsImxpbmUiOjk4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmX2IzNDZjZDJmZTc2ZDU3NzMiLCJsaW5lIjo0MzUsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktY29udHJhY3QiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMTgtc2lnbmFsLWdpdGh1Yi1hY3Rpb25zLWV2ZW50cy10by1hLXJ1bm5pbmctY3ljbGUubWQiLCJpZCI6ImZfZmZkMjRiZDMzM2I2ODU0MiIsImxpbmUiOjEzMCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJkb2NzL0FEUnMvMDExOC1zaWduYWwtZ2l0aHViLWFjdGlvbnMtZXZlbnRzLXRvLWEtcnVubmluZy1jeWNsZS5tZCIsImlkIjoiZl9mZDdlODkwYjgwOGRmNjIwIiwibGluZSI6OTUsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl9mZjAwZmQyMzAzMGMxYzA3Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzEyMTdiNzZhNDFiMWIzNDEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9iMzQ2Y2QyZmU3NmQ1NzczIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfZmZkMjRiZDMzM2I2ODU0MiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2ZkN2U4OTBiODA4ZGY2MjAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Review

Findings

Low

  • [auth-bypass] docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:104 — The candidate rules do not admit the triggering actor: the shim creates a run record for every issue_comment, so a commenter who was never admitted still produces a matching record, and the ADR says a false match makes a check due that can start another sandbox cycle while an entity-source harness CEL stays true. Impact is bounded (listing happens at an interval and at turn end, wakes coalesce under ADR 0144, and fresh admission keeps their text from the model); it only shortens the gap between cycles CEL already permits.
    Remediation: State a host-enforced limit for unverified run-record hints (coalesce, minimum gap or per-scope cycle budget, fall back to normal reconciliation), or add actor admission to the candidate rules.
  • [doc-style] docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:103 — Prose line is about 103 columns, over the ~80-column wrapping rule in docs/contributing/documentation.md.
    Remediation: Wrap the sentence at ~80 columns, breaking after "signal alike."
  • [doc-style] docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:57 — ADR 0106 (accepted, on main) is cited as plain text here and on lines 73 and 85, while ADR 0144 and ADR 0114 are linked.
    Remediation: Link it as [ADR 0106](0106-serialize-agent-runs-and-coalesce-subsequent-events.md).
  • [doc-style] docs/ADRs/0119-signal-github-actions-events-to-a-running-cycle.md:99 — ADR 0107 (accepted, on main) is cited as plain text rather than a relative link.
    Remediation: Link it as [ADR 0107](0107-bot-identity-resolution-for-dispatch-authorization.md).
Previous run (3)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMTgtc2lnbmFsLWdpdGh1Yi1hY3Rpb25zLWV2ZW50cy10by1hLXJ1bm5pbmctY3ljbGUubWQiLCJpZCI6ImZfZmYwMGZkMjMwMzBjMWMwNyIsImxpbmUiOjEwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMTgtc2lnbmFsLWdpdGh1Yi1hY3Rpb25zLWV2ZW50cy10by1hLXJ1bm5pbmctY3ljbGUubWQiLCJpZCI6ImZfMTIxN2I3NmE0MWIxYjM0MSIsImxpbmUiOjk4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmX2IzNDZjZDJmZTc2ZDU3NzMiLCJsaW5lIjo0MzUsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktY29udHJhY3QiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMTgtc2lnbmFsLWdpdGh1Yi1hY3Rpb25zLWV2ZW50cy10by1hLXJ1bm5pbmctY3ljbGUubWQiLCJpZCI6ImZfZmZkMjRiZDMzM2I2ODU0MiIsImxpbmUiOjEzMCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJkb2NzL0FEUnMvMDExOC1zaWduYWwtZ2l0aHViLWFjdGlvbnMtZXZlbnRzLXRvLWEtcnVubmluZy1jeWNsZS5tZCIsImlkIjoiZl9mZDdlODkwYjgwOGRmNjIwIiwibGluZSI6OTUsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl9mZDdlODkwYjgwOGRmNjIwIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMTIxN2I3NmE0MWIxYjM0MSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IzNDZjZDJmZTc2ZDU3NzMiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9mZmQyNGJkMzMzYjY4NTQyIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== -->

Review

Findings

Low

  • [doc-style] docs/ADRs/0118-signal-github-actions-events-to-a-running-cycle.md:103 — The paragraph at lines 97–107 has one 103-character line, so the sentence appended there was not re-wrapped to the ~80-column prose convention.
    Remediation: Re-wrap the paragraph at about 80 columns.

Earlier findings

  • docs/ADRs/0118-signal-github-actions-events-to-a-running-cycle.md:95, logic-error, resolved. The actor-exclusion bullet changed from "not one of Fullsend's own App identities" to "not the App identity of the running harness itself", and the following paragraph now says that runs triggered by other registered agents still count.
Previous run (4)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImRvY3MvQURScy8wMTE4LXNpZ25hbC1naXRodWItYWN0aW9ucy1ldmVudHMtdG8tYS1ydW5uaW5nLWN5Y2xlLm1kIiwiaWQiOiJmX2ZkN2U4OTBiODA4ZGY2MjAiLCJsaW5lIjo5NSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJkb2NzL0FEUnMvMDExOC1zaWduYWwtZ2l0aHViLWFjdGlvbnMtZXZlbnRzLXRvLWEtcnVubmluZy1jeWNsZS5tZCIsImlkIjoiZl8xMjE3Yjc2YTQxYjFiMzQxIiwibGluZSI6OTgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfYjM0NmNkMmZlNzZkNTc3MyIsImxpbmUiOjQzNSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL0FEUnMvMDExOC1zaWduYWwtZ2l0aHViLWFjdGlvbnMtZXZlbnRzLXRvLWEtcnVubmluZy1jeWNsZS5tZCIsImlkIjoiZl9mZmQyNGJkMzMzYjY4NTQyIiwibGluZSI6MTMwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfMTIxN2I3NmE0MWIxYjM0MSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IzNDZjZDJmZTc2ZDU3NzMiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9mZmQyNGJkMzMzYjY4NTQyIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== -->

Review

Findings

Medium

  • [logic-error] docs/ADRs/0118-signal-github-actions-events-to-a-running-cycle.md:95 — The candidate rule excludes run records whose triggering actor is any of Fullsend's own App identities. That also discards legitimate updates from other agents, not only the running agent's own feedback. A registered review agent can submit a review or add a handoff label while a fix cycle is running, and ADR 0107 permits those bot-to-bot dispatch signals. Their shim runs would never wake the active cycle. Event-only harnesses on GitHub Actions have no other path, so the cycle continues on stale input until the queued execution starts.
    Remediation: Distinguish self-generated feedback (the running agent's own identity) from updates by other registered agents, or let bot-originated matching records prompt a steer attempt and rely on fresh admission and update detection to reject irrelevant changes.

Earlier findings

  • docs/ADRs/0118-signal-github-actions-events-to-a-running-cycle.md:98, logic-error, resolved — the false-match sentence now states that a match costs one steer attempt and makes a check due, and describes the entity-source harness case.
  • docs/ADRs/0118-signal-github-actions-events-to-a-running-cycle.md:130, api-contract, resolved — the Consequences bullet now states per-page request cost against the listing credential's budget instead of the job token's.
  • docs/architecture.md:435, incomplete-doc, resolved — the architecture bullet now describes the GitHub Actions run-record signal, its limits, and links ADR 0118.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (5)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImRvY3MvQURScy8wMTE4LXNpZ25hbC1naXRodWItYWN0aW9ucy1ldmVudHMtdG8tYS1ydW5uaW5nLWN5Y2xlLm1kIiwiaWQiOiJmXzEyMTdiNzZhNDFiMWIzNDEiLCJsaW5lIjo5OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl9iMzQ2Y2QyZmU3NmQ1NzczIiwibGluZSI6NDM1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLWNvbnRyYWN0IiwiZmlsZSI6ImRvY3MvQURScy8wMTE4LXNpZ25hbC1naXRodWItYWN0aW9ucy1ldmVudHMtdG8tYS1ydW5uaW5nLWN5Y2xlLm1kIiwiaWQiOiJmX2ZmZDI0YmQzMzNiNjg1NDIiLCJsaW5lIjoxMzAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn1dfQ== -->

Review

Findings

Medium

  • [logic-error] docs/ADRs/0118-signal-github-actions-events-to-a-running-cycle.md:98 — The ADR says a false match "costs only one entity re-read that admits nothing new." That contradicts ADR 0144. The signal makes a check due. A due check evaluates the harness CEL, and a true predicate selects an actionable cycle. ADR 0144 also says Fullsend adds no second handled-state or revision-deduplication gate. So an unrelated shim run that matches the criteria can start another full sandbox cycle if CEL stays true.
    Remediation: State the real consequence: a false match can trigger a fresh eligibility check and, when CEL stays true, an additional sandbox cycle. Say that avoiding redundant cycles depends on harness CEL or its pre-script, as ADR 0144 specifies.

  • [incomplete-doc] docs/architecture.md:435 — ADR 0118 is added with status Accepted and partially supersedes ADR 0144. docs/contributing/adrs.md requires docs/architecture.md to be updated in the same PR when a new ADR is Accepted. The "Process lifecycle (target state)" bullet cites only ADR 0144 and does not mention the GitHub Actions run-record change signal or link ADR 0118.
    Remediation: Update that bullet to describe the run-record change signal that ADR 0118 permits on GitHub Actions, and cite ADR 0118 next to ADR 0144.

Low

  • [api-contract] docs/ADRs/0118-signal-github-actions-events-to-a-running-cycle.md:130 — "Each listing costs one API request" does not match the existing ListWorkflowRunsSince (internal/forge/github/github.go). It pages at 100 runs per request, up to 100 pages, and stops only at the since boundary or a short page. Because each listing re-derives from the call start, the request count grows on a busy or long-running call.
    Remediation: State that a listing costs one request per page fetched, and account for pagination in the cadence and rate-budget discussion.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

@waynesun09

Copy link
Copy Markdown
Member Author

/fs-fix-stop

@github-actions github-actions Bot added the fullsend-no-fix Skip bot-triggered fix agent runs label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Fix agent disabled for this PR. Remove the fullsend-no-fix label or use /fs-fix to re-engage.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:24 PM UTC · Completed 7:33 PM UTC

Commit: 98c53d9 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.46

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Nov 2, 2026
@waynesun09 waynesun09 changed the title docs(adr): 0118 signal GitHub Actions events to a running cycle docs(adr): 0119 signal GitHub Actions events to a running cycle Nov 3, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:13 AM UTC · Completed 1:25 AM UTC

Commit: 8305b55 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.19

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Nov 3, 2026
fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review November 3, 2026 01:25

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Nov 3, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:08 AM UTC · Completed 2:19 AM UTC

Commit: be588f5 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.38

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Nov 3, 2026
fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review November 3, 2026 02:19

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Nov 3, 2026
On GitHub Actions, shim workflow run records signal a running cycle.

Assisted-by: Claude (fix), Claude (review)
Signed-off-by: Wayne Sun <gsun@redhat.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:17 AM UTC · Completed 3:25 AM UTC

Commit: 6da8065 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.55

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Nov 3, 2026
@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review November 3, 2026 03:25

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Nov 3, 2026

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — 6da8065d Deployed Nov 3, 2026 by github-actions[bot]
dev — 6da8065d Deployed Nov 3, 2026 by waynesun09 via playback #18691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fullsend-no-fix Skip bot-triggered fix agent runs ready-for-merge All reviewers approved — ready to merge risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant