Skip to content

docs(adr): 0120 record absorbed steers as agent-run receipts - #9031

Open
waynesun09 wants to merge 1 commit into
mainfrom
steer-adr-0120
Open

waynesun09 wants to merge 1 commit into
mainfrom
steer-adr-0120

Conversation

@waynesun09

@waynesun09 waynesun09 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Reading order: start with #9030 (ADR 0117), then #9028 (0118) → #9029 (0119) → #9031 (0120) → #9032 (0121). PR numbers do not follow ADR numbers, because the ADRs were renumbered into dependency order; this PR is ADR 0120.

Summary

ADR 0120 of five that rebuild the steering design (#6957) on the entity ADRs now on main (0133, 0141, 0144, 0147–0149, 0151). Docs only.

Decision: An absorbed steer is recorded in the host-written final run metadata that ADR 0144 defines (on GitHub Actions, the prior run's fullsend-<agent> artifact), with each absorbed record's key and delivered content digest. The host verifies it against current state before the next cycle's CEL or pre-script sees it; anything missing, changed or mismatched means the cycle runs. Fullsend adds no runner skip.

Steering hands a work-item update to the agent that is still running, so it can adjust before finishing on stale state. After ADR 0144 the next sandbox cycle is the correctness backstop; steering is a fast path inside one cycle.

The series

ADR Title PR
0117 Steer a running cycle with admitted entity updates #9030
0118 Steer runtime interface #9028
0119 Signal GitHub Actions events to a running cycle #9029
0120 Record absorbed steers as agent-run receipts this PR
0121 Steering on by default #9032
  • Merge order: 0117 → 0118 → 0119 → 0120 → 0121. Numbers follow dependency: each ADR cites only lower-numbered ones. Each PR passes the docs checks on its own; links to siblings that are not on main yet are plain text ("ADR 0117 (proposed)") and can become links once they merge.
  • Accepted ADRs touched: None

Implementation dependencies

No code here. Implementation lands with or after:

  • ADR 0151 human_min_role admission;
  • the ADR 0141 filter pipeline and host-side extension path;
  • the ADR 0144 bound-run lifecycle;
  • entity-context-snapshot v2 for the receipt fields (ADR 0120).

The runtime interface (0118) and the run-record signal (0119) can be built first; they have no caller until the rest exists.

Lineage

These replace drafts in the earlier steering stack, which predate the entity ADRs.

  • feat(cli): receipt the absorbed update under the job token, and skip the queued run #7456 (0120 job-token receipt): the host-posted job-token comment is kept as a considered option. It is also host-written, but every workflow job in the repository posts under the same github-actions login, so the receipt moves to host-written run metadata bound to one run by its platform metadata. The runner skip is dropped (ADR 0144 leaves handled state to the harness).

Never cancelling the in-flight run (#7007) is already ADR 0106's decision, so it needs no new ADR.

Evidence

Current-behaviour claims in ADR 0120, with the code or merged contract that holds them:

Testing

  • pre-commit run --from-ref origin/main --to-ref HEAD: all hooks pass (ADR status, number and front-matter linters, markdown links, secrets).
  • make lint-md-links: 0 errors.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Document App-authored receipts for absorbed steers

📝 Documentation 🕐 20-40 Minutes

Grey Divider

AI Description

• Add ADR 0120 to prevent redundant work after a running cycle absorbs entity updates.
• Require App-authored, unedited receipts before a harness treats updates as handled.
• Keep follow-up decisions in the harness; receipts require entity-context-snapshot v2.
Diagram

graph TD
  A["Steered cycle"] --> B{"Acknowledged steer and validated output?"} -->|Yes| C["Host posts as App"] --> D["Snapshot v2 agent_runs"] --> E{"Trusted, readable receipt?"} -->|Yes| F["Harness avoids replay"]
  E -->|No| G["Next cycle runs"]
  B -->|No| G
Loading
High-Level Assessment

The ADR's approach fits the existing entity and harness boundaries: App identity provides distinguishable authorship, while harness policy decides whether work is handled. The documented runner-level skip would add a second gate, and the shared Actions job identity cannot establish receipt authorship. Implementation remains dependent on snapshot v2.

Files changed (1) +126 / -0

Documentation (1) +126 / -0
0120-record-absorbed-steers-as-agent-run-receipts.mdDefine trusted agent-run receipts for absorbed steers +126/-0

Define trusted agent-run receipts for absorbed steers

• Adds ADR 0120, specifying when the host writes a receipt, how a harness admits it, and why unreadable or untrusted receipts leave the next cycle free to run. It rules out a runner skip and Actions job-token authorship, limits support to GitHub steering, and records the snapshot v2 dependency and revision-proof boundary.

docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:59 PM UTC · Completed 7:15 PM UTC

Commit: 0448ab8 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.06

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://009b3df8-site.fullsend-ai.workers.dev

Commit: d59b8c37635b60177f2f32c198b1b8f42554b009

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@waynesun09

Copy link
Copy Markdown
Member Author

/fs-fix-stop

@github-actions github-actions Bot added the fullsend-no-fix Skip bot-triggered fix agent runs label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Fix agent disabled for this PR. Remove the fullsend-no-fix label or use /fs-fix to re-engage.

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Nov 2, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and an architecture cross-reference with no code, CI, or dependency changes.

Previous run

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and an architecture cross-reference with no code, CI, or dependency changes.

Previous run (2)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and an architecture cross-reference with no code, CI, or dependency changes.

Previous run (3)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and architecture cross-reference with no code, CI, or dependency changes.

Previous run (4)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and architecture cross-reference with no code, CI, or dependency changes.

Previous run (5)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and an architecture cross-reference with no code, CI, or dependency changes.

Previous run (6)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and an architecture cross-reference with no code, CI, or dependency changes.

Previous run (7)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and an architecture cross-reference with no code, CI, or dependency changes.

Previous run (8)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and an architecture cross-reference with no code, CI, or dependency changes.

Previous run (9)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and an architecture cross-reference with no code, CI, or dependency changes.

Previous run (10)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of ADR 0120 and an architecture cross-reference with no code, CI, or dependency changes.

Previous run (11)

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Documentation-only addition of a single new ADR file with no code, CI, or dependency changes.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Looks good to me

Earlier findings

  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md, auth-bypass — resolved: the provenance rules now accept only runs whose workflow code came from the default branch the current run also uses, and state that pull-request-ref triggers never produce an accepted receipt (lines 138-142).
  • docs/architecture.md, doc-style — resolved: the added bullet is wrapped and indented consistently with sibling entries.
Previous run

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2M5ZDcxZjhlOGM5NTI5Y2IiLCJsaW5lIjoxMzksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmX2FmZGRlNjhiMmVjYTE5M2IiLCJsaW5lIjo0NjgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9iZWQ1ZDQ4YWU1M2VjMDNlIiwibGluZSI6ODEsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoidW5kZXItZW5naW5lZXJpbmciLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYmIyNjE5ZTllMDkxMTdkMiIsImxpbmUiOjcwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfYTA5YWYzMjE5ZDYxNWViYiIsImxpbmUiOjQ1MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xMzQ3MjI4ZGJiYjIyN2FhIiwibGluZSI6NjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2E2YzIzNmRkNGZlMmM5NTUiLCJsaW5lIjoxMjMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8wMmY0MGY5NTgxNTZhYzM4IiwibGluZSI6MTM5LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfN2Q2ZjE3YWI3YzMyMzVmYyIsImxpbmUiOjY4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xY2NmMzJkYzk1MDgyZTU0IiwibGluZSI6OTksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXV0aC1ieXBhc3MiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfNzY4YzhhYjRkZGViNGM3ZCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzhmNWIwM2U2NDMxZDYyMGEiLCJsaW5lIjoxMDcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9hYWNlYWVhYWNkNmQ4OTNjIiwibGluZSI6MTMwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFyY2hpdGVjdHVyYWwtY29uZmxpY3QiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfZjY0ZjFjOGQ0OGY1ZGZiNSIsImxpbmUiOjQ2MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFyY2hpdGVjdHVyYWwtY29uZmxpY3QiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfMWJlMDBiZjQ2N2MyNWYyNiIsImxpbmUiOjQ2MCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzFiZTAwYmY0NjdjMjVmMjYiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9iZWQ1ZDQ4YWU1M2VjMDNlIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYmIyNjE5ZTllMDkxMTdkMiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2EwOWFmMzIxOWQ2MTVlYmIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8xMzQ3MjI4ZGJiYjIyN2FhIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYTZjMjM2ZGQ0ZmUyYzk1NSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzAyZjQwZjk1ODE1NmFjMzgiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl83ZDZmMTdhYjdjMzIzNWZjIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMWNjZjMyZGM5NTA4MmU1NCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzc2OGM4YWI0ZGRlYjRjN2QiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl84ZjViMDNlNjQzMWQ2MjBhIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYWFjZWFlYWFjZDZkODkzYyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2Y2NGYxYzhkNDhmNWRmYjUiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Review

Findings

Medium

  • [auth-bypass] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:139 — The provenance rule accepts a receipt from any run whose workflow code came from the default branch with a matching harness, repository and canonical entity. Nothing requires the producing workflow to be the authorized Fullsend workflow, although the platform metadata the ADR lists includes the workflow file. Another default-branch workflow could upload an artifact with the same name and metadata path, matching receipt fields and matching digests. The next cycle could then skip work it still owes.
    Remediation: Require the platform-verified producer identity (workflow file and harness job) to match the authorized Fullsend workflow, in addition to repository and default-branch provenance. State that artifacts from unrelated workflows are rejected even when their artifact name, metadata path and receipt fields match.

Low

  • [doc-style] docs/architecture.md:468 — The new bullet has a 102-character line, over the ~80-column wrapping rule in docs/contributing/documentation.md. The next line, Fullsend adds no runner skip, is short.
    Remediation: Rewrap lines 468–470 at about 80 columns.

Earlier findings

  • docs/architecture.md:460, architectural-conflict — resolved. The new bullet marks the pre-script-only receipt as a subtype of ADR 0098 explicit receipts, so it does not contradict the existing statement that CEL can use explicit receipts.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (2)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcmNoaXRlY3R1cmFsLWNvbmZsaWN0IiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmXzFiZTAwYmY0NjdjMjVmMjYiLCJsaW5lIjo0NjAsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImhpZ2giLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2JlZDVkNDhhZTUzZWMwM2UiLCJsaW5lIjo4MSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJ1bmRlci1lbmdpbmVlcmluZyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9iYjI2MTllOWUwOTExN2QyIiwibGluZSI6NzAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl9hMDlhZjMyMTlkNjE1ZWJiIiwibGluZSI6NDUyLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzEzNDcyMjhkYmJiMjI3YWEiLCJsaW5lIjo2OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYTZjMjM2ZGQ0ZmUyYzk1NSIsImxpbmUiOjEyMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzAyZjQwZjk1ODE1NmFjMzgiLCJsaW5lIjoxMzksImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl83ZDZmMTdhYjdjMzIzNWZjIiwibGluZSI6NjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzFjY2YzMmRjOTUwODJlNTQiLCJsaW5lIjo5OSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl83NjhjOGFiNGRkZWI0YzdkIiwibGluZSI6ODksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXV0aC1ieXBhc3MiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfOGY1YjAzZTY0MzFkNjIwYSIsImxpbmUiOjEwNywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXBpLWNvbnRyYWN0IiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2FhY2VhZWFhY2Q2ZDg5M2MiLCJsaW5lIjoxMzAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXJjaGl0ZWN0dXJhbC1jb25mbGljdCIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl9mNjRmMWM4ZDQ4ZjVkZmI1IiwibGluZSI6NDYyLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8xYmUwMGJmNDY3YzI1ZjI2Iiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfZjY0ZjFjOGQ0OGY1ZGZiNSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2JlZDVkNDhhZTUzZWMwM2UiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9iYjI2MTllOWUwOTExN2QyIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYTA5YWYzMjE5ZDYxNWViYiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzEzNDcyMjhkYmJiMjI3YWEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9hNmMyMzZkZDRmZTJjOTU1Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMDJmNDBmOTU4MTU2YWMzOCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzdkNmYxN2FiN2MzMjM1ZmMiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8xY2NmMzJkYzk1MDgyZTU0Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfNzY4YzhhYjRkZGViNGM3ZCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzhmNWIwM2U2NDMxZDYyMGEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9hYWNlYWVhYWNkNmQ4OTNjIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== -->

Review

Findings

Low

  • [architectural-conflict] docs/architecture.md:460 — The new absorbed-steer receipts bullet does not say the mechanism works only on GitHub Actions and depends on the prior run's artifact. ADR 0120 documents this in its Forge scope and Consequences sections, but a reader of the architecture summary alone will not see the limit.
    Remediation: Optional: add a short clause to the bullet, e.g. "GitHub Actions only for now; see ADR 0120 Forge scope."

Earlier findings

  • docs/architecture.md:460, architectural-conflict — reclassified from medium to low. The ADR keeps the receipt fail-open (missing or mismatched metadata means the cycle runs), so it is not coordination state. The ADR also weighs the entity-visible alternative in its Options table. Only the missing GitHub-only scope note in the architecture summary remains.
  • docs/architecture.md:462, architectural-conflict — resolved. The architecture.md bullet now says these receipts are a separate, pre-script-only kind and not the CEL-visible receipts ADR 0098 allows. ADR 0120 "Pre-script only" gives the reason: CEL evaluates before the snapshot exists.
Previous run (3)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFyY2hpdGVjdHVyYWwtY29uZmxpY3QiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfMWJlMDBiZjQ2N2MyNWYyNiIsImxpbmUiOjQ2MCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFyY2hpdGVjdHVyYWwtY29uZmxpY3QiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfZjY0ZjFjOGQ0OGY1ZGZiNSIsImxpbmUiOjQ2MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9iZWQ1ZDQ4YWU1M2VjMDNlIiwibGluZSI6ODEsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoidW5kZXItZW5naW5lZXJpbmciLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYmIyNjE5ZTllMDkxMTdkMiIsImxpbmUiOjcwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfYTA5YWYzMjE5ZDYxNWViYiIsImxpbmUiOjQ1MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xMzQ3MjI4ZGJiYjIyN2FhIiwibGluZSI6NjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2E2YzIzNmRkNGZlMmM5NTUiLCJsaW5lIjoxMjMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8wMmY0MGY5NTgxNTZhYzM4IiwibGluZSI6MTM5LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfN2Q2ZjE3YWI3YzMyMzVmYyIsImxpbmUiOjY4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xY2NmMzJkYzk1MDgyZTU0IiwibGluZSI6OTksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXV0aC1ieXBhc3MiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfNzY4YzhhYjRkZGViNGM3ZCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzhmNWIwM2U2NDMxZDYyMGEiLCJsaW5lIjoxMDcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9hYWNlYWVhYWNkNmQ4OTNjIiwibGluZSI6MTMwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfZjY0ZjFjOGQ0OGY1ZGZiNSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9iZWQ1ZDQ4YWU1M2VjMDNlIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYmIyNjE5ZTllMDkxMTdkMiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2EwOWFmMzIxOWQ2MTVlYmIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8xMzQ3MjI4ZGJiYjIyN2FhIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYTZjMjM2ZGQ0ZmUyYzk1NSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzAyZjQwZjk1ODE1NmFjMzgiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl83ZDZmMTdhYjdjMzIzNWZjIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMWNjZjMyZGM5NTA4MmU1NCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzc2OGM4YWI0ZGRlYjRjN2QiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl84ZjViMDNlNjQzMWQ2MjBhIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYWFjZWFlYWFjZDZkODkzYyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= -->

Review

Findings

Medium

  • [architectural-conflict] docs/architecture.md:460 — The new "Absorbed-steer receipts (target state)" bullet (lines 460-470) sits right after the unchanged ADR 0098 bullet. Lines 455-456 say "harness CEL can use entity state or explicit receipts to decide whether work has already been handled". The new bullet then says ADR 0120 receipts are staged through entity-context-snapshot v2 for the pre-script and "harness CEL does not see it". Read together, the two adjacent bullets give conflicting answers on whether harness CEL or the pre-script uses receipts, and nothing tells the reader that the ADR 0098 "explicit receipts" are a different, CEL-visible kind from absorbed-steer receipts. Separately, the new bullet puts an unresolved question ("Open: which shipped harnesses should read receipts first, and does a shared helper belong in fullsend-ai/agents?", line 469) inside the "Decided" list instead of the section's "Open questions" list (line 583).
    Remediation: Reword the ADR 0098 bullet, or the new ADR 0120 bullet, to separate handled-state evidence that CEL evaluates (entity state or CEL-visible receipts) from ADR 0120 absorbed-steer receipts, which only harness pre-scripts read. Move the question about shipped harnesses and a shared helper into the "Open questions" list at line 583.

Earlier findings

  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md (several), auth-bypass, edge-case, api-contract, under-engineering, doc-style — resolved by change; the current ADR text addresses them (host-only write path, platform-verified provenance, per-record digest, eligibility and carry-forward rules).
  • docs/architecture.md, incomplete-doc — resolved by change; the receipts bullet is now in the architecture decided list.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (4)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFyY2hpdGVjdHVyYWwtY29uZmxpY3QiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfZjY0ZjFjOGQ0OGY1ZGZiNSIsImxpbmUiOjQ2MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9iZWQ1ZDQ4YWU1M2VjMDNlIiwibGluZSI6ODEsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoidW5kZXItZW5naW5lZXJpbmciLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYmIyNjE5ZTllMDkxMTdkMiIsImxpbmUiOjcwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfYTA5YWYzMjE5ZDYxNWViYiIsImxpbmUiOjQ1MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xMzQ3MjI4ZGJiYjIyN2FhIiwibGluZSI6NjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2E2YzIzNmRkNGZlMmM5NTUiLCJsaW5lIjoxMjMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8wMmY0MGY5NTgxNTZhYzM4IiwibGluZSI6MTM5LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfN2Q2ZjE3YWI3YzMyMzVmYyIsImxpbmUiOjY4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xY2NmMzJkYzk1MDgyZTU0IiwibGluZSI6OTksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXV0aC1ieXBhc3MiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfNzY4YzhhYjRkZGViNGM3ZCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzhmNWIwM2U2NDMxZDYyMGEiLCJsaW5lIjoxMDcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9hYWNlYWVhYWNkNmQ4OTNjIiwibGluZSI6MTMwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYWFjZWFlYWFjZDZkODkzYyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2JlZDVkNDhhZTUzZWMwM2UiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9iYjI2MTllOWUwOTExN2QyIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYTA5YWYzMjE5ZDYxNWViYiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzEzNDcyMjhkYmJiMjI3YWEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9hNmMyMzZkZDRmZTJjOTU1Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMDJmNDBmOTU4MTU2YWMzOCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzdkNmYxN2FiN2MzMjM1ZmMiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8xY2NmMzJkYzk1MDgyZTU0Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfNzY4YzhhYjRkZGViNGM3ZCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzhmNWIwM2U2NDMxZDYyMGEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Review

Findings

Medium

  • [architectural-conflict] docs/architecture.md:462 — The new architecture bullet says "Before the next cycle's CEL or pre-script runs, the host reads the receipt ... and stages it through entity-context-snapshot v2." ADR 0120's "Pre-script only" bullet, added in this same PR, says the receipt is staged for the pre-script only and "Harness CEL does not see it: CEL evaluates the normalized entity and event before the snapshot exists." The architecture summary gets the order wrong and suggests CEL can read receipt data.
    Remediation: In docs/architecture.md line 462, change "Before the next cycle's CEL or pre-script runs" to "Before the next cycle's pre-script runs", to match ADR 0120's pre-script-only boundary.

Earlier findings

  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md (PR-head rewrite), api-contract — resolved: the ADR now requires entity-context-snapshot v2 for receipt fields and limits receipt consumption to the pre-script, so it no longer conflicts with the closed v1 snapshot schema.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (5)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9hYWNlYWVhYWNkNmQ4OTNjIiwibGluZSI6MTMwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9iZWQ1ZDQ4YWU1M2VjMDNlIiwibGluZSI6ODEsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoidW5kZXItZW5naW5lZXJpbmciLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYmIyNjE5ZTllMDkxMTdkMiIsImxpbmUiOjcwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfYTA5YWYzMjE5ZDYxNWViYiIsImxpbmUiOjQ1MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xMzQ3MjI4ZGJiYjIyN2FhIiwibGluZSI6NjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2E2YzIzNmRkNGZlMmM5NTUiLCJsaW5lIjoxMjMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8wMmY0MGY5NTgxNTZhYzM4IiwibGluZSI6MTM5LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfN2Q2ZjE3YWI3YzMyMzVmYyIsImxpbmUiOjY4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xY2NmMzJkYzk1MDgyZTU0IiwibGluZSI6OTksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXV0aC1ieXBhc3MiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfNzY4YzhhYjRkZGViNGM3ZCIsImxpbmUiOjg5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzhmNWIwM2U2NDMxZDYyMGEiLCJsaW5lIjoxMDcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYmVkNWQ0OGFlNTNlYzAzZSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2JiMjYxOWU5ZTA5MTE3ZDIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9hMDlhZjMyMTlkNjE1ZWJiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMTM0NzIyOGRiYmIyMjdhYSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2E2YzIzNmRkNGZlMmM5NTUiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8wMmY0MGY5NTgxNTZhYzM4Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfN2Q2ZjE3YWI3YzMyMzVmYyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzFjY2YzMmRjOTUwODJlNTQiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl83NjhjOGFiNGRkZWI0YzdkIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfOGY1YjAzZTY0MzFkNjIwYSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= -->

Review

Findings

Medium

  • [api-contract] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:130 — The ADR says the verified receipt is staged in the snapshot's agent-runs history "where CEL and the pre-script read it as ADR 0098 allows", and line 116 says the host reads the receipt before CEL runs. ADR 0098 gives CEL only entity and an optional event. ADR 0144 evaluates CEL first and assembles the snapshot only for an admitted cycle. A snapshot v2 field therefore reaches the pre-script but not CEL. The ADR doesn't define how the receipt gets into the normalized entity that CEL sees, so its CEL-based suppression path has no input.
    Remediation: Specify that verified receipts are projected into the versioned normalized-entity CEL contract before predicate evaluation, with snapshot v2 carrying the script-facing representation afterward. Alternatively, limit this decision to pre-script consumption.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (6)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaGlnaCIsImNhdGVnb3J5IjoiYXV0aC1ieXBhc3MiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYmVkNWQ0OGFlNTNlYzAzZSIsImxpbmUiOjgxLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InVuZGVyLWVuZ2luZWVyaW5nIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2JiMjYxOWU5ZTA5MTE3ZDIiLCJsaW5lIjo3MCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmX2EwOWFmMzIxOWQ2MTVlYmIiLCJsaW5lIjo0NTIsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfMTM0NzIyOGRiYmIyMjdhYSIsImxpbmUiOjY4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9hNmMyMzZkZDRmZTJjOTU1IiwibGluZSI6MTIzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfMDJmNDBmOTU4MTU2YWMzOCIsImxpbmUiOjEzOSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzdkNmYxN2FiN2MzMjM1ZmMiLCJsaW5lIjo2OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfMWNjZjMyZGM5NTA4MmU1NCIsImxpbmUiOjk5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzc2OGM4YWI0ZGRlYjRjN2QiLCJsaW5lIjo4OSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl84ZjViMDNlNjQzMWQ2MjBhIiwibGluZSI6MTA3LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzc2OGM4YWI0ZGRlYjRjN2QiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl84ZjViMDNlNjQzMWQ2MjBhIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYmVkNWQ0OGFlNTNlYzAzZSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2JiMjYxOWU5ZTA5MTE3ZDIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9hMDlhZjMyMTlkNjE1ZWJiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMTM0NzIyOGRiYmIyMjdhYSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2E2YzIzNmRkNGZlMmM5NTUiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8wMmY0MGY5NTgxNTZhYzM4Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfN2Q2ZjE3YWI3YzMyMzVmYyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzFjY2YzMmRjOTUwODJlNTQiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Looks good to me

Earlier findings

  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md — auth-bypass: resolved. The rewritten ADR requires platform-verified provenance for the producing run (repository, workflow file, event type, ref and revision) and accepts only the trusted default-branch workflow.
  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md — auth-bypass: resolved. The ADR now limits handled-state evidence to eligible, successful cycles with per-record digest checks. Resident cycles read host-private state, and missing or mismatched evidence means the cycle runs.
Previous run (7)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzc2OGM4YWI0ZGRlYjRjN2QiLCJsaW5lIjo4OSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl84ZjViMDNlNjQzMWQ2MjBhIiwibGluZSI6MTA3LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaGlnaCIsImNhdGVnb3J5IjoiYXV0aC1ieXBhc3MiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYmVkNWQ0OGFlNTNlYzAzZSIsImxpbmUiOjgxLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InVuZGVyLWVuZ2luZWVyaW5nIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2JiMjYxOWU5ZTA5MTE3ZDIiLCJsaW5lIjo3MCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmX2EwOWFmMzIxOWQ2MTVlYmIiLCJsaW5lIjo0NTIsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfMTM0NzIyOGRiYmIyMjdhYSIsImxpbmUiOjY4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9hNmMyMzZkZDRmZTJjOTU1IiwibGluZSI6MTIzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfMDJmNDBmOTU4MTU2YWMzOCIsImxpbmUiOjEzOSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzdkNmYxN2FiN2MzMjM1ZmMiLCJsaW5lIjo2OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfMWNjZjMyZGM5NTA4MmU1NCIsImxpbmUiOjk5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYmVkNWQ0OGFlNTNlYzAzZSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2JiMjYxOWU5ZTA5MTE3ZDIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9hMDlhZjMyMTlkNjE1ZWJiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMTM0NzIyOGRiYmIyMjdhYSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2E2YzIzNmRkNGZlMmM5NTUiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8wMmY0MGY5NTgxNTZhYzM4Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfN2Q2ZjE3YWI3YzMyMzVmYyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzFjY2YzMmRjOTUwODJlNTQiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Review

Findings

Medium

  • [auth-bypass] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:89 — The receipt admission rule accepts a receipt "only from the prior run of the same harness's own workflow" and matching harness, repository, and entity fields, but never requires the producing run to come from a trusted revision or ref (for example the default branch rather than a fork PR or untrusted branch). Where such triggers are enabled, a run of the same workflow path from attacker-controlled code could upload a fullsend-<agent> artifact with matching identifiers. Record digests are recomputable, and the sandbox write-path argument does not cover a producer outside the Fullsend sandbox. The ADR bounds the impact (a changed record still runs the cycle), but a forged receipt could suppress follow-up work for unchanged records.
    Remediation: State that the reader checks provenance against platform metadata, not fields inside the receipt: the producing run's repository, workflow, ref or revision, and event type. Reject runs from forks or untrusted branches and PRs. If provenance cannot be verified, ignore the receipt so the cycle runs.

Low

  • [auth-bypass] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:107 — The host digest-checks each absorbed record against current state and then stages the receipt into the snapshot, but the ADR does not require both steps to use the same record acquisition. An edit in between is itself a new update that schedules another cycle, so exploitability is limited.
    Remediation: Optionally state that the digest check uses the same acquisition as the snapshot built for the decision, and that rebuilding the snapshot repeats the receipt check.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (8)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaGlnaCIsImNhdGVnb3J5IjoiYXV0aC1ieXBhc3MiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYmVkNWQ0OGFlNTNlYzAzZSIsImxpbmUiOjgxLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InVuZGVyLWVuZ2luZWVyaW5nIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2JiMjYxOWU5ZTA5MTE3ZDIiLCJsaW5lIjo3MCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmX2EwOWFmMzIxOWQ2MTVlYmIiLCJsaW5lIjo0NTIsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfMTM0NzIyOGRiYmIyMjdhYSIsImxpbmUiOjY4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9hNmMyMzZkZDRmZTJjOTU1IiwibGluZSI6MTIzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfMDJmNDBmOTU4MTU2YWMzOCIsImxpbmUiOjEzOSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzdkNmYxN2FiN2MzMjM1ZmMiLCJsaW5lIjo2OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfMWNjZjMyZGM5NTA4MmU1NCIsImxpbmUiOjk5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfMWNjZjMyZGM5NTA4MmU1NCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2JlZDVkNDhhZTUzZWMwM2UiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9iYjI2MTllOWUwOTExN2QyIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYTA5YWYzMjE5ZDYxNWViYiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzEzNDcyMjhkYmJiMjI3YWEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9hNmMyMzZkZDRmZTJjOTU1Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMDJmNDBmOTU4MTU2YWMzOCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzdkNmYxN2FiN2MzMjM1ZmMiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Looks good to me

Earlier findings

  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:99 — edge-case — resolved: lines 102–105 now take the receipt for later cycles in one resident fullsend run from host-private run state, with the same eligibility and digest checks.
Previous run (9)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xY2NmMzJkYzk1MDgyZTU0IiwibGluZSI6OTksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImhpZ2giLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2JlZDVkNDhhZTUzZWMwM2UiLCJsaW5lIjo4MSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJ1bmRlci1lbmdpbmVlcmluZyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9iYjI2MTllOWUwOTExN2QyIiwibGluZSI6NzAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl9hMDlhZjMyMTlkNjE1ZWJiIiwibGluZSI6NDUyLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzEzNDcyMjhkYmJiMjI3YWEiLCJsaW5lIjo2OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYTZjMjM2ZGQ0ZmUyYzk1NSIsImxpbmUiOjEyMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzAyZjQwZjk1ODE1NmFjMzgiLCJsaW5lIjoxMzksImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl83ZDZmMTdhYjdjMzIzNWZjIiwibGluZSI6NjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8xMzQ3MjI4ZGJiYjIyN2FhIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYTZjMjM2ZGQ0ZmUyYzk1NSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzAyZjQwZjk1ODE1NmFjMzgiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl83ZDZmMTdhYjdjMzIzNWZjIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYmVkNWQ0OGFlNTNlYzAzZSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2JiMjYxOWU5ZTA5MTE3ZDIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9hMDlhZjMyMTlkNjE1ZWJiIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== -->

Review

Findings

Medium

  • [edge-case] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:99 — The receipt read path does not cover follow-up cycles within the same resident run. ADR 0144 explicitly allows the immediate follow-up to execute inside the active fullsend run process, but this decision reads only the prior workflow run's artifact and publishes the current receipt after fullsend run exits. A successful steered cycle's acknowledgements are therefore unavailable to the very next cycle in the resident lifecycle, so the advertised suppression of redundant follow-up work cannot function on that path.
    Remediation: Define a host-private, per-cycle receipt handoff for subsequent checks in the same process, using the same eligibility and current-digest verification rules, while retaining the final artifact for later platform executions. Alternatively, explicitly limit this decision's suppression guarantees to follow-ups after the issuing process exits.

Earlier findings

  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:68, edge-case (two findings) — resolved by change: the head adds that a steered cycle is eligible as handled-state evidence only if it completed successfully, with outcome and eligibility recorded per cycle and ineligible cycles' records not listed as absorbed.
  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:123, doc-style — resolved by change: the vague "Other platforms" forge-scope bullet is replaced by explicit GitLab and Forgejo entries.
  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:139, doc-style — resolved by change: the "Open questions" section is removed from the ADR.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (10)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8xMzQ3MjI4ZGJiYjIyN2FhIiwibGluZSI6NjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmX2E2YzIzNmRkNGZlMmM5NTUiLCJsaW5lIjoxMjMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl8wMmY0MGY5NTgxNTZhYzM4IiwibGluZSI6MTM5LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfN2Q2ZjE3YWI3YzMyMzVmYyIsImxpbmUiOjY4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9iZWQ1ZDQ4YWU1M2VjMDNlIiwibGluZSI6ODEsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoidW5kZXItZW5naW5lZXJpbmciLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjAtcmVjb3JkLWFic29yYmVkLXN0ZWVycy1hcy1hZ2VudC1ydW4tcmVjZWlwdHMubWQiLCJpZCI6ImZfYmIyNjE5ZTllMDkxMTdkMiIsImxpbmUiOjcwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfYTA5YWYzMjE5ZDYxNWViYiIsImxpbmUiOjQ1MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYmVkNWQ0OGFlNTNlYzAzZSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzdkNmYxN2FiN2MzMjM1ZmMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYmIyNjE5ZTllMDkxMTdkMiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2EwOWFmMzIxOWQ2MTVlYmIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Review

Findings

Medium

  • [edge-case] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:68 — Receipt issuance requires an acknowledged steer but does not require the receiving cycle to complete successfully. A cycle can acknowledge a steer and then fail validation, time out, or fail its post-script. Final metadata can still be published (ADR 0144 includes failed outcomes; action.yml uploads artifacts under always()). The admission rules check identity and record digests but never the receiving cycle's outcome, so unchanged records from a failed attempt can be exposed as absorbed and suppress their queued retry.
    Remediation: Define per-cycle receipt eligibility: keep delivery acknowledgements for audit, but do not admit them as handled-state evidence unless the receiving cycle completed successfully (including required validation and post-script work). Failed, cancelled, timed-out, or unverifiable cycles must leave their records eligible for follow-up work.

Low

  • [doc-style] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:123 — The ## Forge scope section names GitHub and Jira, and covers GitLab and Forgejo only through a conditional "Other platforms" entry. docs/contributing/adrs.md and the ADR template ask the ADR to state how each forge (GitHub, GitLab, Forgejo) is handled.
    Remediation: Replace "Other platforms" with explicit GitLab and Forgejo entries saying whether equivalent host-written run metadata is supported or where follow-up is tracked.
  • [doc-style] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:139 — The ADR ends with an ## Open questions section, which the ADR template does not include. A few existing ADRs (e.g., 0002, 0045, 0063, 0125) have one, so this is minor drift.
    Remediation: Optionally move the question to the **Open questions:** list for the relevant component in docs/architecture.md.

Earlier findings

  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:81, auth-bypass, resolved — the ADR now requires host-written metadata outside the sandbox, same-harness prior-run provenance, matching harness/repository/entity identity, and per-record digest re-verification, with fail-open-to-run on any doubt.
  • docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:70, under-engineering, resolved — the receipt payload, trust boundary, and admission protocol are now specified in the Decision section.
  • docs/architecture.md:452, incomplete-doc, resolved — docs/architecture.md now carries an absorbed-steer receipts bullet linking ADR 0120.

Labels: PR adds an ADR and updates architecture docs


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (11)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJhdXRoLWJ5cGFzcyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9iZWQ1ZDQ4YWU1M2VjMDNlIiwibGluZSI6ODEsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIwLXJlY29yZC1hYnNvcmJlZC1zdGVlcnMtYXMtYWdlbnQtcnVuLXJlY2VpcHRzLm1kIiwiaWQiOiJmXzdkNmYxN2FiN2MzMjM1ZmMiLCJsaW5lIjo2OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJ1bmRlci1lbmdpbmVlcmluZyIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMC1yZWNvcmQtYWJzb3JiZWQtc3RlZXJzLWFzLWFnZW50LXJ1bi1yZWNlaXB0cy5tZCIsImlkIjoiZl9iYjI2MTllOWUwOTExN2QyIiwibGluZSI6NzAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl9hMDlhZjMyMTlkNjE1ZWJiIiwibGluZSI6NDUyLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In1dfQ== -->

Review

Findings

High

  • [auth-bypass] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:81 — The reader admits a receipt on registered bot_role author plus unedited body, which cannot tell a host-issued receipt from one posted directly by a sandbox that can post as the App. Marker neutralization covers only bodies the host posts for the agent. Withholding the host receipt when an App-capable credential was reachable does not stop the sandbox posting its own. ADR 0114 describes sandbox-reachable read-write providers that resolve the App token, and ADR 0107 says bot identity does not make content trustworthy. A compromised agent could suppress owed follow-up work.
    Remediation: Require reader-verifiable host issuance (host-only-key signature, or an authenticated issuance record bound to harness, entity, cycle, and absorbed keys), or refuse admission for identities whose posting capability a sandbox can reach.

Medium

  • [edge-case] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:68 — Receipts name absorbed record keys, not the revision delivered to the agent. Snapshot v1 keys come from immutable forge IDs and edits do not rename a record, so a record edited after its steer was acknowledged still matches the receipt and the next cycle may skip work the agent never saw. The unedited-body check covers only the receipt.
    Remediation: Record each absorbed record's delivered revision (key plus content digest) and have readers compare it with current state; changed or unverifiable means run.
  • [under-engineering] docs/ADRs/0120-record-absorbed-steers-as-agent-run-receipts.md:70 — Admission depends on author bot_role and edit status, but the v2 snapshot change asks only for absorbed keys, steer count, and heads. The v1 agent-runs schema has no author or edit-status fields, so it is unclear who enforces admission.
    Remediation: Specify that v2 carries author/bot_role and edit status for receipts, or state that the host-side snapshot producer filters receipts by author, and document that boundary.
  • [incomplete-doc] docs/architecture.md:452 — The ADR is added as Accepted but the PR changes only the ADR file. docs/contributing/adrs.md requires docs/architecture.md and related problem docs (here agent-architecture, security-threat-model, flapping-convergence) to be updated in the same PR.
    Remediation: Add a summary and ADR 0120 link under "Agent Dispatch and Coordination Layer" and update the related problem docs.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:24 PM UTC · Completed 7:36 PM UTC

Commit: 6f316b8 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.04

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:21 AM UTC · Completed 2:30 AM UTC

Commit: 279aa5d · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.53

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:56 AM UTC · Completed 3:14 AM UTC

Commit: e374e4a · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.19

@fullsend-ai-review
fullsend-ai-review Bot dismissed stale reviews from themself November 3, 2026 03:14

Superseded by updated review

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:17 AM UTC · Completed 3:30 AM UTC

Commit: 4eba3b0 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.87

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Nov 3, 2026
fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review November 3, 2026 03:30

Superseded by updated review

A receipt in host-written run metadata tells the next cycle what was absorbed.

Assisted-by: Claude (fix), Claude (review)
Signed-off-by: Wayne Sun <gsun@redhat.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:35 AM UTC · Completed 3:46 AM UTC

Commit: d59b8c3 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.98

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — d59b8c37 Deployed Nov 3, 2026 by github-actions[bot]
dev — d59b8c37 Deployed Nov 3, 2026 by waynesun09 via playback #18698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/docs User-facing documentation fullsend-no-fix Skip bot-triggered fix agent runs ready-for-merge All reviewers approved — ready to merge risk/low PR risk: low type/adr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant