Repository navigation
docs(adr): 0121 steering on by default - #9032
waynesun09 wants to merge 1 commit into
Conversation
PR Summary by QodoDocument steering as on by default with layered opt-outs
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent |
|
🤖 Finished Review · ✅ Success · Started 7:00 PM UTC · Completed 7:11 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.78 |
Site previewPreview: https://3788788c-site.fullsend-ai.workers.dev Commit: |
|
<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR change with no code or protected paths, elevated to moderate risk by medium blast radius, multi-author contention and change coupling on the modified ADR, and an aging linked issue. Previous run<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR change with no code or protected paths, elevated to moderate risk by medium blast radius, multi-author contention and change coupling on the modified ADR, and an aging linked issue. Previous run (2)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR change with no code or protected paths, elevated to moderate risk by medium blast radius, multi-author contention and change coupling on the modified ADR, and an aging linked issue. Previous run (3)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR change with no code or protected paths, elevated to moderate risk by medium blast radius, multi-author contention and change coupling on the modified ADR, and an aging linked issue. Previous run (4)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR change with no code or protected paths, elevated to moderate risk by medium blast radius, multi-author contention and change coupling on the modified ADR, and an aging linked issue. Previous run (5)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR change with no code or protected paths, elevated to moderate risk by medium blast radius, multi-author contention and change coupling on the modified ADR, and an aging linked issue. Previous run (6)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR change with no code or protected paths, elevated to moderate risk by medium blast radius, multi-author contention and change coupling on the modified ADR, and an aging linked issue. Previous run (7)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR change with no code or protected paths, elevated to moderate risk by medium blast radius, multi-author contention and change coupling on the modified ADR, and an aging linked issue. |
|
Looks good to me Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMS1zdGVlcmluZy1vbi1ieS1kZWZhdWx0Lm1kIiwiaWQiOiJmX2Y0NjQ3MTI3YWE5MGYzZDQiLCJsaW5lIjo0MywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl8yNDk4YzdhMDE3MzY1ZjgwIiwibGluZSI6NDA1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfMzMxZmI2ZDI5ZDVkYThhMSIsImxpbmUiOjI3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsImxpbmUiOjk3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfZjQ2NDcxMjdhYTkwZjNkNCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzI0OThjN2EwMTczNjVmODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zMzFmYjZkMjlkNWRhOGExIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> Looks good to me Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMS1zdGVlcmluZy1vbi1ieS1kZWZhdWx0Lm1kIiwiaWQiOiJmX2Y0NjQ3MTI3YWE5MGYzZDQiLCJsaW5lIjo0MywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl8yNDk4YzdhMDE3MzY1ZjgwIiwibGluZSI6NDA1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfMzMxZmI2ZDI5ZDVkYThhMSIsImxpbmUiOjI3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsImxpbmUiOjk3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfZjQ2NDcxMjdhYTkwZjNkNCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzI0OThjN2EwMTczNjVmODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zMzFmYjZkMjlkNWRhOGExIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> Looks good to me Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMS1zdGVlcmluZy1vbi1ieS1kZWZhdWx0Lm1kIiwiaWQiOiJmX2Y0NjQ3MTI3YWE5MGYzZDQiLCJsaW5lIjo0MywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl8yNDk4YzdhMDE3MzY1ZjgwIiwibGluZSI6NDA1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfMzMxZmI2ZDI5ZDVkYThhMSIsImxpbmUiOjI3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsImxpbmUiOjk3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfZjQ2NDcxMjdhYTkwZjNkNCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzI0OThjN2EwMTczNjVmODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zMzFmYjZkMjlkNWRhOGExIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> Looks good to me Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMS1zdGVlcmluZy1vbi1ieS1kZWZhdWx0Lm1kIiwiaWQiOiJmX2Y0NjQ3MTI3YWE5MGYzZDQiLCJsaW5lIjo0MywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl8yNDk4YzdhMDE3MzY1ZjgwIiwibGluZSI6NDA1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfMzMxZmI2ZDI5ZDVkYThhMSIsImxpbmUiOjI3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsImxpbmUiOjk3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfZjQ2NDcxMjdhYTkwZjNkNCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzI0OThjN2EwMTczNjVmODAiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zMzFmYjZkMjlkNWRhOGExIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> Looks good to me Previous run (5)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJkb2NzL0FEUnMvMDEyMS1zdGVlcmluZy1vbi1ieS1kZWZhdWx0Lm1kIiwiaWQiOiJmX2Y0NjQ3MTI3YWE5MGYzZDQiLCJsaW5lIjo0MywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2FyY2hpdGVjdHVyZS5tZCIsImlkIjoiZl8yNDk4YzdhMDE3MzY1ZjgwIiwibGluZSI6NDA1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfMzMxZmI2ZDI5ZDVkYThhMSIsImxpbmUiOjI3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsImxpbmUiOjk3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2Y0NjQ3MTI3YWE5MGYzZDQiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8yNDk4YzdhMDE3MzY1ZjgwIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMzMxZmI2ZDI5ZDVkYThhMSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> Looks good to me Earlier findings
Previous run (6)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImF1dGgtYnlwYXNzIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfZTQ1YzBjZDZmNTU3Mjk3YSIsImxpbmUiOjk3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfZjQ2NDcxMjdhYTkwZjNkNCIsImxpbmUiOjQzLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmXzI0OThjN2EwMTczNjVmODAiLCJsaW5lIjo0MDUsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjEtc3RlZXJpbmctb24tYnktZGVmYXVsdC5tZCIsImlkIjoiZl8zMzFmYjZkMjlkNWRhOGExIiwibGluZSI6MjcsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl9mNDY0NzEyN2FhOTBmM2Q0Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMjQ5OGM3YTAxNzM2NWY4MCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzMzMWZiNmQyOWQ1ZGE4YTEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Earlier findings
Next steps:
Previous run (7)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImRvY3MvQURScy8wMTIxLXN0ZWVyaW5nLW9uLWJ5LWRlZmF1bHQubWQiLCJpZCI6ImZfZjQ2NDcxMjdhYTkwZjNkNCIsImxpbmUiOjQzLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmXzI0OThjN2EwMTczNjVmODAiLCJsaW5lIjo0MDUsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxMjEtc3RlZXJpbmctb24tYnktZGVmYXVsdC5tZCIsImlkIjoiZl8zMzFmYjZkMjlkNWRhOGExIiwibGluZSI6MjcsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn1dfQ== --> ReviewFindingsMedium
Low
Labels: ADR documentation change Next steps:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
/fs-fix-stop |
|
Fix agent disabled for this PR. Remove the |
5f6e852 to
ad573ea
Compare
236615d to
29d0ca8
Compare
|
🤖 Finished Review · ✅ Success · Started 2:56 AM UTC · Completed 3:04 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.51 |
Superseded by updated review
29d0ca8 to
e030918
Compare
|
🤖 Finished Review · ✅ Success · Started 3:17 AM UTC · Completed 3:24 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.26 |
Superseded by updated review
Turn steering on by default, with a per-harness and a per-repository opt-out. Assisted-by: Claude (fix), Claude (review) Signed-off-by: Wayne Sun <gsun@redhat.com>
e030918 to
47d9595
Compare
|
🤖 Finished Review · ✅ Success · Started 3:35 AM UTC · Completed 3:42 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.38 |
Superseded by updated review
Summary
ADR 0121 of five that rebuild the steering design (#6957) on the entity ADRs now on
main(0133, 0141, 0144, 0147–0149, 0151). Docs only.Decision: Steering is on by default, with a per-harness and a per-repository opt-out. An explicit
enabled: falseat any layer wins; tuning fields never turn it back on. Also defines themax_steerslimit (default 3, range 1–9999).Steering hands a work-item update to the agent that is still running, so it can adjust before finishing on stale state. After ADR 0144 the next sandbox cycle is the correctness backstop; steering is a fast path inside one cycle.
The series
mainyet are plain text ("ADR 0117 (proposed)") and can become links once they merge.Implementation dependencies
No code here. Implementation lands with or after:
human_min_roleadmission;The runtime interface (0118) and the run-record signal (0119) can be built first; they have no caller until the rest exists.
Lineage
These replace drafts in the earlier steering stack, which predate the entity ADRs.
Never cancelling the in-flight run (#7007) is already ADR 0106's decision, so it needs no new ADR.
Evidence
Current-behaviour claims in ADR 0121, with the code that implements the layers the switches compose across:
LoadWithBaseloads the base chain, merges it into the child, then resolves the child's forge and overlay blocks:internal/harness/compose.go#L179-L197.ForgeConfigtoday has nosteerfield:internal/harness/forge.go#L13-L29.steerfield today.Harness:internal/harness/harness.go#L362-L409.git grep -i steeroverinternal/harnessandinternal/configmatches only unrelated loader-environment comments..fullsend/config.yaml, with an ADR 0069 fallback chain.perRepoConfig:internal/config/config.go#L900-L961.max_steersupper bound of 9999 are defined in steer envelope v1 (proposed in docs(adr): 0117 steer a running cycle with admitted entity updates #9030), not in code.steer: {enabled: false}keeps the ADR 0106 path").Testing
pre-commit run --from-ref origin/main --to-ref HEAD: all hooks pass (ADR status, number and front-matter linters, markdown links, secrets).make lint-md-links: 0 errors.