Skip to content

docs(adr): 0117 steer a running cycle with admitted entity updates - #9030

Open
waynesun09 wants to merge 1 commit into
mainfrom
steer-adr-0119
Open

waynesun09 wants to merge 1 commit into
mainfrom
steer-adr-0119

Conversation

@waynesun09

@waynesun09 waynesun09 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Reading order: this PR (ADR 0117) is the first of five; read it first. PR numbers do not follow ADR numbers, because the ADRs were renumbered into dependency order. Next: #9028 (0118) → #9029 (0119) → #9031 (0120) → #9032 (0121).

Summary

ADR 0117 of five that rebuild the steering design (#6957) on the entity ADRs now on main (0133, 0141, 0144, 0147–0149, 0151). Docs only.

Decision: A running sandbox cycle may take in freshly admitted, filtered entity records as a fast path; the next ADR 0144 cycle stays the backstop. Each release to the model gets a fresh per-record check at the cycle's snapshot threshold (bots: ADR 0107 bot_role). A steer never consumes the pending execution and never changes the cycle's result revision. Also adds the steer-envelope v1 specification.

Steering hands a work-item update to the agent that is still running, so it can adjust before finishing on stale state. After ADR 0144 the next sandbox cycle is the correctness backstop; steering is a fast path inside one cycle.

The series

ADR Title PR
0117 Steer a running cycle with admitted entity updates this PR
0118 Steer runtime interface #9028
0119 Signal GitHub Actions events to a running cycle #9029
0120 Record absorbed steers as agent-run receipts #9031
0121 Steering on by default #9032
  • Merge order: 0117 → 0118 → 0119 → 0120 → 0121. Numbers follow dependency: each ADR cites only lower-numbered ones. Each PR passes the docs checks on its own; links to siblings that are not on main yet are plain text ("ADR 0117 (proposed)") and can become links once they merge.
  • Accepted ADRs touched: Status note on ADR 0141: partially superseded on the steer path only, for host-side re-fetch of newer revisions of snapshot kinds during a cycle and for steer output listed in its own manifest.

Implementation dependencies

No code here. Implementation lands with or after:

  • ADR 0151 human_min_role admission;
  • the ADR 0141 filter pipeline and host-side extension path;
  • the ADR 0144 bound-run lifecycle;
  • entity-context-snapshot v2 for the receipt fields (ADR 0120).

The runtime interface (0118) and the run-record signal (0119) can be built first; they have no caller until the rest exists.

Lineage

These replace drafts in the earlier steering stack, which predate the entity ADRs.

Never cancelling the in-flight run (#7007) is already ADR 0106's decision, so it needs no new ADR.

Evidence

Current-behaviour claims in ADR 0117 and steer envelope v1, with the code or merged contract that holds them:

Testing

  • pre-commit run --from-ref origin/main --to-ref HEAD: all hooks pass (ADR status, number and front-matter linters, markdown links, secrets).
  • make lint-md-links: 0 errors.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Document admitted entity updates for running-cycle steering

📝 Documentation 🕐 40+ Minutes

Grey Divider

AI Description

• Adopt steering as an optional fast path for updating a running sandbox with admitted entity
 records.
• Preserve the pending follow-up cycle and its original verified result revision.
• Specify the steer envelope and clarify its scoped exception to snapshot staging rules.
Diagram

graph TD
  N["Cycle notification"] --> G{"Steer eligible?"} -->|Yes| H["Host fetch"] --> F["Filter records"] --> A["Fresh admission"] --> S["Steer files and envelope"] --> R["Running agent"] --> B["Follow-up cycle"]
  G -->|No| B
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Rely on follow-up cycles alone
  • ➕ Avoids an in-cycle delivery and admission path.
  • ➖ The running agent can finish and post work based on stale state.
2. Have the agent re-check before finishing
  • ➕ Avoids a host-to-sandbox steer contract.
  • ➖ Requires sandbox-side forge reads that ADR 0141 denies.
  • ➖ Does not redirect the agent before it spends the stale turn.

Recommendation: The proposed host-mediated steer is the better fast path: it can reach the running agent without granting sandbox forge access, while fresh per-record admission and the retained follow-up cycle protect the existing security and correctness boundaries.

Files changed (4) +420 / -0

Documentation (4) +420 / -0
0119-steer-a-running-cycle-with-admitted-entity-updates.mdAdopt admitted steering within a running cycle +175/-0

Adopt admitted steering within a running cycle

• Defines when steering is attempted, how records are fetched, filtered, and freshly admitted, and why steering cannot consume pending work or alter the cycle's result revision. Documents implementation dependencies, supported forge scope, and the unresolved provisioning requirement for a moved head.

docs/ADRs/0119-steer-a-running-cycle-with-admitted-entity-updates.md

0141-deterministic-filtered-entity-context-staging.mdClarify the snapshot ADR's steer-path exception +5/-0

Clarify the snapshot ADR's steer-path exception

• Notes that ADR 0119 permits host-side re-fetch of newer snapshot-kind revisions during a cycle and lists steer output in a separate manifest.

docs/ADRs/0141-deterministic-filtered-entity-context-staging.md

architecture.mdSummarize steering in the target architecture +12/-0

Summarize steering in the target architecture

• Adds the intended running-cycle steering behavior, its follow-up-cycle backstop, implementation prerequisites, and GitHub Actions change signal.

docs/architecture.md

README.mdSpecify the steer-envelope v1 contract +228/-0

Specify the steer-envelope v1 contract

• Defines immutable steer directories, canonical manifests, filtered record files, permissions, cleanup, and the agent-facing envelope. Specifies release checks, message safety rules, versioning boundaries, and open schema questions.

docs/normative/steer-envelope/v1/README.md

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can copy the agent prompt from any finding and feed it to your IDE agent

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:59 PM UTC · Completed 7:21 PM UTC

Commit: 6e5115e · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.89

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://cf801f65-site.fullsend-ai.workers.dev

Commit: ed82a170dfd0c191146e8300559cfb52e78a2330

@waynesun09

Copy link
Copy Markdown
Member Author

/fs-fix-stop

@github-actions github-actions Bot added the fullsend-no-fix Skip bot-triggered fix agent runs label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Fix agent disabled for this PR. Remove the fullsend-no-fix label or use /fs-fix to re-engage.

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Nov 2, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run (2)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run (3)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run (4)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run (5)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR and normative specification PR with no code or protected path changes, assigned moderate risk due to line volume (598 lines) and high churn on docs/architecture.md.

Previous run (6)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR and normative specification PR with no code or protected path changes, assigned moderate risk due to large line volume (565 lines) and high churn on docs/architecture.md.

Previous run (7)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR and normative specification PR with no code or protected path changes, elevated to moderate risk by large line volume (559 lines) and high churn on docs/architecture.md.

Previous run (8)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run (9)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run (10)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run (11)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run (12)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

Previous run (13)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Documentation-only ADR design PR with no protected paths or code changes, evaluated at moderate risk due to high recent commit churn and multi-author contention on touched architecture documentation.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Looks good to me

Earlier findings

  • docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:125, edge-case, resolved_by_change — the steer attempt table was rewritten; the correctness re-review of the head found no remaining defect there.
  • docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:238, sandbox-escape, resolved_by_change — head provisioning now requires freshly created files opened relative to a directory handle without following links, renamed into place, and declines on a symlink or special file.
  • docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:231, sandbox-escape, resolved_by_change — the host writes objects and refs as files instead of running Git inside the sandbox, so no agent-writable Git configuration is used.
Previous run

<!-- fullsend:review-findings-v2:{"version":2,"action":"request-changes","findings":[{"severity":"medium","category":"edge-case","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_8a0465081d476a60","line":125,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"sandbox-escape","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_a676929e8b435b2a","line":238,"actionable":true,"dimension":"security"},{"severity":"medium","category":"sandbox-escape","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_112990fc49834e61","line":231,"actionable":true,"dimension":"security"},{"severity":"info","category":"incomplete-doc","file":"docs/normative/prescript-output/v1/README.md","id":"f_d6355fa66bc79c19","line":120,"actionable":false,"dimension":"docs-currency"},{"severity":"medium","category":"edge-case","file":"docs/ADRs/0119-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_bfcd569ca7802a4b","line":87,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"api-contract","file":"docs/ADRs/0119-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_d082ffad176b630a","line":112,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_634835def6a0806e","line":91,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"backward-incompatible","file":"docs/normative/steer-envelope/v1/README.md","id":"f_ad3880c32822edcc","line":107,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"low","category":"breaking-schema","file":"docs/normative/steer-envelope/v1/README.md","id":"f_e13e2b6574962b4c","line":86,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"low","category":"breaking-schema","file":"docs/normative/steer-envelope/v1/README.md","id":"f_bf907f02eefbd5cc","line":35,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"low","category":"breaking-schema","file":"docs/normative/steer-envelope/v1/README.md","id":"f_e15d6721cb8eeb77","line":110,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"medium","category":"auth-bypass","file":"docs/ADRs/0119-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_6cde263a95125622","line":115,"actionable":true,"dimension":"security"},{"severity":"low","category":"backward-incompatible","file":"docs/ADRs/0141-deterministic-filtered-entity-context-staging.md","id":"f_89983ae211419818","line":30,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"medium","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_756ed9d6f0827f83","line":67,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"medium","category":"api-contract","file":"docs/ADRs/0119-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_566d86d1a8c56dd9","line":114,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"edge-case","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_3948056bf354cc2e","line":117,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"architectural-conflict","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_ac71c256caafdee2","line":201,"actionable":false,"dimension":"intent-coherence"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_6e9628ab11f59e2d","line":104,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_891fa4c0494b9352","line":218,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_c3ceeb4994d96847","line":218,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_5a737fc2bb11d66f","line":327,"actionable":false,"dimension":"correctness"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_45ba7e7ffc5e514a","line":218,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_40b69ff078584492","line":218,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"architectural-conflict","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_17682ec253367d67","line":219,"actionable":false,"dimension":"intent-coherence"},{"severity":"low","category":"architectural-conflict","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_04b53394073d7cd9","line":208,"actionable":false,"dimension":"intent-coherence"},{"severity":"info","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_13c5d279b4f583b7","line":333,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_761262a5a5a2a1fb","line":309,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_b5630cdc591ca59c","line":309,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_60878de11b90a440","line":309,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_b9bf29a13a1ff0f5","line":309,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_c6eac573711194d9","line":110,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_645a93d5dfa65d26","line":291,"actionable":false,"dimension":"style-conventions"},{"severity":"info","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_6bdec71691714cd8","line":106,"actionable":false,"dimension":"style-conventions"},{"severity":"medium","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_c4c0ecd1f58ab08c","line":92,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_6a11fbc45be8730d","line":109,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_790d8b1babda5565","line":107,"actionable":false,"dimension":"style-conventions"},{"severity":"medium","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_1c1cbebf98a7560d","line":98,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"logic-error","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_1b8ce18ce166e442","line":259,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_1952bd1af8d52760","line":267,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_38a2171318f01ff1","line":145,"actionable":false,"dimension":"style-conventions"},{"severity":"medium","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_47761c3cdb08385f","line":97,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_4127612094ad6868","line":147,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_868bbd3f306ada49","line":147,"actionable":false,"dimension":"style-conventions"},{"severity":"info","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_63b08154a47baa30","line":187,"actionable":false,"dimension":"style-conventions"},{"severity":"info","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_fab2810a5ed9c33b","line":152,"actionable":false,"dimension":"style-conventions"},{"severity":"info","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_421ee70862ab7963","line":219,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_e591b214368dcffb","line":152,"actionable":false,"dimension":"style-conventions"},{"severity":"medium","category":"edge-case","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_0ea5cf24d8c44748","line":241,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"backward-incompatible","file":"docs/normative/steer-envelope/v1/README.md","id":"f_7b4d438d9ca8bdbb","line":101,"actionable":true,"dimension":"cross-repo-contracts"}],"dispositions":[{"id":"f_0ea5cf24d8c44748","status":"resolved_by_change"},{"id":"f_112990fc49834e61","status":"open"},{"id":"f_7b4d438d9ca8bdbb","status":"resolved_by_change"},{"id":"f_d6355fa66bc79c19","status":"open"},{"id":"f_bfcd569ca7802a4b","status":"resolved_by_change"},{"id":"f_d082ffad176b630a","status":"resolved_by_change"},{"id":"f_634835def6a0806e","status":"resolved_by_change"},{"id":"f_ad3880c32822edcc","status":"resolved_by_change"},{"id":"f_e13e2b6574962b4c","status":"resolved_by_change"},{"id":"f_bf907f02eefbd5cc","status":"resolved_by_change"},{"id":"f_e15d6721cb8eeb77","status":"resolved_by_change"},{"id":"f_6cde263a95125622","status":"resolved_by_change"},{"id":"f_89983ae211419818","status":"resolved_by_change"},{"id":"f_756ed9d6f0827f83","status":"resolved_by_change"},{"id":"f_566d86d1a8c56dd9","status":"resolved_by_change"},{"id":"f_3948056bf354cc2e","status":"resolved_by_change"},{"id":"f_ac71c256caafdee2","status":"resolved_by_change"},{"id":"f_6e9628ab11f59e2d","status":"resolved_by_change"},{"id":"f_891fa4c0494b9352","status":"resolved_by_change"},{"id":"f_c3ceeb4994d96847","status":"resolved_by_change"},{"id":"f_5a737fc2bb11d66f","status":"resolved_by_change"},{"id":"f_45ba7e7ffc5e514a","status":"resolved_by_change"},{"id":"f_40b69ff078584492","status":"resolved_by_change"},{"id":"f_17682ec253367d67","status":"resolved_by_change"},{"id":"f_04b53394073d7cd9","status":"resolved_by_change"},{"id":"f_13c5d279b4f583b7","status":"resolved_by_change"},{"id":"f_761262a5a5a2a1fb","status":"resolved_by_change"},{"id":"f_b5630cdc591ca59c","status":"resolved_by_change"},{"id":"f_60878de11b90a440","status":"resolved_by_change"},{"id":"f_b9bf29a13a1ff0f5","status":"resolved_by_change"},{"id":"f_c6eac573711194d9","status":"resolved_by_change"},{"id":"f_645a93d5dfa65d26","status":"resolved_by_change"},{"id":"f_6bdec71691714cd8","status":"resolved_by_change"},{"id":"f_c4c0ecd1f58ab08c","status":"resolved_by_change"},{"id":"f_6a11fbc45be8730d","status":"resolved_by_change"},{"id":"f_790d8b1babda5565","status":"resolved_by_change"},{"id":"f_1c1cbebf98a7560d","status":"resolved_by_change"},{"id":"f_1b8ce18ce166e442","status":"resolved_by_change"},{"id":"f_1952bd1af8d52760","status":"resolved_by_change"},{"id":"f_38a2171318f01ff1","status":"resolved_by_change"},{"id":"f_47761c3cdb08385f","status":"resolved_by_change"},{"id":"f_4127612094ad6868","status":"resolved_by_change"},{"id":"f_868bbd3f306ada49","status":"resolved_by_change"},{"id":"f_63b08154a47baa30","status":"resolved_by_change"},{"id":"f_fab2810a5ed9c33b","status":"resolved_by_change"},{"id":"f_421ee70862ab7963","status":"resolved_by_change"},{"id":"f_e591b214368dcffb","status":"resolved_by_change"}]} -->

Review

Findings

Medium

  • [edge-case] docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:125 — Acquisition and cumulative-state assembly do not define how to handle deletion of a record the agent already holds. If a maintainer deletes a previously admitted instruction and posts a replacement comment, the replacement can be steered while the deleted instruction stays in the snapshot/steer chain. The envelope has no tombstones, and the whole-steer refusal rule covers only rejected newer revisions, so the pre-script gate's "cumulative current state" can still contain withdrawn instructions.
    Remediation: Define deletion detection for previously delivered record keys and decline the whole steer when one is seen, leaving reconciliation to the follow-up cycle; or specify tombstones and how cumulative-state consumers interpret them.
  • [sandbox-escape] docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:238 — The head-install contract refuses symlinks and special files, but it accepts any existing regular file in a repository the agent can modify. A hard link is a regular file, so an agent-planted hard link at an object or ref destination would pass, and an in-place overwrite would also modify the alias outside the repository path. The contract never requires replacing destinations with fresh inodes.
    Remediation: Require object and ref writes to use exclusively created fresh files in securely held directories, and to replace destination directory entries atomically instead of modifying existing inodes in place. Cover hard-linked destinations and concurrent agent filesystem mutations in the contract and its implementation tests.

Earlier findings

  • docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:241, edge-case — resolved: the working-tree table (lines 245-246) now defines read-only and writable tree handling.
  • docs/normative/steer-envelope/v1/README.md:101, backward-incompatible — resolved: the spec states the .keys variant and the order_path exception explicitly (lines 101-111).

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (2)

<!-- fullsend:review-findings-v2:{"version":2,"action":"request-changes","findings":[{"severity":"medium","category":"edge-case","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_0ea5cf24d8c44748","line":241,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"sandbox-escape","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_112990fc49834e61","line":231,"actionable":true,"dimension":"security"},{"severity":"low","category":"backward-incompatible","file":"docs/normative/steer-envelope/v1/README.md","id":"f_7b4d438d9ca8bdbb","line":101,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"info","category":"incomplete-doc","file":"docs/normative/prescript-output/v1/README.md","id":"f_d6355fa66bc79c19","line":120,"actionable":false,"dimension":"docs-currency"},{"severity":"medium","category":"edge-case","file":"docs/ADRs/0119-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_bfcd569ca7802a4b","line":87,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"api-contract","file":"docs/ADRs/0119-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_d082ffad176b630a","line":112,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_634835def6a0806e","line":91,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"backward-incompatible","file":"docs/normative/steer-envelope/v1/README.md","id":"f_ad3880c32822edcc","line":107,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"low","category":"breaking-schema","file":"docs/normative/steer-envelope/v1/README.md","id":"f_e13e2b6574962b4c","line":86,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"low","category":"breaking-schema","file":"docs/normative/steer-envelope/v1/README.md","id":"f_bf907f02eefbd5cc","line":35,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"low","category":"breaking-schema","file":"docs/normative/steer-envelope/v1/README.md","id":"f_e15d6721cb8eeb77","line":110,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"medium","category":"auth-bypass","file":"docs/ADRs/0119-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_6cde263a95125622","line":115,"actionable":true,"dimension":"security"},{"severity":"low","category":"backward-incompatible","file":"docs/ADRs/0141-deterministic-filtered-entity-context-staging.md","id":"f_89983ae211419818","line":30,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"medium","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_756ed9d6f0827f83","line":67,"actionable":true,"dimension":"cross-repo-contracts"},{"severity":"medium","category":"api-contract","file":"docs/ADRs/0119-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_566d86d1a8c56dd9","line":114,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"edge-case","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_3948056bf354cc2e","line":117,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"architectural-conflict","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_ac71c256caafdee2","line":201,"actionable":false,"dimension":"intent-coherence"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_6e9628ab11f59e2d","line":104,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_891fa4c0494b9352","line":218,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_c3ceeb4994d96847","line":218,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_5a737fc2bb11d66f","line":327,"actionable":false,"dimension":"correctness"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_45ba7e7ffc5e514a","line":218,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_40b69ff078584492","line":218,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"architectural-conflict","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_17682ec253367d67","line":219,"actionable":false,"dimension":"intent-coherence"},{"severity":"low","category":"architectural-conflict","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_04b53394073d7cd9","line":208,"actionable":false,"dimension":"intent-coherence"},{"severity":"info","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_13c5d279b4f583b7","line":333,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_761262a5a5a2a1fb","line":309,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_b5630cdc591ca59c","line":309,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_60878de11b90a440","line":309,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"missing-version-bump","file":"docs/normative/steer-envelope/v1/README.md","id":"f_b9bf29a13a1ff0f5","line":309,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_c6eac573711194d9","line":110,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_645a93d5dfa65d26","line":291,"actionable":false,"dimension":"style-conventions"},{"severity":"info","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_6bdec71691714cd8","line":106,"actionable":false,"dimension":"style-conventions"},{"severity":"medium","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_c4c0ecd1f58ab08c","line":92,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_6a11fbc45be8730d","line":109,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_790d8b1babda5565","line":107,"actionable":false,"dimension":"style-conventions"},{"severity":"medium","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_1c1cbebf98a7560d","line":98,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"logic-error","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_1b8ce18ce166e442","line":259,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"doc-style","file":"docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md","id":"f_1952bd1af8d52760","line":267,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_38a2171318f01ff1","line":145,"actionable":false,"dimension":"style-conventions"},{"severity":"medium","category":"api-contract","file":"docs/normative/steer-envelope/v1/README.md","id":"f_47761c3cdb08385f","line":97,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_4127612094ad6868","line":147,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_868bbd3f306ada49","line":147,"actionable":false,"dimension":"style-conventions"},{"severity":"info","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_63b08154a47baa30","line":187,"actionable":false,"dimension":"style-conventions"},{"severity":"info","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_fab2810a5ed9c33b","line":152,"actionable":false,"dimension":"style-conventions"},{"severity":"info","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_421ee70862ab7963","line":219,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"docs/normative/steer-envelope/v1/README.md","id":"f_e591b214368dcffb","line":152,"actionable":false,"dimension":"style-conventions"}],"dispositions":[{"id":"f_1c1cbebf98a7560d","status":"resolved_by_change"},{"id":"f_1b8ce18ce166e442","status":"resolved_by_change"},{"id":"f_1952bd1af8d52760","status":"resolved_by_change"},{"id":"f_38a2171318f01ff1","status":"resolved_by_change"},{"id":"f_47761c3cdb08385f","status":"resolved_by_change"},{"id":"f_4127612094ad6868","status":"resolved_by_change"},{"id":"f_868bbd3f306ada49","status":"resolved_by_change"},{"id":"f_d6355fa66bc79c19","status":"open"},{"id":"f_63b08154a47baa30","status":"resolved_by_change"},{"id":"f_fab2810a5ed9c33b","status":"resolved_by_change"},{"id":"f_421ee70862ab7963","status":"resolved_by_change"},{"id":"f_e591b214368dcffb","status":"resolved_by_change"},{"id":"f_bfcd569ca7802a4b","status":"resolved_by_change"},{"id":"f_d082ffad176b630a","status":"resolved_by_change"},{"id":"f_634835def6a0806e","status":"resolved_by_change"},{"id":"f_ad3880c32822edcc","status":"resolved_by_change"},{"id":"f_e13e2b6574962b4c","status":"resolved_by_change"},{"id":"f_bf907f02eefbd5cc","status":"resolved_by_change"},{"id":"f_e15d6721cb8eeb77","status":"resolved_by_change"},{"id":"f_6cde263a95125622","status":"resolved_by_change"},{"id":"f_89983ae211419818","status":"resolved_by_change"},{"id":"f_756ed9d6f0827f83","status":"resolved_by_change"},{"id":"f_566d86d1a8c56dd9","status":"resolved_by_change"},{"id":"f_3948056bf354cc2e","status":"resolved_by_change"},{"id":"f_ac71c256caafdee2","status":"resolved_by_change"},{"id":"f_6e9628ab11f59e2d","status":"resolved_by_change"},{"id":"f_891fa4c0494b9352","status":"resolved_by_change"},{"id":"f_c3ceeb4994d96847","status":"resolved_by_change"},{"id":"f_5a737fc2bb11d66f","status":"resolved_by_change"},{"id":"f_45ba7e7ffc5e514a","status":"resolved_by_change"},{"id":"f_40b69ff078584492","status":"resolved_by_change"},{"id":"f_17682ec253367d67","status":"resolved_by_change"},{"id":"f_04b53394073d7cd9","status":"resolved_by_change"},{"id":"f_13c5d279b4f583b7","status":"resolved_by_change"},{"id":"f_761262a5a5a2a1fb","status":"resolved_by_change"},{"id":"f_b5630cdc591ca59c","status":"resolved_by_change"},{"id":"f_60878de11b90a440","status":"resolved_by_change"},{"id":"f_b9bf29a13a1ff0f5","status":"resolved_by_change"},{"id":"f_c6eac573711194d9","status":"resolved_by_change"},{"id":"f_645a93d5dfa65d26","status":"resolved_by_change"},{"id":"f_6bdec71691714cd8","status":"resolved_by_change"},{"id":"f_c4c0ecd1f58ab08c","status":"resolved_by_change"},{"id":"f_6a11fbc45be8730d","status":"resolved_by_change"},{"id":"f_790d8b1babda5565","status":"resolved_by_change"}]} -->

Review

Findings

Medium

  • [edge-case] docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:241 — The host replaces the read-only working tree, HEAD, and index while the sandbox is still running, but the contract only specifies a sandbox write lock. It never requires running tools or repository readers to participate in that lock, so an active grep, test, or multi-file read can observe revision A files combined with revision B index/tree state.
    Remediation: Require a runtime quiescence barrier that drains active repository tools and blocks new reads during installation, or expose immutable per-revision checkouts and switch at a defined turn boundary. Make this an eligibility dependency for read-only head steers.
  • [sandbox-escape] docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:231 — Head installation writes Git objects and refs as privileged host writes into a repository the running agent may modify, but the ADR does not require safe destination resolution. The symlink-rejection rule in the envelope spec covers the steer-directory upload only, not the object directory, refs/fullsend/head, or refs/fullsend/base, so a compromised agent could redirect the trusted writer outside the intended paths.
    Remediation: Require confined, descriptor-relative, no-follow writes for every Git object and ref destination, rejecting symlinks and special files throughout the path. Specify that the write lock prevents agent-side filesystem mutation during installation, or require an equivalent race-resistant mechanism.

Low

  • [backward-incompatible] docs/normative/steer-envelope/v1/README.md:101 — The steer relations/reviews.json, state/threads.json and state/actors.json reuse the entity-context-snapshot v1 schemas but hold only subsets of reviews and threads. The spec does not say whether snapshot v1 validation (referential-integrity or closed-set checks that expect every referenced record in the same directory) applies to these subset copies, so a snapshot-v1 validator in a cross-repo consumer could reject valid steer files.
    Remediation: State that steer relation files are validated by the snapshot v1 JSON schemas and that cross-file referential checks resolve by record key across the steer chain rather than within the steer directory. Alternatively, give the steer order file a distinct extension such as .keys.

Earlier findings

  • docs/normative/steer-envelope/v1/README.md:97, api-contract, resolved — the head defines review relation files and key-based resolution across the chain (README lines 85–106).
  • docs/normative/steer-envelope/v1/README.md:98, api-contract, resolved — correctness re-checked the head and found no remaining defect.
  • docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:259, logic-error, resolved — the result-revision table and the no-approval-on-steered-head rule now define the fail-closed cases (ADR lines 250–270).
  • docs/ADRs/0117-steer-a-running-cycle-with-admitted-entity-updates.md:267, doc-style, resolved — style re-check of the head found no defect.
  • docs/normative/steer-envelope/v1/README.md:145, :147 (two), :152 (two), :187, :219, pattern-inconsistency, resolved — style re-check of the head found no remaining defect.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ⚠️ Cancelled · Started 7:27 PM UTC · Completed 7:36 PM UTC

Commit: 1b8be4b · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.42

This review was superseded by a newer commit. Check the current pull request HEAD's review status before merging.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:35 AM UTC · Completed 1:55 AM UTC

Commit: 77472d8 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.42

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:10 AM UTC · Completed 2:26 AM UTC

Commit: 41604cf · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.93

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Nov 3, 2026
fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:55 AM UTC · Completed 3:08 AM UTC

Commit: e727a28 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.80

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:17 AM UTC · Completed 3:31 AM UTC

Commit: 29e6a23 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.80

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:36 AM UTC · Completed 4:01 AM UTC

Commit: b8fc919 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.78

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 4:07 AM UTC · Completed 4:21 AM UTC

Commit: e644b26 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.55

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

Copy link
Copy Markdown

🤖 Review · ⚠️ Cancelled · Ended 4:38 AM UTC

Commit: 1a2f29d · View workflow run →

This review was superseded by a newer commit. Check the current pull request HEAD's review status before merging.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 4:40 AM UTC · Completed 4:50 AM UTC

Commit: 8f60f3b · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.15

fullsend-ai-review[bot]

This comment was marked as outdated.

A running cycle may take freshly admitted, filtered entity records as steers.

Assisted-by: Claude (fix), Claude (review)
Signed-off-by: Wayne Sun <gsun@redhat.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:10 AM UTC · Completed 5:19 AM UTC

Commit: ed82a17 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.89

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — ed82a170 Deployed Nov 3, 2026 by github-actions[bot]
dev — ed82a170 Deployed Nov 3, 2026 by waynesun09 via behaviour #18705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/docs User-facing documentation fullsend-no-fix Skip bot-triggered fix agent runs ready-for-merge All reviewers approved — ready to merge risk/moderate PR risk: moderate type/adr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant