[saphid]

In the plain-Markdown composer (rich text disabled), inserting an item in a numbered list left duplicate numbers below it. The helper now renumbers following siblings at the same indentation and delimiter, preserving nested content, chips and explicit zero padding. An explicit caret offset keeps typing in the newly inserted item.

Rebuilt from @saphid's contribution in #14332, preserving the author commits and merging current main. The implementation uses one chip parse and a forward scan. The PR's nine added test cases became six focused regressions in the existing file: 25 total tests before, 22 after; all six fail against main and pass with the fix.

Verification at 982459bb7c: 156 tests across list continuation, composer mentions and composer logic; changed-file lint; web package typecheck. Real isolated Linux web app: Shift+Enter on main produced 1, 2, 2, 3; the rebuilt head produced 1, 2, 3, 4, and typing X entered the new item. Browser fixtures used synthetic draft text. The fontless browser host required DejaVu fonts loaded identically for both captures.

Before — main, duplicate numbers:

After — rebuilt head, following items renumbered:

Recording: insert an item and type at the retained caret.

Native macOS, Windows, iOS, Android and Electron desktop were not exercised. Web and desktop share this composer; native mobile does not use this helper. Rich-text list handling and the separate list-marker defect remain outside this fix.

Implementation: GPT-6.1 Sol; tests: GPT-6 Astra; independent reviews: Claude Opus 5.5 and GPT-6 Sol. Codex and Claude harnesses through T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 982459b

Macroscope's review found this PR approvable — This is a contained web composer bug fix that renumbers following plain-Markdown list items while preserving nested content, chips, and caret placement. It includes focused regression coverage and does not affect schemas, infrastructure, product defaults, or static-analysis configuration.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6d2c4faf-588f-4d74-b82e-a9e3d99e977a

📥 Commits

Reviewing files that changed from the base of the PR and between 8792f95 and d630285.

📒 Files selected for processing (3)

• apps/web/src/components/chat/ChatComposer.tsx
• apps/web/src/composer-list-continuation.test.ts
• apps/web/src/composer-list-continuation.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

📝 Walkthrough

Walkthrough

Enter continuation can renumber matching ordered-list items below the current item. List edits now return explicit caret offsets, which ChatComposer applies after Enter and Tab edits.

Changes

Composer list editing

Layer / File(s)	Summary
List continuation and edit results apps/web/src/composer-list-continuation.ts, apps/web/src/composer-list-continuation.test.ts	List edits return the caret offset after the edit. Enter continuation can renumber following ordered items with matching indentation and delimiter. The scan accounts for inline chips and stops at blank or nonmatching lines. Tests cover numbering, boundaries, caret placement, and chip offsets.
Apply returned caret offsets apps/web/src/components/chat/ChatComposer.tsx	Enter continuation and Tab indentation use edit.cursorAfter to set the caret.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to d6302

The list-renumbering and caret updates have no identified merge-blocking issue. Mergeable after normal checks; runtime editor interaction was not independently exercised.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to d6302

The change remains within local composer editing. It preserves structured references, existing input restrictions, and submission behavior while correcting numbering and caret placement. No material security risk was identified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The effective changed surface is the current composer prompt and its caret. The inspected path grants no additional service, tenant, tool, credential, or context-payload authority.

Trust Boundaries and Controls

• observed — User-authored prompt text remains input to a local text transformation. Carets inside inline tokens are rejected, multiline-chip interiors are skipped, and intervening chip source is preserved rather than interpreted or rewritten.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the main change: renumbering following items when continuing a plain-Markdown numbered list.
Description check		The description covers the problem, implementation, scope, verification results, screenshots, recording, limitations, and agent disclosure. It provides sufficient detail to support review.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate d630285

[saphid]

Review requested

Date (UTC)	Reviewer	Where
2026-10-03	Julius	Discord DM

_{Logged so this PR shows when a maintainer was asked to review it.}

[saphid]

Review requested

Date (UTC)	Reviewer	Where
2026-10-06	Maria	Discord DM

_{Logged so this PR shows when a maintainer was asked to review it.}

Dismissing prior approval to re-evaluate 0930c8c

Dismissing prior approval to re-evaluate e438bdb

[juliusmarminge]

Taking over this one as maintainer for batch composer-chat-12. I will preserve this PR and its author commits, merge current main, keep the fix scoped to following-item renumbering, and run focused verification and independent reviews.

Dismissing prior approval to re-evaluate 982459b