fix(web): NVDA browse mode reaches the new-thread project picker again

[akj]

The new-thread heading’s explicit aria-label replaces its children in NVDA browse mode, hiding the inline project picker. Remove that label so the picker remains in the heading; keep the visible text and picker behavior unchanged. Closes #17872.

Retains @akj’s focused fix from #17877, merges current main, and shortens the explanation of the NVDA constraint.

Verification:

• 169 existing tests passed across DraftProjectName.logic, draftHeroTransition, ChatView.logic, and environmentGrouping; scoped web typecheck and changed-file lint passed.
• PR tests: 0 → 0. Attribute/static-markup assertions would not prove NVDA browse-buffer behavior.
• Current-head Linux Chromium: the actual main component has an explicit heading label; the head component has none. Visible text is identical, the inline combobox remains a child, and both click and Enter open the project picker. No provider turn was submitted.
• Original author reported NVDA alpha-58022 on Windows 11 reaching the picker in browse mode on the earlier contributor head. That is historical author evidence, not a current-head native run.
• The collaborative browser’s accessibility snapshot omits the project name after label removal; the project remains displayed in the inline picker. The current-head NVDA pass must also confirm the selected project is understandable.
• Still needs current-head NVDA/Windows verification. JAWS, VoiceOver, macOS, Windows runtime, Electron desktop, iOS, and Android were not tested here. The changed component is shared by web and the Electron renderer; native mobile is separate.

These matched Chromium captures show unchanged visuals; they are not screen-reader proof.

Before (main component)	After (head component)

Maintainer takeover: Codex GPT-6.1-Sol in T3 Code; test phase GPT-6-Astra, independent reviews Claude Opus 5.5 and GPT-6-Sol.

[macroscopeapp]

Approvability

Verdict: Approved at 675a0d1

Macroscope's review found this PR approvable — This is a one-file accessibility bug fix that removes an explicit heading label which masked the existing project picker from NVDA browse mode. Visible content and picker behavior remain unchanged, with no product-default, schema, infrastructure, or static-analysis changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 02f905de-8fe3-43fe-bb7e-752f80a76186

📥 Commits

Reviewing files that changed from the base of the PR and between d923bab and 148f91c.

📒 Files selected for processing: 1

• apps/web/src/components/chat/DraftHeroHeadline.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The composer heading no longer has an explicit aria-label. Its accessible name comes from its content, which includes the inline project picker.

Changes: Composer heading

Layer / File(s)	Summary
Derive heading name from content apps/web/src/components/chat/DraftHeroHeadline.tsx	Removed the computed heading label and the <h1>’s explicit aria-label. Added a comment stating that the explicit label hides the inline project picker in NVDA browse mode.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 148f9

The heading keeps meaningful text, and the project picker remains available within it where shown. No actionable merge-blocking risk was found.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Active issue #17872 requires the inline project picker in the new-thread heading to remain available in NVDA browse mode. The change removes the explicit aria-label from the <h1> in `apps/web/src/…
Out of Scope Changes check		The whole-PR diff changes only apps/web/src/components/chat/DraftHeroHeadline.tsx. It removes the computed heading label and adds a comment that documents the NVDA constraint. It does not change the…
Title check		The title clearly and concisely identifies the NVDA browse-mode fix for the new-thread project picker.
Description check		The description explains the problem, the implementation, issue scope, verification results, limitations, and before/after screenshots. It does not use the template's Problem, Change, and Scope and ap…

Full details: Linked Issues check

Explanation

Active issue #17872 requires the inline project picker in the new-thread heading to remain available in NVDA browse mode. The change removes the explicit aria-label from the <h1> in apps/web/src/components/chat/DraftHeroHeadline.tsx. The picker remains a child of the heading. The PR reports that Chrome exposes it as a combobox child and that NVDA browse mode exposes it through heading navigation, quick navigation, and the Elements List. The reported lint and TypeScript checks pass. Closed issue #12396 supplies historical context only.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff changes only apps/web/src/components/chat/DraftHeroHeadline.tsx. It removes the computed heading label and adds a comment that documents the NVDA constraint. It does not change the picker or visible text. These changes directly support #17872, and no unrelated change is demonstrated.

Full details: Description check

Explanation

The description explains the problem, the implementation, issue scope, verification results, limitations, and before/after screenshots. It does not use the template's Problem, Change, and Scope and approval headings, but the required information is present and the description is sufficiently complete.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate d923bab

Dismissing prior approval to re-evaluate 148f91c

[juliusmarminge]

Taking over this one. I will resolve the main conflict, retain the focused accessibility fix, and push to this branch.

Dismissing prior approval to re-evaluate 675a0d1