[saphid]

Going back from a command-palette picker clears the search that opened it. Escape from file or content search also loses the parent palette query. Fixes #15936.

Keep each nested view's parent query with its view stack, and retain the query and linked-thread results while a child search replaces the palette. Back restores that context. Closing, fresh shortcuts and direct intents reset it. Direct-intent resets are centralized so add-project also starts with a clean stack.

Maintainer takeover of @saphid's implementation in #15940. The author's commits are preserved; current main was merged without rebasing or force-pushing. Removed duplicate reset blocks and forwarding helpers. Reduced the existing logic suite from 46 to 40 tests (PR-added cases: 13 to 7).

Verification on f8592d6d20:

• node_modules/.bin/vp test run apps/web/src/components/CommandPalette.logic.test.ts: 40 passed. Disabling restoration causes three behavioral failures; using main's logic also fails the new regression selection.
• Targeted lint, format check, web-package tsc-rs --noEmit, and git diff --check passed.
• Fresh independent full-diff reviews by Claude Opus 5.5 and GPT-6-Sol: no blockers in round 1.
• Real Chromium web client at 1280×800 with isolated worktree state: visible Back and Backspace restore theme; Escape from file search restores go to file; Escape from content search restores >search; close/reopen and a fresh content-search shortcut start clean. No agent turns were sent.

Before, runtime code from 5307c233b1: Back clears the input.

After, the same project, viewport and flow on this head: Back restores theme.

Before recording · After recording: visible Back and Backspace

Limits: linked-thread result restoration and multiple nesting levels were verified by focused tests, not live fixtures. macOS, Windows, iOS, Android and Electron desktop were not exercised. Desktop uses this web component; mobile has its own unchanged palette. No provider, server, wire-contract or connection-mode changes. The live database could not be migrated into this checkout because its migration history differs, so the client used fresh isolated state with a project and thread.

Tests: GPT-6-Astra; implementation: GPT-6.1-Sol; independent reviews: Claude Opus 5.5 and GPT-6-Sol. Integration and publication: GPT-6.1-Sol, Codex harness through T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at f8592d6

Macroscope's review found this PR approvable — This is a localized command-palette bug fix that preserves search context across nested navigation and explicitly resets stale state when starting fresh. The production changes remain self-contained and are accompanied by focused reducer tests, with no schema, infrastructure, security, billing, or static-analysis configuration impact.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: f1a27c86-f4f7-4ed1-a702-52472e69b107

📥 Commits

Reviewing files that changed from the base of the PR and between b0dd057 and f8592d6.

📒 Files selected for processing: 3

• apps/web/src/components/CommandPalette.logic.test.ts
• apps/web/src/components/CommandPalette.logic.ts
• apps/web/src/components/CommandPalette.tsx

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: f003b82a-91d0-4761-aff2-49e69cd5d5c3

📥 Commits

Reviewing files that changed from the base of the PR and between 250e052 and b0dd057.

📒 Files selected for processing (3)

• apps/web/src/components/CommandPalette.logic.test.ts
• apps/web/src/components/CommandPalette.logic.ts
• apps/web/src/components/CommandPalette.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

📝 Walkthrough

Walkthrough

The command palette now preserves search context when opening nested pickers and restores it when returning. Search queries and nested views use a reducer, and the palette passes saved query and linked-thread context to file and content search.

Changes

Command palette search restoration

Layer / File(s)	Summary
Search state and restoration apps/web/src/components/CommandPalette.logic.ts, apps/web/src/components/CommandPalette.logic.test.ts	Search state records parent queries for nested views. Back restores the saved query. UI-state handling also restores saved search context and clears it in the tested close, reopen, fresh-mode, and direct-intent cases.
Palette navigation wiring apps/web/src/components/CommandPalette.tsx	The palette uses the search reducer for view navigation and resets search state for specified intents. Opening file or content search passes the current query and linked-thread context; Back and Escape return through the context-restoration path.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to b0dd0

The change makes Back, the Back button, and Escape restore the previous palette query, and closing or starting a fresh intent still starts clean. No merge-blocking risk is evident. Desktop and real-client content-search restoration were not verified.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		The description links the relevant issue #15936 and explains why this pull request replaces #12873. The linked issue matches the reported behavior and scope.
Out of Scope Changes check		The changes are limited to the web command-palette component, its logic, and focused tests. The description states that mobile remains unchanged and identifies unverified desktop coverage.
Title check		The title clearly and concisely describes the main fix: restoring the search when navigating back in the command palette.
Description check		The description covers the problem, implementation, issue scope, verification results, screenshots, recordings, limitations, and agent attribution. It provides sufficient detail for review and matches…

Full details: Description check

Explanation

The description covers the problem, implementation, issue scope, verification results, screenshots, recordings, limitations, and agent attribution. It provides sufficient detail for review and matches the repository template requirements.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[saphid]

Review requested

Date (UTC)	Reviewer	Where
2026-10-06	Maria	Discord DM

_{Logged so this PR shows when a maintainer was asked to review it.}

Dismissing prior approval to re-evaluate 8087eff

Dismissing prior approval to re-evaluate af778a1

[juliusmarminge]

Taking over this one as maintainer for batch web-misc-07. I will preserve your commits, merge current main, simplify the tests and implementation, and run independent reviews. Nothing will be merged as part of this takeover.

Dismissing prior approval to re-evaluate f8592d6