fix(web): promoting a draft thread no longer logs a React key warning

[yordis]

Problem

ThreadRouteView.tsx passes the ChatView key through a conditional props spread ({...(nextChatViewKey ? { key: nextChatViewKey.key } : {})}). Whenever a draft chat is promoted to a server thread, the spread object has an own key property, and React's dev JSX runtime logs:

A props object containing a "key" prop is being spread into JSX:
  let props = {key: someKey};
  <ChatView {...props} />
React keys must be passed directly to JSX without using spread

This fires on a common flow: sending the first message in a new chat.

Change

Pass the key directly with key={nextChatViewKey?.key}. When there is no promoted key this is key={undefined}, which React treats the same as no key, so remount behavior does not change.

Scope and approval

Very small, focused fix for an obvious bug: a one-line change in one file that removes a React runtime error log without changing behavior.

Verification

• Traced the trigger in the installed react@19.2.6 react-jsx-dev-runtime.development.js: jsxDEV checks hasOwnProperty.call(config, "key") on the spread config and calls console.error with the message above. With a literal key attribute, the compiler passes the key as a separate argument, so the config never carries it.
• Typecheck and lint scoped to apps/web/src/components/ThreadRouteView.tsx are clean.
• Not checked: not observed live in a browser, and no component-render test was added because apps/web has no component-render test harness.

[macroscopeapp]

Approvability

Verdict: Approved at b4b0e2e

Macroscope's review found this PR approvable — This is a one-line, self-contained React warning fix that preserves the existing ChatView key and remount behavior. It introduces no new capability, configuration change, schema impact, or production-side effect.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: cb2cb158-3061-481f-b760-2af548c57c97

📥 Commits

Reviewing files that changed from the base of the PR and between 7379933 and b4b0e2e.

📒 Files selected for processing (1)

• apps/web/src/components/ThreadRouteView.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The server-thread ChatView now receives nextChatViewKey?.key as its key prop. When no key is available, the value is undefined.

Changes

ChatView key prop

Layer / File(s)	Summary
Pass the optional ChatView key apps/web/src/components/ThreadRouteView.tsx	The server-thread ChatView receives nextChatViewKey?.key as its key prop. Previously, the prop was omitted when nextChatViewKey was absent.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to b4b0e

This focused change removes the development warning without introducing an evidenced behavior or merge-blocking risk.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the draft-thread promotion flow and the React key warning fix.
Description check	✅ Passed	The description covers the problem, change, scope rationale, and verification. It reports focused typecheck and lint results and states that browser verification and a component-render test were not p…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}