test(server): the text generation's fake Claude CLI is a fixture file, not a generated string

[yordis]

• Building the fake CLI from an array of quoted strings hides it from the formatter, linter, and editor tooling, so mistakes in it only surface when the test runs.
• Same treatment test(server): the fake Claude CLI is a fixture file, not a generated string #14950 and test(server): the registry's fake Claude CLI is a fixture file, not a generated string #15463 gave the other fake Claude CLIs.

[macroscopeapp]

Approvability

Verdict: Approved at 008132e

Macroscope's review found this PR approvable — This is a narrowly scoped test-harness refactor that moves the fake Claude CLI into a fixture while preserving its test-only execution and behavior. It does not alter product runtime behavior, defaults, schemas, deployment, or static-analysis configuration.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (1)

docs/internals/effect-services.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: bacc2748-c628-46a7-9195-592b7c02f251

📥 Commits

Reviewing files that changed from the base of the PR and between 845ddd9 and 008132e.

📒 Files selected for processing (2)

• apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
• apps/server/src/textGeneration/testing/ClaudeTextGeneration.fixture.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

📝 Walkthrough

Walkthrough

The Claude text-generation test now reads its fake CLI implementation from a separate fixture file. The fixture checks CLI settings and optional environment inputs, then writes configured output and sets the exit code.

Changes

Claude CLI test fixture

Layer / File(s)	Summary
Load and execute the fake CLI fixture apps/server/src/textGeneration/ClaudeTextGeneration.test.ts, apps/server/src/textGeneration/testing/ClaudeTextGeneration.fixture.mjs	The test helper reads the fixture source and passes it to writeFakeCli. The fixture validates CLI settings and optional argument, stdin, and configuration-directory expectations. It writes configured stderr and stdout content and sets the configured exit code.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 00813

The extracted fake CLI fixture is available to the server test; no issue requiring a change before merge was identified.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains why the generated CLI is problematic and references similar changes, but it omits the required Change, Scope and approval, and Verification details.	Add the Problem, Change, Scope and approval, and Verification sections. Describe the expected behavior and how this change addresses the problem. Link the approved issue or discussion, or explain why this focused change does not need prior …
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: moving the fake Claude CLI from a generated string to a fixture file.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Resolution

Add the Problem, Change, Scope and approval, and Verification sections. Describe the expected behavior and how this change addresses the problem. Link the approved issue or discussion, or explain why this focused change does not need prior approval. Report the focused tests run, their results, and anything not checked.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}