test(server): the git-ssh wrapper's fake SSH script is a fixture file, not a generated string

[yordis]

• Building the fake SSH script from an array of quoted strings hides it from editor tooling and shell syntax highlighting, so mistakes in it only surface when the test runs.
• Same treatment test(server): the fake Claude CLI is a fixture file, not a generated string #14950, test(server): the registry's fake Claude CLI is a fixture file, not a generated string #15463, and test(server): the text generation's fake Claude CLI is a fixture file, not a generated string #15479 gave the other fake CLIs.

[macroscopeapp]

Approvability

Verdict: Approved at 5e2cbd9

Macroscope's review found this PR approvable — This is a confined test refactor that moves an unchanged fake SSH script into an executable fixture and updates the integration test to use it. It does not alter product runtime behavior, defaults, schemas, deployment, or static-analysis configuration.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (1)

docs/internals/effect-services.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: c5dacefb-b249-4b7e-a56b-9a6a89051406

📥 Commits

Reviewing files that changed from the base of the PR and between 845ddd9 and 5e2cbd9.

📒 Files selected for processing (2)

• apps/server/src/vcs/GitVcsDriverCore.test.ts
• apps/server/src/vcs/testing/GitVcsDriverCore.fixture.sh

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

---

📝 Walkthrough

Walkthrough

The non-interactive SSH status test now uses a checked-in shell fixture. The fixture records five askpass-related environment variables in a log file and exits with status 1.

Changes

SSH askpass test

Layer / File(s)	Summary
Fixture logging and test wiring apps/server/src/vcs/testing/GitVcsDriverCore.fixture.sh, apps/server/src/vcs/GitVcsDriverCore.test.ts	The fixture logs five askpass-related environment variables. The test uses this fixture instead of creating and making a temporary wrapper script executable.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 5e2cb

The SSH askpass regression test uses an executable checked-in fixture. No issue requiring a fix before merge is established.

Architecture Summary

Architecture risk: 🔵 Low · up to 5e2cb

The change affects 1 system.

Changed systems: apps/server

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — apps/server (service) was modified; 2 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in apps/server/src/vcs/GitVcsDriverCore.test.ts: The test now resolves the SSH wrapper from the adjacent fixture file instead of constructing its path inside the temporary directory.
• observed — Modified behavior in apps/server/src/vcs/GitVcsDriverCore.test.ts: Removed the test setup that wrote the wrapper script’s environment logging commands to disk and changed its permissions to executable; the test uses the fixture path instead.
• observed — Modified behavior in apps/server/src/vcs/testing/GitVcsDriverCore.fixture.sh: The new shell fixture writes GCM_INTERACTIVE, GIT_ASKPASS, GIT_TERMINAL_PROMPT, SSH_ASKPASS, and SSH_ASKPASS_REQUIRE to the configured log file, using empty values when unset, then exits with status 1.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains why the fake SSH script should be a fixture, but it omits the required Problem, Change, Scope and approval, and Verification sections. It does not state test results or explai…	Add the required sections. Describe the expected behavior and the fixture change, explain the scope and why prior approval is not needed (or link the issue or approval), and report the focused tests run and their results.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the change: use a fixture file for the fake SSH script in the Git SSH wrapper test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains why the fake SSH script should be a fixture, but it omits the required Problem, Change, Scope and approval, and Verification sections. It does not state test results or explain why this focused change needs no prior approval.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}