test(server): the ACP registry's fake uv is a fixture file, not a generated string

[yordis]

• Building the fake uv script from an array of quoted strings hides it from editor tooling and shell syntax highlighting, so mistakes in it only surface when the test runs.
• Same treatment test(server): the fake Claude CLI is a fixture file, not a generated string #14950, test(server): the registry's fake Claude CLI is a fixture file, not a generated string #15463, and test(server): the text generation's fake Claude CLI is a fixture file, not a generated string #15479 gave the other fake CLIs.

[macroscopeapp]

Approvability

Verdict: Approved at cb306f0

Macroscope's review found this PR approvable — The PR extracts an existing fake uv test script into a dedicated fixture without changing production code or customer-facing behavior. Its runtime impact is limited to the ACP registry test harness, with no product-default or static-analysis configuration changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (1)

docs/internals/effect-services.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: f56b33bd-f297-4841-9d64-fb7e8628a105

📥 Commits

Reviewing files that changed from the base of the PR and between 845ddd9 and cb306f0.

📒 Files selected for processing (2)

• apps/server/src/provider/acp/AcpRegistrySupport.test.ts
• apps/server/src/provider/acp/testing/AcpRegistrySupport.uv.fixture.sh

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

---

📝 Walkthrough

Walkthrough

The test helper now copies its fake uv executable from a shell fixture instead of assembling the script inline. The fixture handles tool-directory lookup, tool listing, and tool installation.

Changes

Fake uv Toolchain Fixture

Layer / File(s)	Summary
Define and wire the fake uv toolchain apps/server/src/provider/acp/testing/AcpRegistrySupport.uv.fixture.sh, apps/server/src/provider/acp/AcpRegistrySupport.test.ts	The fixture implements the fake uv commands. The test helper copies the fixture to the existing executable path and applies executable permissions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to cb306

This change relocates the fake uv script without changing the tested behavior, so no merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the problem and the change’s motivation, but it does not use the required sections or provide scope approval details or verification results.	Add the required Problem, Change, Scope and approval, and Verification sections. Describe the change, explain why it needs no prior issue or approval if applicable, and report the focused tests or manual checks run and their results.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: moving the ACP registry’s fake uv script into a fixture file. It is specific and relevant, though somewhat long.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}