Skip to content

refactor: prune narration and history comments - #19559

Merged
maria-rcks merged 11 commits into
mainfrom
refactor/prune-comments
Oct 16, 2026
Merged

maria-rcks merged 11 commits into
mainfrom
refactor/prune-comments

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Which version did the judges prefer? With comments 21, without comments 18, no difference 21, out of 60 blind verdicts.

Quality score by judge model, with vs without comments: Claude Opus 5.5 8.0 vs 7.9, GPT-6.1-Sol 8.5 vs 8.7, GPT-6-Astra 8.3 vs 8.5.

Same work, same cost: checks passed 85% vs 95%, tokens 857k vs 844k, files read 7.9 vs 8.1, minutes 3.2 vs 3.0.

Removes comments that repeat the code, document the obvious, or record history, in source and tests. Agents copy these into new files, where they go stale. A comment stays only when someone reading the code would likely break something without it: a security check, a race, a provider or OS quirk, or an invariant another file relies on. Lint directives, knip tags, and suppression reasons stay. Comment lines in the touched files drop from 63,684 to 18,432. Outside the lint rule below, code is unchanged: every pruned file parses to the same syntax tree as main.

A new t3code/no-low-value-comments lint rule keeps the mechanical cases out: section dividers, Arrange/Act/Assert labels, TODOs without an issue link, JSDoc types in TypeScript, empty @param/@returns tags, commented-out code, and comments that only repeat the name below them. AGENTS.md now tells agents that comments say why.

To check the effect on agents, gpt-6.1-sol did the same 10 tasks on main and on an earlier cut of this branch. 6 judges compared each pair without knowing which was which. 21 verdicts favored main, 18 favored the branch, and 21 were ties. Tokens, files read, and time stayed within 6%. The bench has not been rerun on this cut.

Done by claude-opus-5-5 (Claude Code) coordinating gpt-6.1-sol (Codex) subagents.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Oct 14, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 14, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — The PR is largely a mechanical comment cleanup with a development-only lint rule and no apparent product behavior changes. Its mobile fingerprint inputs nevertheless trigger the repository's native-change flow, which can block production OTA delivery until a new store build ships.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 4.9 KiB −30 B (−0.6%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB −30 B (−2.5%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.8 KiB −41 B (−0.2%) 29.3 KiB ✅
Codex Live turn messages 2 1 −1 (−50.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +31 B (+0.6%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +31 B (+2.6%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB +41 B (+0.2%) 29.3 KiB ✅
Claude Live turn messages 1 2 +1 (+100.0%) 8 ✅

Baseline: ba35822 · PR result: 391c8d3 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@maria-rcks
maria-rcks force-pushed the refactor/prune-comments branch from 584e2d7 to c4eb580 Compare October 15, 2026 22:12
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 15, 2026
# Conflicts:
#	apps/mobile/src/components/AppSheet.tsx
#	apps/mobile/src/components/ConfirmDialogHost.tsx
#	apps/mobile/src/components/MaterialRadioIndicator.android.tsx
#	apps/mobile/src/components/MaterialSegmentedButtons.android.tsx
#	apps/mobile/src/components/nativeHeaderMenu.ios.tsx
#	apps/mobile/src/features/pull-requests/MaterialFloatingToolbar.android.tsx
#	packages/source-control-github/src/server/GitHubApi.ts
#	packages/source-control-github/src/server/githubGraphQl.ts
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 15, 2026 23:52

Dismissing prior approval to re-evaluate c0a7aba

@maria-rcks

Copy link
Copy Markdown
Collaborator Author

Note

Written by claude-opus-5-5 on behalf of Maria

The frozen-lockfile change in scripts/setup-worktree.ts comes from main (#19747) via the merge. Against main, this PR only removes the doc comment in that file. Every changed file has the same syntax tree as main once comments are stripped, so this PR changes no runtime code.

Comment thread oxlint-plugin-t3code/rules/no-low-value-comments.ts Outdated
@maria-rcks
maria-rcks merged commit 86534db into main Oct 16, 2026
30 checks passed
@maria-rcks
maria-rcks deleted the refactor/prune-comments branch October 16, 2026 05:37
Ali-Al1 added a commit to Ali-Al1/t3code that referenced this pull request Oct 16, 2026
Resolve maintenanceResolver.ts against pingdotgg#19559's comment pruning: keep
windowsNpmPrefixFromPackagePath with its doc comment, drop the Homebrew and
resolveNpmGlobalPrefix comments upstream removed.
Pho3niX90 added a commit to Pho3niX90/par3 that referenced this pull request Oct 16, 2026
Brings in upstream's launcher-only npm package (#20148): npm now ships a
small launcher that downloads the CLI archive from the GitHub Release. It
is published as @paritylabs/par3 with par3 and p3 commands, downloads from
this fork's releases, and is recognised under that name when the server
runs through npm.

Upstream's comment cleanup (#19559) is taken as is, with Par3 kept in the
comments it rewrote. Fork features, branding and GitHub-hosted runners
stay. The new release step that copies upstream's Play Store APK into
nightly releases runs only in upstream's repository.

Part of #19.
vedprakash2302 added a commit to vedprakash2302/Cody that referenced this pull request Oct 16, 2026
Brings in upstream through pingdotgg#20194 (e3b35d1).

- Comment cleanup (pingdotgg#19559): most of the 38 conflicts were comments upstream removed next to Cody code. Kept Cody's code, took upstream's comment removals.
- Branding (pingdotgg#20032, Alpha to Beta): kept Cody names. A stable build shows "Cody" with no stage label, so the desktop and web checks now look for "Beta" instead of "Alpha".
- Version 0.1.0: Cody nightlies now resolve to 0.1.1-nightly.*, which sorts above 0.0.46, so installed apps still update.
- Composer model switch (pingdotgg#19869): took upstream's rewrite and kept Cody's worktree base reset in onEnvModeChange.
- Mobile scheduled task form: reapplied Cody's thread picker onto upstream's restructured screen (pingdotgg#20043).
- WSL Windows sign-in helper: unaffected by pingdotgg#19966's Windows probe change; its test now uses the new shell environment layer.
- Superseded: none. Adapted: none.
psv2522 added a commit to psv2522/t3code that referenced this pull request Oct 16, 2026
Resolve the single conflict in PullRequestChecksPopover.tsx. Main
pruned comments there (pingdotgg#19559) in the same block this branch fixes
for the checks scrollbar. Keep the scrollbar classes and main's
pruned JSX.

Refs pingdotgg#19404
Jefferson-Butler1 added a commit to Jefferson-Butler1/t3code that referenced this pull request Oct 16, 2026
Upstream's comment cleanup (pingdotgg#19559) rewrote comments that home-agent,
inbox-order and thread-links also edit, so the 2026-10-16 nightly
(v0.1.1-nightly.20261016.3203) stopped at the Home patch. The three
patches are regenerated on that tag. Code is unchanged; comments upstream
removed stay removed.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
gabynevada added a commit to atlitech/t3code that referenced this pull request Oct 16, 2026
Resolutions:
- Comment-only conflicts from upstream's comment pruning (pingdotgg#19559): take
  upstream's deletion; keep a short comment where it documents fork-only
  behavior (tracked commands hold Waiting, PR watch setting, usage-limit
  per provider instance, thread-bound scheduled tasks follow the thread model).
- Mobile: adopt upstream's components/ui moves, NativeThemeHost and AppBar
  types; re-apply the fork's adaptive navigation, thread actions menu and
  scheduled-task "follows thread model" row.
- Server cloud/update: keep both the fork's BootService.stop (t3 recover) and
  upstream's withStopped (t3 doctor); add withStopped to the fork's mocks.
- update.test.ts: upstream moved the server to 0.1.0, so the fork's update
  fixtures target 0.1.x and pre-admission (0.0.46-atli.*) installs need
  --allow-downgrade.
- ci.yml: take upstream's changes-gated jobs; keep the fork's atli triggers and
  GitHub-hosted runners (including the new changes job).
- ThreadPullRequestsPanel: take upstream's virtualized list; keep the fork's
  watch toggle gating and add watchEnabled to the row inputs.
- Effect bumped to 4.0.5: carry the Atom.family bound as
  patches/effect@4.0.5.patch (applies unchanged).
- pnpm-workspace.yaml: keep both sides' patchedDependencies (upstream's bumped
  gesture-handler/keyboard-controller, @expo/ui; fork's image-viewing,
  shiki-engine). pnpm-lock.yaml: upstream's, regenerated with vp i.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rookmate added a commit to rookmate/t3code that referenced this pull request Oct 16, 2026
Resolves conflicts with the comment pruning in pingdotgg#19559: keep this branch's
code and drop the comments main removed. The handoff field on
BootServiceManager keeps its doc comment, since it records why restart
cannot stop and start from inside the unit.

pingdotgg#20148 made resolveCliCommand read the npm launcher's package.json, so
reportServiceOnboarding now needs FileSystem and Path. The pending-outcome
test in connect.test.ts provides NodeServices.layer for them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
msegec added a commit to msegec/t3code_rookie that referenced this pull request Oct 16, 2026
Upstream pingdotgg#19559 pruned the TanStack Router header from routeTree.gen.ts, and
every build writes it back, so the release check saw a modified source tree.
The local build overlay restores the generated header.
sheehanmunim added a commit to munimtechnologies/mtcode that referenced this pull request Oct 17, 2026
Most of the ~130 textual conflicts came from upstream's comment-pruning
refactor (pingdotgg#19559); those hunks keep the fork's code. The rest port fork
features onto upstream's React Compiler conversions (ChatView, ChatComposer,
MessagesTimeline, CommandPalette, ThreadTerminalDrawer, settings panels) and
fix fork code that upstream's strict compiler list and new
no-low-value-comments lint rule now flag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coriou added a commit to Coriou/txcode that referenced this pull request Oct 19, 2026
Upstream removed this comment in pingdotgg#19559; the merge kept it beside the fork's
Reconnecting line. Keep only the fork line (CTO r5 N10).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants