Skip to content

Merge Promotion #2568 Without a Round Stating Coverage of Its Head? #2574

Closed

Description

@ptr727

Question

Promotion #2568, develop into main, is green on its head 3013808d, every thread is resolved, and the headline of its newest Copilot round is answered. pr_review.py still exits 45 (COVERAGE_IS_UNSTATED): neither of the two Copilot rounds since the first states which files it covered or carries a file table, so the loop cannot prove a round read the full diff. Its own remedy text says this is the maintainer's call once the head carries the review instruction files, which develop does. Should #2568 merge as it stands?

What each change on the head was reviewed by

Options

  1. Recommended: merge Promote develop to main: Read Copilot's Overview Sections Through One Recognizer #2568 as it stands. Every file in the diff was covered by a file table on the pull request that brought it to develop, and by recorded local passes. The gap is only that no round on this promotion's own newest head states coverage. Effect on the parked work: the promotion merges, closing Recognize Copilot's Collapsible "N Open Findings" Overview Block in pr_review.py #2480, Recognize Copilot's "Resolved Since Last Review" Overview Block in pr_review.py #2479, pr_review.py Passes a Copilot Round Whose Headline Names Findings Beside a Zero Open-Findings Count #2544, and pr_review.py Has No Reader for Copilot's Review-Overview Format #1723.
  2. Hold Promote develop to main: Read Copilot's Overview Sections Through One Recognizer #2568 until a push to develop gives it a new head, and re-wait for a round that states coverage. A Lite round states coverage or carries a table only by chance, so this may take more than one push. Effect on the parked work: the promotion waits, and anything else merged to develop meanwhile rides along.
  3. Close Promote develop to main: Read Copilot's Overview Sections Through One Recognizer #2568 and promote later as part of a larger promotion. Effect on the parked work: Recognize Copilot's Collapsible "N Open Findings" Overview Block in pr_review.py #2480 and the issues it closes stay open until then.

Belongs to

Activity

  1. added
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Oct 8, 2026
  2. ptr727 commented on Oct 8, 2026

    @ptr727
    OwnerAuthor

    Answered: the maintainer chose option 1. #2568 was merged at head 3013808 (checked live, CLEAN, no unresolved threads) as merge commit 763bf47, closing #2480, #2479, #2544, and #1723.

  3. removed
    decisionA question waiting on the maintainer, alone or beside whatever else the issue carries
    on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions