Repository navigation
Merge Promotion #2568 Without a Round Stating Coverage of Its Head? #2574
Copy link
Copy link
Closed
Description
Question
Promotion #2568, develop into main, is green on its head 3013808d, every thread is resolved, and the headline of its newest Copilot round is answered. pr_review.py still exits 45 (COVERAGE_IS_UNSTATED): neither of the two Copilot rounds since the first states which files it covered or carries a file table, so the loop cannot prove a round read the full diff. Its own remedy text says this is the maintainer's call once the head carries the review instruction files, which develop does. Should #2568 merge as it stands?
What each change on the head was reviewed by
- Read Copilot's Overview Sections Through One Recognizer in pr_review.py #2562, Count an Open (N) Entry Carrying No Thread Link as Unthreaded #2570, and Read Open-Section Thread Ids From Its Entries Alone #2573 each passed recorded local strict-review passes, and their own Copilot rounds covered every file they change by a file table. Their findings were fixed or declined with evidence.
- Judge a Cached Hub Fresh Against the Session's Own Ref in Both Menus #2571, the menus change another lane merged, had one Copilot round on its own pull request whose file table names all three files it changes, with no thread.
- On Promote develop to main: Read Copilot's Overview Sections Through One Recognizer #2568, the first round, on
0b88caa6, carried a table naming every file then in the diff. The two later rounds, one93e4780and3013808d, raised one finding each, both fixed by Count an Open (N) Entry Carrying No Thread Link as Unthreaded #2570 and Read Open-Section Thread Ids From Its Entries Alone #2573, and stated no coverage.
Options
- Recommended: merge Promote develop to main: Read Copilot's Overview Sections Through One Recognizer #2568 as it stands. Every file in the diff was covered by a file table on the pull request that brought it to
develop, and by recorded local passes. The gap is only that no round on this promotion's own newest head states coverage. Effect on the parked work: the promotion merges, closing Recognize Copilot's Collapsible "N Open Findings" Overview Block in pr_review.py #2480, Recognize Copilot's "Resolved Since Last Review" Overview Block in pr_review.py #2479, pr_review.py Passes a Copilot Round Whose Headline Names Findings Beside a Zero Open-Findings Count #2544, and pr_review.py Has No Reader for Copilot's Review-Overview Format #1723. - Hold Promote develop to main: Read Copilot's Overview Sections Through One Recognizer #2568 until a push to
developgives it a new head, and re-wait for a round that states coverage. A Lite round states coverage or carries a table only by chance, so this may take more than one push. Effect on the parked work: the promotion waits, and anything else merged todevelopmeanwhile rides along. - Close Promote develop to main: Read Copilot's Overview Sections Through One Recognizer #2568 and promote later as part of a larger promotion. Effect on the parked work: Recognize Copilot's Collapsible "N Open Findings" Overview Block in pr_review.py #2480 and the issues it closes stay open until then.
Belongs to
- Handoff Session Handoff [auto-2480]: Merge and Promote #2562 per #2564 #2565, track
auto-2480. - Blocks #2568, the open
developtomainpromotion pull request.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity
ptr727 commentedon Oct 8, 2026
Answered: the maintainer chose option 1. #2568 was merged at head 3013808 (checked live, CLEAN, no unresolved threads) as merge commit 763bf47, closing #2480, #2479, #2544, and #1723.