[ptr727]

Splits the 23 over-length comment sentences in lib/sh/secrets.sh so the sentence-length check reads zero. Only comment text changed. No code, string, or behavior changed.

Files: lib/sh/secrets.sh.

Every split was compared with its original sentence for lost antecedents, dropped reasons, narrowed qualifiers, and added claims. Three strict review rounds found drifts, all fixed in later commits, and the latest pass on the final head reported no findings.

Part of #3531.
Resolves #3577 on promotion.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: feature/3577-secrets-sh-sentence-length
• File: .coderabbit.yaml
• Commit: d37da9a
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3c610d53-006c-4905-a148-f3ad19bca93d

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟡 Changes recommended

An active nit remains in lib/sh/secrets.sh at lines 16 and 78 because the placement of “thereby” creates an ambiguous causal link that should be corrected.

1 open issue

• Remove misleading causal connector from shared clause · New

What changed in this PR

This pull request splits 23 over-length comments in lib/sh/secrets.sh into shorter sentences while preserving executable code, strings, and runtime behavior.

Changes:

• Splits long comments covering secret handling, symlink resolution, and environment-file loading.
• Preserves the existing shell implementation and behavior.
• Retains two comment-wording findings regarding causal attribution and API-call subject clarity.

File	Summary
lib/​sh/​secrets.sh	Reviewed comment-only sentence splits throughout the secrets shell library. No executable code or behavior changed; two comment-wording findings remain, with 4 and 1 votes.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.60%. Comparing base (b82a4a0) to head (d37da9a).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3581   +/-   ##
========================================
  Coverage    81.60%   81.60%           
========================================
  Files           26       26           
  Lines         9070     9070           
========================================
  Hits          7402     7402           
  Misses        1668     1668           

Flag	Coverage Δ
python-3.13	81.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🔵 Needs a closer look

An active finding remains in lib/sh/secrets.sh because the rationale comment is a sentence fragment that violates the repository’s one-sentence-per-line rule.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Rewrite rationale as a complete sentence

lib/​sh/​secrets.sh:74

[P2] Make the rationale line a complete sentence

Reported as unresolved rather than as a missing target. is a sentence fragment, so this split still violates the repository's one-sentence-per-line comment rule and leaves the subject of the report implicit. Rewrite it as a complete sentence.

This issue also appears on line 257 of the same file.

1 resolved since last review

• Remove misleading causal connector from shared clause

_{Review effort: Lite}

[ptr727]

The two sentence fragments Copilot flagged (the lines starting "Reported as unresolved" and "A bash of its own") now have explicit subjects as of d37da9a, and the other flagged line 257 sentence is the same fix.

[Copilot]

🟢 Approval recommended

No active review issues remain, and the changes are limited to comment wording without altering executable code or behavior.

No open issues 🎉

_{Review effort: Lite}

[ptr727]

Answering the Copilot finding raised on e827021, which opened no thread:

[P2] Make the rationale line a complete sentence. Reported as unresolved rather than as a missing target. is a sentence fragment, so this split still violates the repository's one-sentence-per-line comment rule and leaves the subject of the report implicit. Rewrite it as a complete sentence.

Fixed in d37da9a. That line and the matching fragment at line 257 now each name their subject. Copilot's round on d37da9a reports no open issue.