Skip to content

Split the Over-Length Sentences in the Release Skills - #3585

Merged
ptr727 merged 7 commits into
developfrom
feature/3531-release-skills-sentence-length
Oct 28, 2026
Merged

ptr727 merged 7 commits into
developfrom
feature/3531-release-skills-sentence-length

Conversation

@ptr727

@ptr727 ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner

What changed

Splits or tightens every sentence over the 25-word cap in the release skills. That includes the two reference files of branching-and-release-model. Each file now reads zero for prose_lint.py --check sentence-length. Each sentence keeps its meaning, conditions, and reasons, including every condition on who authorizes a merge or a release in merge-and-release.

Files

  • .agents/skills/branching-and-release-model/SKILL.md
  • .agents/skills/branching-and-release-model/references/release-publish-mechanics.md
  • .agents/skills/branching-and-release-model/references/branch-protection-and-promotion.md
  • .agents/skills/merge-and-release/SKILL.md
  • Regenerated copies under .github/skills/ and .claude-plugin/fleet-skills/, with the two .source-digests/ entries. No include region was edited.

Verification

Every split was compared with its original, hunk by hunk. The check covered lost antecedents, dropped or misattached reasons, changed condition scope, opened or closed lists, and new claims. Several independent adversarial review passes ran and their findings were fixed.

Part of #3531.

🤖 Generated with Claude Code

ptr727 and others added 7 commits October 28, 2026 16:16
The branching-and-release-model and merge-and-release skills, with the
branching skill's two reference files, carried 103 sentences over the
25-word cap. Each is split or tightened with its meaning, conditions,
and reasons kept, including every condition on who authorizes a merge or
a release. The generated copies and source digests are regenerated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review found splits where a reason connective, a condition's reach, or
a closed list had shifted. Each is restored to its original meaning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release-target gloss no longer reads as covering wrapper-repo
tracking, and the head-commit comparison step names what is compared.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The package-target curation sentence names its subject again, and the
EOL-conflict condition reads as a condition rather than a hedge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The cleanup step's fast-forward ties back to bringing the clone current,
the maintainer-push sentence names its antecedent, the manual-close
sentence names its subject, and the exit-code list parses again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The operational promotion check's contents are now a sentence of their own, so
they read as describing the check rather than unit tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The run-watch command again follows the maintainer-bound exception, the
merge-and-release opening lists the steps rather than commanding them,
and the CRLF-to-LF example names what it exemplifies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 28, 2026 23:35
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 76274b05c48ab74b7cd0408af90aed64b4a021fa, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the supplied evidence reports that the sentence-length check passed without findings across the changed Markdown files.

No open issues 🎉

What changed in this PR

This pull request splits over-length sentences in the release-management skills while preserving their procedures, conditions, authorization rules, and rationale. It updates authored sources, generated distributions, and source digests.

Changes:

  • Splits long sentences in merge-and-release.
  • Splits long sentences in branching-and-release-model and its two reference documents.
  • Regenerates GitHub and Claude skill copies.
  • Updates the Claude source digests.
  • Verifies the sentence-length check with no findings across the changed Markdown files.
File Description
.github/​skills/​merge-and-release/​SKILL.md Generated GitHub copy of merge and release guidance
.github/​skills/​branching-and-release-model/​SKILL.md Generated GitHub copy of branching and publishing guidance
.github/​skills/​branching-and-release-model/​references/​release-publish-mechanics.md Generated GitHub release mechanics reference
.github/​skills/​branching-and-release-model/​references/​branch-protection-and-promotion.md Generated GitHub promotion mechanics reference
.claude-plugin/​fleet-skills/​skills/​merge-and-release/​SKILL.md Generated Claude copy of merge and release guidance
.claude-plugin/​fleet-skills/​skills/​branching-and-release-model/​SKILL.md Generated Claude copy of branching and publishing guidance
.claude-plugin/​fleet-skills/​skills/​branching-and-release-model/​references/​release-publish-mechanics.md Generated Claude release mechanics reference
.claude-plugin/​fleet-skills/​skills/​branching-and-release-model/​references/​branch-protection-and-promotion.md Generated Claude promotion mechanics reference
.claude-plugin/​fleet-skills/​.source-digests/​merge-and-release Updated generated source digest
.claude-plugin/​fleet-skills/​.source-digests/​branching-and-release-model Updated generated source digest
.agents/​skills/​merge-and-release/​SKILL.md Authored merge and release guidance with shorter sentences
.agents/​skills/​branching-and-release-model/​SKILL.md Authored branching and publishing guidance with shorter sentences
.agents/​skills/​branching-and-release-model/​references/​release-publish-mechanics.md Authored release mechanics reference with shorter sentences
.agents/​skills/​branching-and-release-model/​references/​branch-protection-and-promotion.md Authored promotion mechanics reference with shorter sentences

Review effort: Lite

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.60%. Comparing base (b82a4a0) to head (76274b0).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3585   +/-   ##
========================================
  Coverage    81.60%   81.60%           
========================================
  Files           26       26           
  Lines         9070     9070           
========================================
  Hits          7402     7402           
  Misses        1668     1668           
Flag Coverage Δ
python-3.13 81.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit 8a9b7fa into develop Oct 28, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/3531-release-skills-sentence-length branch October 29, 2026 00:04
ptr727 added a commit that referenced this pull request Oct 29, 2026
… and the Secrets Shell Library (#3589)

## Summary

Promotes `develop` to `main`, carrying the sentence-length splits of the
skill sources and the secrets shell library:

- #3582: splits the over-length sentences in the git and worktree
skills.
- #3584: splits them in the local review, agent conduct, and
check-this-repo skills.
- #3581: splits them in the comments of `lib/sh/secrets.sh`.
- #3585: splits them in the release skills.
- #3583: splits them in the codestyle and guard skills.
- #3586: splits them in the comment and doc style skill.
- #3587: splits them in the repo procedure skills.

The skill changes include their generated copies.

Closes #3577

This is part of #3531, which stays open.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants