Promote Develop: Split the Over-Length Sentences in the Skill Sources and the Secrets Shell Library by ptr727 · Pull Request #3589 · ptr727/ProjectTemplate

ptr727 · 2026-10-29T00:04:20Z

Summary

Promotes develop to main, carrying the sentence-length splits of the skill sources and the secrets shell library:

Split the Over-Length Sentences in the Git and Worktree Skills #3582: splits the over-length sentences in the git and worktree skills.
Split the Over-Length Sentences in the Local Review, Agent Conduct, and Check This Repo Skills #3584: splits them in the local review, agent conduct, and check-this-repo skills.
Split the Over-Length Sentences in the Secrets Shell Library Comments #3581: splits them in the comments of lib/sh/secrets.sh.
Split the Over-Length Sentences in the Release Skills #3585: splits them in the release skills.
Split the Over-Length Sentences in the Codestyle and Guard Skills #3583: splits them in the codestyle and guard skills.
Split the Over-Length Sentences in the Comment and Doc Style Skill #3586: splits them in the comment and doc style skill.
Split the Over-Length Sentences in the Repo Procedure Skills #3587: splits them in the repo procedure skills.

The skill changes include their generated copies.

This is part of #3531, which stays open.

🤖 Generated with Claude Code

## What changed Splits or tightens every sentence over 25 words in the repo-worktree, git-commit-conventions, and upstream-contribution-workflow skills, so each file reads zero for the sentence-length check. No exclusion, label, or gate change. Files: - `.agents/skills/repo-worktree/SKILL.md` - `.agents/skills/git-commit-conventions/SKILL.md` - `.agents/skills/git-commit-conventions/references/history-rewrite.md` - `.agents/skills/upstream-contribution-workflow/SKILL.md` - Their regenerated copies under `.github/skills/` and `.claude-plugin/fleet-skills/`, including `.source-digests/`. Every split was compared with its original sentence for lost antecedents, dropped reasons, narrowed qualifiers, and added claims. Four independent local reviews ran. The last one found nothing and is recorded against this head. Part of #3531. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

…nd Check This Repo Skills (#3584) ## What changed Splits every sentence over 25 words in three skills so each reads zero for `prose_lint.py --check sentence-length`, keeping each sentence's meaning. - `.agents/skills/local-strict-review/SKILL.md` (54 hits to 0) - `.agents/skills/agent-conduct/SKILL.md` (12 hits to 0, outside its generated include regions) - `.agents/skills/check-this-repo/SKILL.md` (11 hits to 0) - Regenerated copies under `.github/skills/` and `.claude-plugin/fleet-skills/`, including `.source-digests/`, from `build_dist.py`. ## Why The hub is not exempt from its own sentence-length rule, so the text is fixed rather than the check or its config. ## Verification - Every split was compared with its original sentence for lost antecedents, dropped reasons, narrowed or widened conditions, and new claims. - Five fresh full-diff review passes ran at the frontier tier. The earlier rounds' findings were fixed, and the last pass found nothing. - `build_dist.py --check`, the prose gate against `origin/develop`, and the eol check pass. Part of #3531. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

…#3581) Splits the 23 over-length comment sentences in `lib/sh/secrets.sh` so the sentence-length check reads zero. Only comment text changed. No code, string, or behavior changed. Files: `lib/sh/secrets.sh`. Every split was compared with its original sentence for lost antecedents, dropped reasons, narrowed qualifiers, and added claims. Three strict review rounds found drifts, all fixed in later commits, and the latest pass on the final head reported no findings. Part of #3531. Resolves #3577 on promotion. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

## What changed Splits or tightens every sentence over the 25-word cap in the release skills. That includes the two reference files of `branching-and-release-model`. Each file now reads zero for `prose_lint.py --check sentence-length`. Each sentence keeps its meaning, conditions, and reasons, including every condition on who authorizes a merge or a release in `merge-and-release`. ## Files - `.agents/skills/branching-and-release-model/SKILL.md` - `.agents/skills/branching-and-release-model/references/release-publish-mechanics.md` - `.agents/skills/branching-and-release-model/references/branch-protection-and-promotion.md` - `.agents/skills/merge-and-release/SKILL.md` - Regenerated copies under `.github/skills/` and `.claude-plugin/fleet-skills/`, with the two `.source-digests/` entries. No include region was edited. ## Verification Every split was compared with its original, hunk by hunk. The check covered lost antecedents, dropped or misattached reasons, changed condition scope, opened or closed lists, and new claims. Several independent adversarial review passes ran and their findings were fixed. Part of #3531. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

) ## What changed Splits or tightens every sentence over 25 words in five skills: dotnet-codestyle, python-codestyle, workflow-ci-contract, carried-instruction-file-guard, and copilot-instructions-keeper. Each file now reads zero for the sentence-length check. The hub is not exempt from its own rules, so the text changed and no gate or config did. ## Files - `.agents/skills/dotnet-codestyle/SKILL.md` and `references/{testing,project-config,conventions}.md` - `.agents/skills/python-codestyle/references/{code-style,testing}.md` - `.agents/skills/workflow-ci-contract/SKILL.md` and `references/d-guarantees.md` (preamble only, outside the include region) - `.agents/skills/carried-instruction-file-guard/SKILL.md` - `.agents/skills/copilot-instructions-keeper/SKILL.md` - Regenerated copies under `.github/skills/` and `.claude-plugin/fleet-skills/`, including the source digests. ## Verification Every split was compared with its original sentence for lost antecedents, dropped reasons, narrowed or widened conditions, and list-kind changes. Three adversarial review passes ran, and their findings were fixed. No include region was edited. Part of #3531. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

…3586) Splits every sentence over 25 words in the comment-and-doc-style skill so each reads zero for `prose_lint.py --check sentence-length`. The hub is not exempt from its own rules, so the text is fixed rather than the check or its config. Each split keeps the sentence's meaning, reasons, and conditions. Every split was compared with its original. Several adversarial review rounds checked each one for lost antecedents, misplaced reasons, changed conditions, and list-framing changes. Files: - `.agents/skills/comment-and-doc-style/SKILL.md` - `.agents/skills/comment-and-doc-style/references/line-endings.md` - `.agents/skills/comment-and-doc-style/references/carried-doc-references.md` - `.agents/skills/comment-and-doc-style/references/markdown-links.md` - Regenerated copies under `.github/skills/` and `.claude-plugin/fleet-skills/`, including `.source-digests/comment-and-doc-style`. The generated include region in SKILL.md is untouched. Part of #3531. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Splits the over-length sentences in four repo-procedure skills so each reads zero for the `sentence-length` check, with no change to what any sentence requires. Files: - `.agents/skills/skill-lifecycle/SKILL.md` - `.agents/skills/audit-a-repo/SKILL.md` - `.agents/skills/standup-a-repo/SKILL.md` - `.agents/skills/resync-a-repo/SKILL.md` - Their regenerated copies under `.github/skills/` and `.claude-plugin/fleet-skills/`, plus the four `.source-digests/` entries, produced by `build_dist.py`. The exit-2 refusal list in `skill-lifecycle` is now a nested bullet list. Its items are the original items in the original order. One compound item ("one outside the root, ...") became a separate "a path outside the root, ..." item so the antecedent survives. Every split was compared with its original, hunk by hunk. The drift classes were lost antecedent, dropped or half-attached reason, narrowed qualifier or citation, closed example list, and added claim. Local review rounds caught and fixed drift on new sentences. The last round found none. Part of #3531. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-29T00:04:28Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Source mode: Auto
Repository: ptr727/ProjectTemplate
Branch: develop
File: .coderabbit.yaml
Commit: 7364e14
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: 6bc24833-331d-40b7-87aa-4db2dba35923

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-10-29T00:10:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.60%. Comparing base (b82a4a0) to head (7364e14).
⚠️ Report is 439 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3589   +/-   ##
=======================================
  Coverage   81.60%   81.60%           
=======================================
  Files          26       26           
  Lines        9070     9070           
=======================================
  Hits         7402     7402           
  Misses       1668     1668

Flag	Coverage Δ
python-3.13	`81.60% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

🟡 Changes recommended

Two active nit findings remain in .agents/skills/agent-conduct/SKILL.md: an ungrammatical missing relative clause and an over-length sentence.

2 open issues

What changed in this PR

This promotion carries the sentence-length cleanup from develop to main. It updates the authored Skill sources and their generated Copilot and Claude distributions, while preserving the documented behavior and refreshing source digests.

Changes:

Splits or tightens over-length prose in repository procedure, workflow, release, codestyle, review, and documentation Skills.
Updates comments in lib/sh/secrets.sh without changing shell behavior.
Regenerates distributed Skills and updates their source-digest entries.

The repository's named prose gate could not run in this review container because uv is unavailable. No actionable defects were identified by inspection.

File	Description
.github/skills/workflow-ci-contract/SKILL.md	Updated as part of this pull request.
.github/skills/workflow-ci-contract/references/d-guarantees.md	Updated as part of this pull request.
.github/skills/upstream-contribution-workflow/SKILL.md	Updated as part of this pull request.
.github/skills/standup-a-repo/SKILL.md	Updated as part of this pull request.
.github/skills/resync-a-repo/SKILL.md	Updated as part of this pull request.
.github/skills/python-codestyle/references/testing.md	Updated as part of this pull request.
.github/skills/python-codestyle/references/code-style.md	Updated as part of this pull request.
.github/skills/git-commit-conventions/references/history-rewrite.md	Updated as part of this pull request.
.github/skills/dotnet-codestyle/SKILL.md	Updated as part of this pull request.
.github/skills/dotnet-codestyle/references/testing.md	Updated as part of this pull request.
.github/skills/dotnet-codestyle/references/project-config.md	Updated as part of this pull request.
.github/skills/dotnet-codestyle/references/conventions.md	Updated as part of this pull request.
.github/skills/copilot-instructions-keeper/SKILL.md	Updated as part of this pull request.
.github/skills/comment-and-doc-style/references/markdown-links.md	Updated as part of this pull request.
.github/skills/comment-and-doc-style/references/carried-doc-references.md	Updated as part of this pull request.
.github/skills/check-this-repo/SKILL.md	Updated as part of this pull request.
.github/skills/carried-instruction-file-guard/SKILL.md	Updated as part of this pull request.
.github/skills/agent-conduct/SKILL.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/workflow-ci-contract/SKILL.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/workflow-ci-contract/references/d-guarantees.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/upstream-contribution-workflow/SKILL.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/standup-a-repo/SKILL.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/python-codestyle/references/testing.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/python-codestyle/references/code-style.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/git-commit-conventions/references/history-rewrite.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/dotnet-codestyle/SKILL.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/dotnet-codestyle/references/testing.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/dotnet-codestyle/references/project-config.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/dotnet-codestyle/references/conventions.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/copilot-instructions-keeper/SKILL.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/comment-and-doc-style/references/markdown-links.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/comment-and-doc-style/references/carried-doc-references.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/check-this-repo/SKILL.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/carried-instruction-file-guard/SKILL.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/skills/agent-conduct/SKILL.md	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/workflow-ci-contract	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/upstream-contribution-workflow	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/standup-a-repo	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/skill-lifecycle	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/resync-a-repo	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/repo-worktree	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/python-codestyle	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/merge-and-release	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/local-strict-review	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/git-commit-conventions	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/dotnet-codestyle	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/copilot-instructions-keeper	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/comment-and-doc-style	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/check-this-repo	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/carried-instruction-file-guard	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/branching-and-release-model	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/audit-a-repo	Updated as part of this pull request.
.claude-plugin/fleet-skills/.source-digests/agent-conduct	Updated as part of this pull request.
.agents/skills/workflow-ci-contract/SKILL.md	Updated as part of this pull request.
.agents/skills/workflow-ci-contract/references/d-guarantees.md	Updated as part of this pull request.
.agents/skills/upstream-contribution-workflow/SKILL.md	Updated as part of this pull request.
.agents/skills/standup-a-repo/SKILL.md	Updated as part of this pull request.
.agents/skills/resync-a-repo/SKILL.md	Updated as part of this pull request.
.agents/skills/python-codestyle/references/testing.md	Updated as part of this pull request.
.agents/skills/python-codestyle/references/code-style.md	Updated as part of this pull request.
.agents/skills/git-commit-conventions/references/history-rewrite.md	Updated as part of this pull request.
.agents/skills/dotnet-codestyle/SKILL.md	Updated as part of this pull request.
.agents/skills/dotnet-codestyle/references/testing.md	Updated as part of this pull request.
.agents/skills/dotnet-codestyle/references/project-config.md	Updated as part of this pull request.
.agents/skills/dotnet-codestyle/references/conventions.md	Updated as part of this pull request.
.agents/skills/copilot-instructions-keeper/SKILL.md	Updated as part of this pull request.
.agents/skills/comment-and-doc-style/references/markdown-links.md	Updated as part of this pull request.
.agents/skills/comment-and-doc-style/references/carried-doc-references.md	Updated as part of this pull request.
.agents/skills/check-this-repo/SKILL.md	Updated as part of this pull request.
.agents/skills/carried-instruction-file-guard/SKILL.md	Updated as part of this pull request.
.agents/skills/agent-conduct/SKILL.md	Updated as part of this pull request.

_{Review effort: Lite}

…nt-conduct (#3590) Fixes Copilot threads PRRT_kwDOQ5caqM6xXni_ and PRRT_kwDOQ5caqM6xXnjL raised on #3589. Both edits are in `.agents/skills/agent-conduct/SKILL.md`, outside its include regions. - Line 26: restores the relative pronoun, "doc sections that nothing surfaced at the moment of violation". - Line 93: splits one long reference sentence into three. The quoted bullet openings are byte-identical. The generated copies under `.github/skills/` and `.claude-plugin/fleet-skills/` and the `agent-conduct` source digest are regenerated with `build_dist.py`. Each new sentence was compared with its original for pronoun antecedents and dropped conditions. The sentences that follow still read correctly. A local strict review at the opus tier found nothing. Part of #3531. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

Copilot

🟢 Approval recommended

The reviewed changes are documentation-only wording and sentence-length updates with runtime and shell behavior unchanged, and no active blocking issues are identified.

No open issues 🎉

2 resolved since last review

_{Review effort: Lite}

ptr727 · 2026-10-29T02:01:51Z

Coverage accepted by the maintainer on 2026-10-28 for head 7364e14.

Copilot's table on ba22ee5 named 71 of the 106 changed files, and its round on 7364e14 carries no table. The maintainer accepted feature-pull-request coverage for the 35 omitted files. Each was reviewed whole on the feature pull request that changed it:

Split the Over-Length Sentences in the Repo Procedure Skills #3587, Split the Over-Length Sentences in the Comment and Doc Style Skill #3586 and Split the Over-Length Sentences in the Secrets Shell Library Comments #3581: a Copilot table carried to the final head, naming every changed file.
Split the Over-Length Sentences in the Release Skills #3585 and Split the Over-Length Sentences in the Local Review, Agent Conduct, and Check This Repo Skills #3584: a Copilot table on the final head, naming every changed file.
Split the Over-Length Sentences in the Git and Worktree Skills #3582: Copilot on an earlier head, with all four threads fixed and resolved, and an attested local opus pass on the final head.

Every thread on this pull request and on each constituent is resolved, and no suppressed or body-only finding is open.

ptr727 and others added 7 commits October 28, 2026 16:38

Copilot AI lite review requested due to automatic review settings October 29, 2026 00:04

Copilot started reviewing on behalf of ptr727 October 29, 2026 00:04

View session

Copilot AI reviewed Oct 29, 2026

View reviewed changes

Comment thread .agents/skills/agent-conduct/SKILL.md Resolved

Comment thread .agents/skills/agent-conduct/SKILL.md Resolved

ptr727 mentioned this pull request Oct 29, 2026

Restore a Relative Pronoun and Split a Long Reference Sentence in agent-conduct #3590

Merged

ptr727 requested a lite review from Copilot October 29, 2026 00:28

Copilot started reviewing on behalf of ptr727 October 29, 2026 00:28

View session

Copilot AI reviewed Oct 29, 2026

View reviewed changes

ptr727 merged commit 13c2b8b into main Oct 29, 2026
14 checks passed

Navigation Menu

Repository navigation

Promote Develop: Split the Over-Length Sentences in the Skill Sources and the Secrets Shell Library - #3589

Promote Develop: Split the Over-Length Sentences in the Skill Sources and the Secrets Shell Library#3589
ptr727 merged 8 commits into
mainfrom
develop

ptr727 commented Oct 29, 2026

Uh oh!

coderabbitai Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

ptr727 commented Oct 29, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ptr727 commented Oct 29, 2026

Summary

Uh oh!

coderabbitai Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

ptr727 commented Oct 29, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Oct 29, 2026 •

edited

Loading

codecov Bot commented Oct 29, 2026 •

edited

Loading