Skip to content

Split the Over-Length Sentences in the Repo Procedure Skills - #3587

Merged
ptr727 merged 12 commits into
developfrom
feature/3531-repo-procedure-skills-sentence-length
Oct 29, 2026
Merged

ptr727 merged 12 commits into
developfrom
feature/3531-repo-procedure-skills-sentence-length

Conversation

@ptr727

@ptr727 ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Splits the over-length sentences in four repo-procedure skills so each reads zero for the sentence-length check, with no change to what any sentence requires.

Files:

  • .agents/skills/skill-lifecycle/SKILL.md
  • .agents/skills/audit-a-repo/SKILL.md
  • .agents/skills/standup-a-repo/SKILL.md
  • .agents/skills/resync-a-repo/SKILL.md
  • Their regenerated copies under .github/skills/ and .claude-plugin/fleet-skills/, plus the four .source-digests/ entries, produced by build_dist.py.

The exit-2 refusal list in skill-lifecycle is now a nested bullet list. Its items are the original items in the original order. One compound item ("one outside the root, ...") became a separate "a path outside the root, ..." item so the antecedent survives.

Every split was compared with its original, hunk by hunk. The drift classes were lost antecedent, dropped or half-attached reason, narrowed qualifier or citation, closed example list, and added claim. Local review rounds caught and fixed drift on new sentences. The last round found none.

Part of #3531.

🤖 Generated with Claude Code

ptr727 and others added 9 commits October 28, 2026 16:15
The skill-lifecycle, audit-a-repo, standup-a-repo, and resync-a-repo skills
carried sentences over the 25-word limit. Each is split or restructured so
it keeps its original conditions, reasons, and scope. The exit-2 refusal
list in skill-lifecycle becomes a nested list with its items unchanged.
Generated copies and source digests are regenerated with build_dist.py.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The local review found splits that left a reason on only one half, widened
a refusal, or detached a condition from its clause. Each is reworded so the
original reach is kept.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The second local review found an either without an or, a rule limited to
one packaging shape that read as general, a lost antecedent, and a reason
and a citation covering only one half of a split sentence.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The third local review found an either-or reduced to an obligation, a
citation covering only the last of three sentences, an apposition that lost
its antecedent, and a verbless fragment.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fourth local review found a section citation reaching only the first
of three converging steps, and a pronoun without an antecedent.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fifth local review found six splits whose section citation moved onto
the last piece only. Each citation now reaches the pieces it covered.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The sixth local review found a causal link the original never stated and a
never-from-a-copy qualifier that moved off the instruction it governed.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The seventh local review found a section citation that no longer covered a
bullet's lead and a procedure reference that no longer covered the gate.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The eighth local review found that the shape the step names no longer
described both the summary and the reference files after the split.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 28, 2026 23:38
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 04c30136c91a9eea566dff6504d63ae84c294324, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An active P2 nit remains in .agents/skills/resync-a-repo/SKILL.md, where the wording ambiguously associates the fetched RESYNC.md file with section 1 rather than clearly stating the required file relationship.

1 open issue
What changed in this PR

This pull request splits over-length sentences in four repository-procedure skills while preserving their operational requirements. It updates the canonical sources, regenerates the GitHub and Claude distributions, and refreshes the source digests.

Changes:

  • Splits long prose in skill-lifecycle, audit-a-repo, standup-a-repo, and resync-a-repo.
  • Restructures the skill-lifecycle refusal list into nested bullets while preserving its items and order.
  • Regenerates distributed skill copies and updates the four source-digest files.
  • Review findings remain in .agents/skills/audit-a-repo/SKILL.md and .agents/skills/resync-a-repo/SKILL.md, including the noted rationale, direct-push prohibition, and RESYNC.md file-reference issues.
File Description
.github/​skills/​standup-a-repo/​SKILL.md Generated GitHub distribution of the standup skill.
.github/​skills/​skill-lifecycle/​SKILL.md Generated GitHub distribution of the lifecycle skill.
.github/​skills/​resync-a-repo/​SKILL.md Generated GitHub distribution of the resync skill.
.github/​skills/​audit-a-repo/​SKILL.md Generated GitHub distribution of the audit skill.
.claude-plugin/​fleet-skills/​skills/​standup-a-repo/​SKILL.md Generated Claude distribution of the standup skill.
.claude-plugin/​fleet-skills/​skills/​skill-lifecycle/​SKILL.md Generated Claude distribution of the lifecycle skill.
.claude-plugin/​fleet-skills/​skills/​resync-a-repo/​SKILL.md Generated Claude distribution of the resync skill.
.claude-plugin/​fleet-skills/​skills/​audit-a-repo/​SKILL.md Generated Claude distribution of the audit skill.
.claude-plugin/​fleet-skills/​.source-digests/​standup-a-repo Updated standup source digest.
.claude-plugin/​fleet-skills/​.source-digests/​skill-lifecycle Updated lifecycle source digest.
.claude-plugin/​fleet-skills/​.source-digests/​resync-a-repo Updated resync source digest.
.claude-plugin/​fleet-skills/​.source-digests/​audit-a-repo Updated audit source digest.
.agents/​skills/​standup-a-repo/​SKILL.md Canonical standup sentence splits.
.agents/​skills/​skill-lifecycle/​SKILL.md Canonical lifecycle sentence splits and refusal-list restructuring.
.agents/​skills/​resync-a-repo/​SKILL.md Canonical resync sentence splits; findings include the direct-push prohibition (P1, moderate, 1 vote) and RESYNC.md file-reference clarity (P2, nit, 2 votes).
.agents/​skills/​audit-a-repo/​SKILL.md Canonical audit sentence splits; finding concerns the trigger rationale (P2, nit, 1 vote).

Review effort: Lite

Comment thread .agents/skills/resync-a-repo/SKILL.md Resolved
@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@8a9b7fa). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3587   +/-   ##
==========================================
  Coverage           ?   81.60%           
==========================================
  Files              ?       26           
  Lines              ?     9070           
  Branches           ?        0           
==========================================
  Hits               ?     7402           
  Misses             ?     1668           
  Partials           ?        0           
Flag Coverage Δ
python-3.13 81.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot found that the split left the file apposition attached to the
section number. The sentence now names section 1 of the file, then says the
file is fetched with the hub.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head ac5c7ac796f52f4b2094cc3f01fff2fead4e1983, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

A remaining sentence in .agents/skills/audit-a-repo/SKILL.md has an unclear antecedent and obscures the rationale for triggering on already-conformant repositories.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Low severity Clarify the rationale for triggering on conformant repositories

.agents/​skills/​audit-a-repo/​SKILL.md:4

[P2] Clarify the trigger rationale

The split leaves It is also because a repo that believes it is conformant is the case most often skipped without a clear antecedent for It, and it makes the repo itself read as the skipped case. This malformed sentence obscures why the skill triggers for an already-conformant repo. Keep the original meaning with a complete sentence such as This is the case most often skipped.

1 resolved since last review

Review effort: Lite

ptr727 and others added 2 commits October 28, 2026 16:51
Copilot found that the repo, rather than the case of a repo believing it is
conformant, read as the case most often skipped. The sentence now names the
case explicitly.

Part of #3531.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 1c63b7f71347a4f8c69858b2e8f7be8943f36f29, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727

ptr727 commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

Fixed in 1c63b7f: the finding on the trigger rationale in .agents/skills/audit-a-repo/SKILL.md line 4 is addressed. The sentence now names the case, a repo believing it is conformant, as the one most often skipped.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The supplied review status reports no active issues, with the authored skills, regenerated distributions, and source digests updated together.

No open issues 🎉

Review effort: Lite

@ptr727
ptr727 merged commit ba22ee5 into develop Oct 29, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/3531-repo-procedure-skills-sentence-length branch October 29, 2026 00:04
ptr727 added a commit that referenced this pull request Oct 29, 2026
… and the Secrets Shell Library (#3589)

## Summary

Promotes `develop` to `main`, carrying the sentence-length splits of the
skill sources and the secrets shell library:

- #3582: splits the over-length sentences in the git and worktree
skills.
- #3584: splits them in the local review, agent conduct, and
check-this-repo skills.
- #3581: splits them in the comments of `lib/sh/secrets.sh`.
- #3585: splits them in the release skills.
- #3583: splits them in the codestyle and guard skills.
- #3586: splits them in the comment and doc style skill.
- #3587: splits them in the repo procedure skills.

The skill changes include their generated copies.

Closes #3577

This is part of #3531, which stays open.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants