Skip to content

Require the DevKitCIoT Pull Request Check and Refresh Its Registry Entry - #3923

Merged
ptr727 merged 4 commits into
developfrom
feature/devkitciot-registry
Nov 7, 2026
Merged

ptr727 merged 4 commits into
developfrom
feature/devkitciot-registry

Conversation

@ptr727

@ptr727 ptr727 commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Updates the DevKitCIoT registry entry for its standup to the fleet standard (ptr727/DevKitCIoT#16 through #19, on DevKitCIoT develop).

  • Drops pullRequestCheck: false. DevKitCIoT develop now carries the validate-task.yml caller and its Check pull request workflow status job aggregator. Once this reaches hub main, repo-config/configure.sh apply ptr727/DevKitCIoT release adds the required status check to both rulesets, ahead of the DevKitCIoT promotion (ptr727/DevKitCIoT#20).
  • Adds description. It matches DevKitCIoT's new README tagline, so configure.sh apply writes the About panel.
  • Rewrites the three driftNotes. They now describe the current CI, the vendored part library, and the pending promotion, each saying which branch it is true on.

Verification

  • spec/validate.py passes.
  • The prose gate passes on the diff.
  • Local strict review ran three recorded passes. Rounds 1 and 2 qualified two notes that were true only on DevKitCIoT develop.

Until the DevKitCIoT promotion merges, the audit reports main's old README tagline against the declared description. That clears at the promotion, and the About panel clears at apply.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated the DevKitCIoT registry listing with a description of its ESP32-DevKitC board.
    • Revised project notes to describe the KiCad validation hook, project-local parts library on develop, branch divergence, and planned promotion to main.
    • The listing no longer marks pull request checks as disabled.

ptr727 and others added 4 commits November 7, 2026 10:22
DevKitCIoT now carries the validate-task caller and its required aggregator
on develop, so the registry drops pullRequestCheck: false and
configure.sh apply can add the required status check to both rulesets
before the promotion lands. The drift notes describe the current CI, the
vendored part library, and the pending promotion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The registry description matches the new README tagline, so configure.sh apply writes it to the About panel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 7, 2026 18:54
@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 3d993a3df9b9d7018ea033af513c132979a3aca0, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The DevKitCIoT registry entry gains a board description and updated drift notes. It no longer sets pullRequestCheck to false.

Changes: DevKitCIoT registry update

Layer / File(s) Summary
Update registry entry
registry/repos.json
Adds a description of the ESP32-DevKitC controller board and updates notes about validation, vendored parts, and branch promotion. Removes the explicit pullRequestCheck: false setting.

Estimated code review effort: 2 (Simple) | ~7 minutes

Possibly related issues

  • Issue 3920 describes the branch divergence and pending changes that the updated drift notes record.

Possibly related PRs

  • ptr727/ProjectTemplate#3910: Defines the optional pullRequestCheck registry field that this change removes from the DevKitCIoT entry.
Merge Risk: Minimal · up to 3d993

No merge-blocking defect was established. Confirm both branches produce the required status before applying the rulesets.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two main changes: requiring the DevKitCIoT Pull Request Check and refreshing its registry entry. The raw summary says the entry drops pullRequestCheck: false and gets a new descrip…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main changes: requiring the DevKitCIoT Pull Request Check and refreshing its registry entry. The raw summary says the entry drops pullRequestCheck: false and gets a new description and rewritten driftNotes, and the objectives confirm the same. The title is specific, though it is somewhat long at 72 characters and 11 words, and it does not mention the description addition.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 47116c7 and 3d993a3.

Files selected for processing: 1

  • registry/repos.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Defer because GitHub returned 404 when verifying the external repository’s develop workflow and live rulesets, so the required check cannot yet be confirmed before applying the registry change.

No open issues 🎉

What changed in this PR

Updates the DevKitCIoT registry entry to require the fleet-standard pull request check and reflect its current develop state and planned promotion to main.

Changes:

  • Removes the pullRequestCheck: false exception.
  • Adds the canonical repository description.
  • Refreshes drift notes for CI, vendored parts, and branch promotion status.
  • A moderate issue remains because the description will mismatch main until promotion; pending notes will also need removal afterward.

This pull request requires changes.

File Summary
registry/​repos.json Updates DevKitCIoT metadata, pull request check configuration, and drift notes.

Review effort: Lite

@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.26%. Comparing base (47116c7) to head (3d993a3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3923   +/-   ##
========================================
  Coverage    78.26%   78.26%           
========================================
  Files           35       35           
  Lines        12328    12328           
========================================
  Hits          9648     9648           
  Misses        2680     2680           
Flag Coverage Δ
python-3.13 78.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

Answering the round's headline ("Defer because GitHub returned 404 when verifying the external repository's develop workflow and live rulesets"). The 404 is the reviewer lacking read access to the private ptr727/DevKitCIoT, not a missing workflow. Read with the maintainer's access: .github/workflows/test-pull-request.yml on DevKitCIoT develop line 24 names its aggregator Check pull request workflow status job on pull_request. That check posted and passed on ptr727/DevKitCIoT#19 (run 42403065246). Neither live ruleset requires a status check today, which is what this change enables. configure.sh apply runs only after this reaches hub main, and the DevKitCIoT promotion (ptr727/DevKitCIoT#20) carries the same workflow.

@ptr727
ptr727 merged commit f96b8b7 into develop Nov 7, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/devkitciot-registry branch November 7, 2026 19:41
ptr727 added a commit that referenced this pull request Nov 7, 2026
…s and Refresh DevKitCIoT (#3926)

## Summary

Promotes #3923, #3924 and #3927 to `main`.

- **Three repositories move their Copilot and CodeRabbit reviews to
explicit requests (#3924).** PlexCleaner, Financial-Modeling and
HomeAutomation-Config each get the hub's own values: Copilot explicit,
after-checks, at most 3 rounds, gating; CodeRabbit explicit,
after-checks, once. Qodo keeps the fleet default. This is a test of
explicit review on active work, from the review-cutover track (#3877).
- **DevKitCIoT's registry entry is refreshed (#3923).** It drops
`pullRequestCheck: false`, so `configure.sh apply` adds DevKitCIoT's
required status check, and it adds the repository description.
- **DevKitCIoT's registry notes keep only its current deviations
(#3927).** This answers Copilot's finding on this promotion. The
completed-promotion text is deleted, per `AUDIT.md`'s driftNotes rule.

Nothing is written to any repository by this promotion. Each of the
three repositories' own sessions writes its policy files into its
`develop`. `configure.sh apply` then runs for each from a hub checkout
at the new `main`, with its own go-ahead.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants