Repository navigation
Require the DevKitCIoT Pull Request Check and Refresh Its Registry Entry - #3923
Conversation
DevKitCIoT now carries the validate-task caller and its required aggregator on develop, so the registry drops pullRequestCheck: false and configure.sh apply can add the required status check to both rulesets before the promotion lands. The drift notes describe the current CI, the vendored part library, and the pending promotion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The registry description matches the new README tagline, so configure.sh apply writes it to the About panel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🔵 Needs a closer look
Defer because GitHub returned 404 when verifying the external repository’s develop workflow and live rulesets, so the required check cannot yet be confirmed before applying the registry change.
No open issues 🎉
What changed in this PR
Updates the DevKitCIoT registry entry to require the fleet-standard pull request check and reflect its current develop state and planned promotion to main.
Changes:
- Removes the
pullRequestCheck: falseexception. - Adds the canonical repository description.
- Refreshes drift notes for CI, vendored parts, and branch promotion status.
- A moderate issue remains because the description will mismatch
mainuntil promotion; pending notes will also need removal afterward.
This pull request requires changes.
| File | Summary |
|---|---|
registry/repos.json |
Updates DevKitCIoT metadata, pull request check configuration, and drift notes. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3923 +/- ##
========================================
Coverage 78.26% 78.26%
========================================
Files 35 35
Lines 12328 12328
========================================
Hits 9648 9648
Misses 2680 2680
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
/review |
Action performed
|
|
Answering the round's headline ("Defer because GitHub returned 404 when verifying the external repository's develop workflow and live rulesets"). The 404 is the reviewer lacking read access to the private ptr727/DevKitCIoT, not a missing workflow. Read with the maintainer's access: |
…s and Refresh DevKitCIoT (#3926) ## Summary Promotes #3923, #3924 and #3927 to `main`. - **Three repositories move their Copilot and CodeRabbit reviews to explicit requests (#3924).** PlexCleaner, Financial-Modeling and HomeAutomation-Config each get the hub's own values: Copilot explicit, after-checks, at most 3 rounds, gating; CodeRabbit explicit, after-checks, once. Qodo keeps the fleet default. This is a test of explicit review on active work, from the review-cutover track (#3877). - **DevKitCIoT's registry entry is refreshed (#3923).** It drops `pullRequestCheck: false`, so `configure.sh apply` adds DevKitCIoT's required status check, and it adds the repository description. - **DevKitCIoT's registry notes keep only its current deviations (#3927).** This answers Copilot's finding on this promotion. The completed-promotion text is deleted, per `AUDIT.md`'s driftNotes rule. Nothing is written to any repository by this promotion. Each of the three repositories' own sessions writes its policy files into its `develop`. `configure.sh apply` then runs for each from a hub checkout at the new `main`, with its own go-ahead. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
Updates the DevKitCIoT registry entry for its standup to the fleet standard (ptr727/DevKitCIoT#16 through #19, on DevKitCIoT
develop).pullRequestCheck: false. DevKitCIoTdevelopnow carries thevalidate-task.ymlcaller and itsCheck pull request workflow status jobaggregator. Once this reaches hubmain,repo-config/configure.sh apply ptr727/DevKitCIoT releaseadds the required status check to both rulesets, ahead of the DevKitCIoT promotion (ptr727/DevKitCIoT#20).description. It matches DevKitCIoT's new README tagline, soconfigure.sh applywrites the About panel.driftNotes. They now describe the current CI, the vendored part library, and the pending promotion, each saying which branch it is true on.Verification
spec/validate.pypasses.develop.Until the DevKitCIoT promotion merges, the audit reports
main's old README tagline against the declared description. That clears at the promotion, and the About panel clears atapply.🤖 Generated with Claude Code
Summary by CodeRabbit
develop, branch divergence, and planned promotion tomain.