Skip to content

Describe DevKitCIoT's Registry Notes After Its Promotion - #3927

Merged
ptr727 merged 3 commits into
developfrom
feature/devkitciot-notes-promoted
Nov 7, 2026
Merged

ptr727 merged 3 commits into
developfrom
feature/devkitciot-notes-promoted

Conversation

@ptr727

@ptr727 ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Rewrites DevKitCIoT's registry driftNotes, which still called its promotion pending after DevKitCIoT#20 merged it into main. This answers Copilot's finding on promotion #3926.

Each new claim was checked against DevKitCIoT main:

  • .github/workflows/test-pull-request.yml calls the hub's validate-task.yml.
  • .github/actions/validate/action.yml runs the kicad-cli ERC and DRC checks.
  • lib/ holds the parts copied from the 2.0.0 library release.
  • PR Develop #20 is the promotion into main.

spec/validate.py passes.

Pre-existing findings, not filed

The local review also flagged rollout-tracker lines that went stale at the same promotion. This change does not touch them.

  • docs/reusable-workflows.md:181: DevKitCIoT's validate-task caller box is unchecked, but main now carries the caller. Class: pre-existing.
  • docs/reusable-workflows.md:149: DevKitCIoT is listed as carrying no merge-bot, but main now carries merge-bot-pull-request.yml. Class: pre-existing.
  • docs/eol-lf-rollout.md:127: the entry describes DevKitCIoT main as CRLF, but main now sets LF in .editorconfig and .gitattributes. Class: pre-existing.

Dropped findings

  • registry/repos.json:264: the reviewer asked whether status should read archived, citing DevKitCIoT's README. gh api repos/ptr727/DevKitCIoT reads archived=false, so cataloged is correct.

🤖 Generated with Claude Code

DevKitCIoT#20 promoted the validate-task caller, the project-local lib/
and the hub standup to main, so the notes no longer call them pending.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 7, 2026 21:04
@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head f9455ed8395d9c29f7de03fb94d5b4d511997da2, the content this pull request carries at that commit against develop, and it recorded 4 findings.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An active nit remains because registry/repos.json still labels a resolved promotion as current drift, contrary to the repository’s audit guidance.

1 open issue
What changed in this PR

Updates DevKitCIoT’s registry metadata to reflect its promotion to main and document the repository’s current validation and library state.

Changes:

  • Updates stale promotion-related driftNotes wording.
  • Documents the validate-task integration and KiCad ERC/DRC checks.
  • Documents the project-local KiCad parts in lib/.
  • python3 spec/validate.py passes.
File Review summary
registry/​repos.json Refreshes DevKitCIoT’s registry notes. One nit requests removing the completed-promotion note because driftNotes should represent current deviations rather than historical work.

This pull request is ready to be approved.

Review effort: Lite

Comment thread registry/repos.json Resolved
@codecov

codecov Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.26%. Comparing base (3f77635) to head (6839bf7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3927   +/-   ##
========================================
  Coverage    78.26%   78.26%           
========================================
  Files           35       35           
  Lines        12328    12328           
========================================
  Hits          9648     9648           
  Misses        2680     2680           
Flag Coverage Δ
python-3.13 78.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

ptr727 and others added 2 commits November 7, 2026 13:16
A driftNote records a current deviation, and a resolved one is deleted
rather than rewritten as history (AUDIT.md). So drop the completed
promotion note and the baseline validate-task caller.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ERC/DRC hook meets the eda validation check rather than deviating
from it, so its sentence goes. The lib/ note now states only what lasts:
the parts are a frozen copy that later library releases do not reach.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 6839bf7b1b3e5a1594e950b0c07c477999371214, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727
ptr727 merged commit c237375 into develop Nov 7, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/devkitciot-notes-promoted branch November 7, 2026 21:32
ptr727 added a commit that referenced this pull request Nov 7, 2026
…s and Refresh DevKitCIoT (#3926)

## Summary

Promotes #3923, #3924 and #3927 to `main`.

- **Three repositories move their Copilot and CodeRabbit reviews to
explicit requests (#3924).** PlexCleaner, Financial-Modeling and
HomeAutomation-Config each get the hub's own values: Copilot explicit,
after-checks, at most 3 rounds, gating; CodeRabbit explicit,
after-checks, once. Qodo keeps the fleet default. This is a test of
explicit review on active work, from the review-cutover track (#3877).
- **DevKitCIoT's registry entry is refreshed (#3923).** It drops
`pullRequestCheck: false`, so `configure.sh apply` adds DevKitCIoT's
required status check, and it adds the repository description.
- **DevKitCIoT's registry notes keep only its current deviations
(#3927).** This answers Copilot's finding on this promotion. The
completed-promotion text is deleted, per `AUDIT.md`'s driftNotes rule.

Nothing is written to any repository by this promotion. Each of the
three repositories' own sessions writes its policy files into its
`develop`. `configure.sh apply` then runs for each from a hub checkout
at the new `main`, with its own go-ahead.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants