Skip to content

Promote Develop: Move Three Repositories' Reviews to Explicit Requests and Refresh DevKitCIoT - #3926

Merged
ptr727 merged 3 commits into
mainfrom
develop
Nov 7, 2026
Merged

ptr727 merged 3 commits into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Promotes #3923, #3924 and #3927 to main.

Nothing is written to any repository by this promotion. Each of the three repositories' own sessions writes its policy files into its develop. configure.sh apply then runs for each from a hub checkout at the new main, with its own go-ahead.

🤖 Generated with Claude Code

ptr727 and others added 2 commits November 7, 2026 11:41
…try (#3923)

## Summary

Updates the DevKitCIoT registry entry for its standup to the fleet
standard (ptr727/DevKitCIoT#16 through #19, on DevKitCIoT `develop`).

- **Drops `pullRequestCheck: false`.** DevKitCIoT `develop` now carries
the `validate-task.yml` caller and its `Check pull request workflow
status job` aggregator. Once this reaches hub `main`,
`repo-config/configure.sh apply ptr727/DevKitCIoT release` adds the
required status check to both rulesets, ahead of the DevKitCIoT
promotion (ptr727/DevKitCIoT#20).
- **Adds `description`.** It matches DevKitCIoT's new README tagline, so
`configure.sh apply` writes the About panel.
- **Rewrites the three `driftNotes`.** They now describe the current CI,
the vendored part library, and the pending promotion, each saying which
branch it is true on.

## Verification

- `spec/validate.py` passes.
- The prose gate passes on the diff.
- Local strict review ran three recorded passes. Rounds 1 and 2
qualified two notes that were true only on DevKitCIoT `develop`.

Until the DevKitCIoT promotion merges, the audit reports `main`'s old
README tagline against the declared description. That clears at the
promotion, and the About panel clears at `apply`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Documentation**
* Updated the DevKitCIoT registry listing with a description of its
ESP32-DevKitC board.
* Revised project notes to describe the KiCad validation hook,
project-local parts library on `develop`, branch divergence, and planned
promotion to `main`.
  * The listing no longer marks pull request checks as disabled.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…equests (#3924)

Adds the same `agentPolicy` override to three repositories, so explicit
review gets tested on active work. This is the maintainer's choice from
the review-cutover track (#3877). The repositories are PlexCleaner
(public), and Financial-Modeling and HomeAutomation-Config (both
private).

- **Copilot:** explicit, after-checks, per push with at most 3 rounds,
gating. These are the hub's own values.
- **CodeRabbit:** explicit, after-checks, once. These are the hub's own
values, and they spend CodeRabbit's rate-limited quota once per pull
request. CodeRabbit does review both private repositories. Its plan's
rate limit, not their visibility, is what holds it back.
- **Qodo:** keeps the fleet default, automatic. Turning a bot off is
left to a test of its own.

`facts` derives the same settings for each repository: CodeRabbit
`enabled: false`, Qodo `disable_auto_feedback: false`, and Copilot's
ruleset rule off on both branches. A `write --dry-run` against each
repository's `develop` changes `.github/agent-policy.json` and
`.coderabbit.yaml`, and leaves `.pr_agent.toml` unchanged.

Next, on this session's "go", each repository's own session writes its
files into its `develop`. Then `configure.sh apply` runs for each on the
maintainer's go-ahead.

Verified locally: `spec/validate.py` OK, and the `test_spec_validate`,
`test_audit_helpers` and `test_agent_policy` suites pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Chores**
* Review automation settings have been updated for three repositories.
Copilot reviews run for up to three rounds after checks complete, while
CodeRabbit reviews run once after checks complete. These settings
standardize when automated reviews run and how many review rounds are
allowed.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 7, 2026 20:49
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The registry still contains stale notes describing DevKitCIoT work as pending on develop even though it has been promoted to main, which could mislead future audits or configuration runs.

1 open issue
What changed in this PR

This pull request promotes review-policy updates for three repositories and refreshes the DevKitCIoT registry entry on main.

Changes:

  • Adds explicit, after-checks Copilot and CodeRabbit review policies for Financial-Modeling, PlexCleaner, and HomeAutomation-Config.
  • Keeps Qodo on the fleet default policy.
  • Enables DevKitCIoT’s pull request check and adds its repository description.
  • Includes a minor documentation issue: DevKitCIoT’s drift notes still describe promotion as pending.

This pull request is ready to be approved.

File Summary
registry/​repos.json Defines per-repository review-policy overrides and refreshes DevKitCIoT registry metadata. The remaining drift notes are stale relative to the completed promotion.

Review effort: Lite

Comment thread registry/repos.json Resolved
@codecov

codecov Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.26%. Comparing base (47116c7) to head (c237375).
⚠️ Report is 477 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3926   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files          35       35           
  Lines       12328    12328           
=======================================
  Hits         9648     9648           
  Misses       2680     2680           
Flag Coverage Δ
python-3.13 78.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Rewrites DevKitCIoT's registry `driftNotes`, which still called its
promotion pending after DevKitCIoT#20 merged it into `main`. This
answers Copilot's finding on promotion #3926.

Each new claim was checked against DevKitCIoT `main`:
- `.github/workflows/test-pull-request.yml` calls the hub's
`validate-task.yml`.
- `.github/actions/validate/action.yml` runs the kicad-cli ERC and DRC
checks.
- `lib/` holds the parts copied from the 2.0.0 library release.
- PR #20 is the promotion into `main`.

`spec/validate.py` passes.

## Pre-existing findings, not filed

The local review also flagged rollout-tracker lines that went stale at
the same promotion. This change does not touch them.
- `docs/reusable-workflows.md:181`: DevKitCIoT's validate-task caller
box is unchecked, but `main` now carries the caller. Class:
pre-existing.
- `docs/reusable-workflows.md:149`: DevKitCIoT is listed as carrying no
merge-bot, but `main` now carries `merge-bot-pull-request.yml`. Class:
pre-existing.
- `docs/eol-lf-rollout.md:127`: the entry describes DevKitCIoT `main` as
CRLF, but `main` now sets LF in `.editorconfig` and `.gitattributes`.
Class: pre-existing.

## Dropped findings

- `registry/repos.json:264`: the reviewer asked whether `status` should
read `archived`, citing DevKitCIoT's README. `gh api
repos/ptr727/DevKitCIoT` reads `archived=false`, so `cataloged` is
correct.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the registry policy and metadata updates.

No open issues 🎉

1 resolved since last review

Review effort: Lite

@ptr727
ptr727 merged commit 20ac62f into main Nov 7, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants