Skip to content

Move Three Repositories' Copilot and CodeRabbit Reviews to Explicit Requests - #3924

Merged
ptr727 merged 4 commits into
developfrom
feature/plexcleaner-explicit-review
Nov 7, 2026
Merged

ptr727 merged 4 commits into
developfrom
feature/plexcleaner-explicit-review

Conversation

@ptr727

@ptr727 ptr727 commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Adds the same agentPolicy override to three repositories, so explicit review gets tested on active work. This is the maintainer's choice from the review-cutover track (#3877). The repositories are PlexCleaner (public), and Financial-Modeling and HomeAutomation-Config (both private).

  • Copilot: explicit, after-checks, per push with at most 3 rounds, gating. These are the hub's own values.
  • CodeRabbit: explicit, after-checks, once. These are the hub's own values, and they spend CodeRabbit's rate-limited quota once per pull request. CodeRabbit does review both private repositories. Its plan's rate limit, not their visibility, is what holds it back.
  • Qodo: keeps the fleet default, automatic. Turning a bot off is left to a test of its own.

facts derives the same settings for each repository: CodeRabbit enabled: false, Qodo disable_auto_feedback: false, and Copilot's ruleset rule off on both branches. A write --dry-run against each repository's develop changes .github/agent-policy.json and .coderabbit.yaml, and leaves .pr_agent.toml unchanged.

Next, on this session's "go", each repository's own session writes its files into its develop. Then configure.sh apply runs for each on the maintainer's go-ahead.

Verified locally: spec/validate.py OK, and the test_spec_validate, test_audit_helpers and test_agent_policy suites pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Review automation settings have been updated for three repositories. Copilot reviews run for up to three rounds after checks complete, while CodeRabbit reviews run once after checks complete. These settings standardize when automated reviews run and how many review rounds are allowed.

Add an agentPolicy override to PlexCleaner's registry entry, the hub's
own values for Copilot and CodeRabbit, so PlexCleaner tests explicit
review on active work. Qodo keeps the fleet default, automatic, as the
review-cutover check-in 1 recommends for PlexCleaner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 7, 2026 20:05
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Three repository entries gain review policies for Copilot and CodeRabbit. Copilot triggers explicitly after checks, with a maximum of three rounds. CodeRabbit triggers explicitly after checks and runs once.

Changes: Repository review policies

Layer / File(s) Summary
Add per-repository review settings
registry/repos.json
Financial-Modeling, PlexCleaner, and HomeAutomation-Config receive the same review settings for Copilot and CodeRabbit.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · up to 626d7

The registry changes move the three repositories to explicit reviews. No merge-blocking issue is identified; repository writes and the approved apply remain planned.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: three repositories (PlexCleaner, Financial-Modeling, HomeAutomation-Config) move their Copilot and CodeRabbit reviews from automatic to explicit requests. The raw sum…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: three repositories (PlexCleaner, Financial-Modeling, HomeAutomation-Config) move their Copilot and CodeRabbit reviews from automatic to explicit requests. The raw summary confirms that each repository now declares an agentPolicy in registry/repos.json that triggers Copilot and CodeRabbit explicitly after checks. The title is specific, concise, and matches the changeset, so it passes.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f96b8b7 and 626d7cd.

Files selected for processing: 1

  • registry/repos.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head cfdbc50d92c23feaf945d0b045e06ecabf010a10, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, so the repository-specific review policy changes are ready for approval.

No open issues 🎉

What changed in this PR

This PR adds a PlexCleaner-specific agent policy that makes Copilot and CodeRabbit reviews explicit while retaining the fleet-default Qodo policy.

Changes:

  • Configures Copilot for explicit, after-checks reviews with up to three rounds per push.
  • Configures CodeRabbit for explicit, after-checks reviews with one round.
  • Leaves Qodo inherited from the automatic fleet default.
  • Review feedback requests a regression test pinning PlexCleaner's rendered policy.
File Summary
registry/​repos.json Adds PlexCleaner's per-repository review policy overrides.

Review effort: Lite

Add an agentPolicy override to Financial-Modeling's registry entry:
Copilot with the hub's explicit values, CodeRabbit and Qodo off, since
neither reviews a private repository on its open-source tier.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727 ptr727 changed the title Move PlexCleaner's Copilot and CodeRabbit Reviews to Explicit Requests Move PlexCleaner and Financial-Modeling Reviews to Explicit Requests Nov 7, 2026
@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 1befc63166e9cfa66131119397682587a1c21132, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@codecov

codecov Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.26%. Comparing base (b38e084) to head (626d7cd).
⚠️ Report is 113 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3924      +/-   ##
===========================================
- Coverage    81.60%   78.26%   -3.35%     
===========================================
  Files           26       35       +9     
  Lines         9070    12328    +3258     
===========================================
+ Hits          7402     9648    +2246     
- Misses        1668     2680    +1012     
Flag Coverage Δ
python-3.13 78.26% <ø> (-3.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add an agentPolicy override to HomeAutomation-Config's registry entry,
the same as Financial-Modeling's: Copilot with the hub's explicit
values, CodeRabbit and Qodo off, since the repository is private.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727 ptr727 changed the title Move PlexCleaner and Financial-Modeling Reviews to Explicit Requests Move Three Repositories' Reviews to Explicit Requests Nov 7, 2026
@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head f4a2949456c20addb7a154500977c6839b4d2969, the content this pull request carries at that commit against develop, and it recorded 0 findings.

CodeRabbit does review Financial-Modeling and HomeAutomation-Config,
where its plan's rate limit rather than visibility holds it back. So
both take the hub's explicit CodeRabbit values, which spend that quota
once per pull request, and Qodo keeps the fleet default. Turning a bot
off is left to a test of its own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727 ptr727 changed the title Move Three Repositories' Reviews to Explicit Requests Move Three Repositories' Copilot and CodeRabbit Reviews to Explicit Requests Nov 7, 2026
@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 626d7cd09853e0ff1197ed8354491df303fa9b6a, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@ptr727

ptr727 commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

/review

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit 3f77635 into develop Nov 7, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/plexcleaner-explicit-review branch November 7, 2026 20:43
ptr727 added a commit that referenced this pull request Nov 7, 2026
…s and Refresh DevKitCIoT (#3926)

## Summary

Promotes #3923, #3924 and #3927 to `main`.

- **Three repositories move their Copilot and CodeRabbit reviews to
explicit requests (#3924).** PlexCleaner, Financial-Modeling and
HomeAutomation-Config each get the hub's own values: Copilot explicit,
after-checks, at most 3 rounds, gating; CodeRabbit explicit,
after-checks, once. Qodo keeps the fleet default. This is a test of
explicit review on active work, from the review-cutover track (#3877).
- **DevKitCIoT's registry entry is refreshed (#3923).** It drops
`pullRequestCheck: false`, so `configure.sh apply` adds DevKitCIoT's
required status check, and it adds the repository description.
- **DevKitCIoT's registry notes keep only its current deviations
(#3927).** This answers Copilot's finding on this promotion. The
completed-promotion text is deleted, per `AUDIT.md`'s driftNotes rule.

Nothing is written to any repository by this promotion. Each of the
three repositories' own sessions writes its policy files into its
`develop`. `configure.sh apply` then runs for each from a hub checkout
at the new `main`, with its own go-ahead.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants