Repository navigation
Write the Hub-Checkout Reach Into the session-handoff Chain Commands - #2132
Conversation
The "Running the Chain" block named a bare scripts/handoff.py, which in a carrier holding its own scripts/ directory resolves to a real directory that does not hold the tool. Assign the path once from a quoted <hub-checkout> placeholder, as local-strict-review already does for its engine, so the block stays correct once copied out of the prose that scoped it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 32 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2132 +/- ##
==========================================
Coverage ? 56.47%
==========================================
Files ? 16
Lines ? 7455
Branches ? 0
==========================================
Hits ? 4210
Misses ? 3245
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The single-line documentation change matches an established in-tree pattern, quoting is shell-safe, and the generated copies and recomputed source digest are all consistent with the canonical source.
Review effort: Balanced
Findings: None
What changed in this PR
This PR fixes a copy-and-paste hazard in the session-handoff skill's "Running the Chain" command block. The block previously used a bare relative path (python3 scripts/handoff.py ...). Because the skill is carried into every fleet repository, and a carrier may hold its own scripts/ directory, a copied command could resolve to a real directory that does not contain handoff.py, failing without naming the cause. The fix assigns the tool path once via a <hub-checkout>/ placeholder and references it as python3 "$handoff" ..., mirroring the pattern the local-strict-review skill already uses for its own engine.
Changes:
- Rewrote the command block to define
handoff="<hub-checkout>/scripts/handoff.py"(with a comment for the plain hub-local path) and run each subcommand aspython3 "$handoff" ..., keeping the placeholder quoted so a pasted line is not read as a shell redirect. - Regenerated the
.github/skills/and.claude-plugin/fleet-skills/distribution copies from the.agents/skills/source. - Updated the generated
session-handoffsource digest to8dfe7946b9693ac7(verified to match the source content).
| File | Description |
|---|---|
.agents/skills/session-handoff/SKILL.md |
Canonical source: rewrites the chain command block to reference an explicit hub-checkout path, matching the local-strict-review shape. |
.github/skills/session-handoff/SKILL.md |
Generated copy carrying the identical block change. |
.claude-plugin/fleet-skills/skills/session-handoff/SKILL.md |
Generated plugin copy carrying the identical block change. |
.claude-plugin/fleet-skills/.source-digests/session-handoff |
Regenerated source digest; recomputation confirms it matches the edited source. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@coderabbitai review |
|
… a Second Site's Verify Token Pair, With Fifteen More (#2175) ## Summary Promotes develop to main, carrying these pull requests: - [#2172](#2172) Accept Letters in Recorded Names in the Charset Rule and Prose Gate - [#2173](#2173) Forward a Second Site's Token Pair to the Deploy-Site Verify Hook - [#2169](#2169) Record HomeAutomation-Config's Merge-Bot and Gate Adoption in the Rollout Tracking - [#2164](#2164) Pass --no-project to the Pre-Commit Snippet's uv run Hooks - [#2161](#2161) Stop Crediting an until read Loop as Bounded in the Guard - [#2158](#2158) Drop the Path Argument From the Pre-Commit Snippet's Mypy Swap - [#2155](#2155) Reword the Canonical CRLF-Exception Comments for a Carrier's Own Pin - [#2153](#2153) End the Guard's Stdin Redirect Scan at a Reserved Word - [#2150](#2150) Describe the Pip Form Consistently Across python-codestyle - [#2144](#2144) Read the Run Id From the Runner's Environment in the Artifact-Cleanup Steps - [#2142](#2142) Diff a Merge Commit's Prose Against Its Merged-In Parent in the Pre-Commit Hook - [#2136](#2136) Qualify the Local Review Skill's Merge-Base Command to Match the Engine - [#2134](#2134) Quote the Bare Placeholder in skills_install.py's Usage Block - [#2132](#2132) Write the Hub-Checkout Reach Into the session-handoff Chain Commands - [#2130](#2130) Name the Missing build-system Condition in the Lint-Only Profile Bullet - [#2128](#2128) Skip a Blockquoted List Marker in the Prose Gate's Semicolon Rule - [#2119](#2119) State the Three Gaps D4.7's Supersede-and-Dispatch Step Leaves Open ## Closes Closes #2100 Closes #2031 Closes #1779 Closes #2148 Closes #1633 Closes #1188 Closes #1992 Closes #2032 Closes #2052 Closes #1481 Closes #2116 Closes #2107 Closes #2097 Closes #1512 Closes #2026 Closes #2101 Closes #2009 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Deployment verification can now check a second site using its own optional authentication token. * **Documentation** * Updated writing guidance to preserve the spelling and diacritics of recorded names. * Clarified Python project setup, formatting and testing guidance, and line-ending rules. * Expanded deployment and publishing guidance, including scenarios where publishing runs overlap. * **Bug Fixes** * Prose checks now handle quoted lists and tables more accurately, and merge checks avoid flagging comments brought in from the merged branch. * Improved checks for shell loops that read redirected input. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
The
session-handoffskill's "Running the Chain" command block wrote each command as a barepython3 scripts/handoff.py .... In a carrier that holds its ownscripts/directory, that path resolves to a real directory that does not hold the tool, so a copied command fails without naming the cause. The prose above the block already says to run the tool from a hub checkout. The command block is the part a reader copies, and it did not carry that instruction.handoff="<hub-checkout>/scripts/handoff.py", with a comment giving the plain path for the hub itself, and every command runspython3 "$handoff" .... This follows the shapelocal-strict-reviewalready uses for its engine. The placeholder is quoted, so a pasted line is not read as a redirect.scripts/handoff.pydoes not depend on the working directory, since every subcommand takes--repo. The absolute reach therefore behaves the same from any checkout.scripts/handoff.pycommand in a copy-and-run block..github/skills/and.claude-plugin/copies are regenerated withscripts/build_dist.py.Closes on promotion: #1512
Verification
python3 scripts/build_dist.py --check: the generated distributions are current.repo_gate.py,canonical_review.py status,spec/validate.py, anddocker_lint.pyall pass.local-strict-review: one pass over the full diff found nothing, and the pass is recorded.🤖 Generated with Claude Code