Repository navigation
Drop the Path Argument From the Pre-Commit Snippet's Mypy Swap - #2158
Conversation
The type-check hook's name suggested `uvx mypy@latest .` as the mypy swap. A path argument overrides a `[tool.mypy] files` selection, so a repository adopting the swap verbatim checked a wider tree than CI. CI's type-check step names no path for a project configured at its own root, so the swap now names none either. Closes on promotion: #1188
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2158 +/- ##
==========================================
Coverage ? 56.47%
==========================================
Files ? 16
Lines ? 7455
Branches ? 0
==========================================
Hits ? 4210
Misses ? 3245
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The change is correct and low-risk, but per fleet policy final disposition of a canonical-content change is left to human review rather than automated approval.
Review effort: Balanced
Findings: None
What changed in this PR
This PR corrects a one-line drift in the canonical pre-commit config snippet that Python fleet repos copy and adapt. The type-check hook's name field suggests a mypy swap for repos whose CI runs mypy instead of pyright; that suggestion previously read uvx mypy@latest ., where the trailing . overrides a [tool.mypy] files selection and widens the checked tree beyond what CI checks. I verified against .github/workflows/validate-task.yml (lines 344-368) that the "Type check Python step" runs the checker with an empty targets array for a project configured at its own root, naming a path only when the config lives in another directory. Dropping the . makes the suggested local hook mirror the CI invocation, so a repo adopting the snippet verbatim no longer fails a commit on a tree CI passes. The adjacent pyright entry (uvx pyright@latest) is already argument-free and consistent.
Changes:
- Remove the trailing
.path argument from theuvx mypy@latestswap suggestion in thetype-checkhook'sname.
| File | Description |
|---|---|
catalog/snippets/pre-commit/.pre-commit-config.yaml |
Drops the . from the suggested mypy swap so the local hook matches CI's path-free type-check invocation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… a Second Site's Verify Token Pair, With Fifteen More (#2175) ## Summary Promotes develop to main, carrying these pull requests: - [#2172](#2172) Accept Letters in Recorded Names in the Charset Rule and Prose Gate - [#2173](#2173) Forward a Second Site's Token Pair to the Deploy-Site Verify Hook - [#2169](#2169) Record HomeAutomation-Config's Merge-Bot and Gate Adoption in the Rollout Tracking - [#2164](#2164) Pass --no-project to the Pre-Commit Snippet's uv run Hooks - [#2161](#2161) Stop Crediting an until read Loop as Bounded in the Guard - [#2158](#2158) Drop the Path Argument From the Pre-Commit Snippet's Mypy Swap - [#2155](#2155) Reword the Canonical CRLF-Exception Comments for a Carrier's Own Pin - [#2153](#2153) End the Guard's Stdin Redirect Scan at a Reserved Word - [#2150](#2150) Describe the Pip Form Consistently Across python-codestyle - [#2144](#2144) Read the Run Id From the Runner's Environment in the Artifact-Cleanup Steps - [#2142](#2142) Diff a Merge Commit's Prose Against Its Merged-In Parent in the Pre-Commit Hook - [#2136](#2136) Qualify the Local Review Skill's Merge-Base Command to Match the Engine - [#2134](#2134) Quote the Bare Placeholder in skills_install.py's Usage Block - [#2132](#2132) Write the Hub-Checkout Reach Into the session-handoff Chain Commands - [#2130](#2130) Name the Missing build-system Condition in the Lint-Only Profile Bullet - [#2128](#2128) Skip a Blockquoted List Marker in the Prose Gate's Semicolon Rule - [#2119](#2119) State the Three Gaps D4.7's Supersede-and-Dispatch Step Leaves Open ## Closes Closes #2100 Closes #2031 Closes #1779 Closes #2148 Closes #1633 Closes #1188 Closes #1992 Closes #2032 Closes #2052 Closes #1481 Closes #2116 Closes #2107 Closes #2097 Closes #1512 Closes #2026 Closes #2101 Closes #2009 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Deployment verification can now check a second site using its own optional authentication token. * **Documentation** * Updated writing guidance to preserve the spelling and diacritics of recorded names. * Clarified Python project setup, formatting and testing guidance, and line-ending rules. * Expanded deployment and publishing guidance, including scenarios where publishing runs overlap. * **Bug Fixes** * Prose checks now handle quoted lists and tables more accurately, and merge checks avoid flagging comments brought in from the merged branch. * Improved checks for shell loops that read redirected input. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Drops the trailing path argument from the mypy swap the pre-commit snippet's
type-checkhook suggests in itsname.catalog/snippets/pre-commit/.pre-commit-config.yaml: the swap now readsuvx mypy@latestrather thanuvx mypy@latest .. A path argument overrides a[tool.mypy] filesselection, so a repository adopting the old swap verbatim checked a wider tree than CI and could fail a commit on a tree CI passes.validate-task.yml's "Type check Python" step names no path for a project configured at its own root.A
git grepformypy@latest .andmypy .finds no other surface suggesting the.form. The local strict review found the same path-argument drift, assrc, incatalog/snippets/configs/vscode-tasks-python.json, filed as #2157, and #2025 already covers theuv run mypy srcwording inpython-codestyle.Closes on promotion: #1188
🤖 Generated with Claude Code