Skip to content

Name the Missing build-system Condition in the Lint-Only Profile Bullet - #2130

Merged
ptr727 merged 1 commit into
developfrom
feature/auto-2026
Sep 30, 2026
Merged

ptr727 merged 1 commit into
developfrom
feature/auto-2026

Conversation

@ptr727

@ptr727 ptr727 commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Summary

The python-codestyle skill's "Two profiles" lint-only (Scripts) bullet gave the shape as no [project], no lockfile, and no requirements*.txt. It omitted the no-[build-system] condition that references/profiles.md states and that the python-directories classifier requires. A directory with only a [build-system] table matched the bullet, although the classifier calls it unsupported.

  • The bullet now also says no [build-system], so the SKILL.md, references/profiles.md, and the classifier all agree.
  • The generated .github/skills/ and .claude-plugin/ copies are regenerated with scripts/build_dist.py.

Closes on promotion: #2026

Verification

  • python3 scripts/build_dist.py --check: the generated distributions are current.
  • Prose gate (diff-scoped), the eol and eol-coverage gates, spec/validate.py, markdownlint, and editorconfig-checker all pass.
  • local-strict-review: one pass over the full diff found nothing, and the pass is recorded.

🤖 Generated with Claude Code

The python-codestyle Two Profiles bullet for the lint-only (Scripts) shape now names no [build-system] alongside no [project], no lockfile, and no requirements*.txt, matching references/profiles.md and the python-directories classifier.
Copilot AI balanced review requested due to automatic review settings September 30, 2026 07:08
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e4655ef7-ca0c-47bf-8e93-19a72fb4975d

📥 Commits

Reviewing files that changed from the base of the PR and between 9f1c07a and 16aa78f.

⛔ Files ignored due to path filters (3)
  • .claude-plugin/fleet-skills/.source-digests/python-codestyle is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/python-codestyle/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .github/skills/python-codestyle/SKILL.md is excluded by !.github/skills/**
📒 Files selected for processing (1)
  • .agents/skills/python-codestyle/SKILL.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The one-line documentation fix makes the SKILL.md lint-only bullet agree with both references/profiles.md and the classifier, and the generated copies match the source.

Review effort: Balanced
Findings: None

What changed in this PR

This PR fixes a documentation inconsistency in the python-codestyle skill. The "Two profiles" lint-only (Scripts) bullet previously described the shape as no [project], no lockfile, and no requirements*.txt, omitting the no-[build-system] condition. This caused the SKILL.md bullet to disagree with both references/profiles.md (which already lists no [build-system]) and the python-directories classifier, whose shape() only returns lint-only when neither project nor build-system is present — otherwise it returns unsupported. A directory carrying only a [build-system] table would have matched the old bullet while the classifier rejected it.

Changes:

  • Add the missing no [build-system] condition to the lint-only profile bullet so SKILL.md, references/profiles.md, and the classifier agree.
  • Regenerate the .github/skills/ and .claude-plugin/fleet-skills/ copies (and the source digest) from the hand-authored .agents/skills/ source via scripts/build_dist.py.

I verified the classifier logic (.github/actions/python-directories/python_directories.py:115-117) and references/profiles.md:49 both require no [build-system] for lint-only, and confirmed all three trees now carry the corrected phrasing. The generated copies match the source exactly, and the edit preserves the tree's ~100-column hard wrap (the changed line is 99 columns).

File Description
.agents/​skills/​python-codestyle/​SKILL.md Hand-authored source: adds no [build-system] to the lint-only bullet and rewraps the line.
.github/​skills/​python-codestyle/​SKILL.md Generated copy regenerated to match the source.
.claude-plugin/​fleet-skills/​skills/​python-codestyle/​SKILL.md Generated copy regenerated to match the source.
.claude-plugin/​fleet-skills/​.source-digests/​python-codestyle Updated source digest reflecting the regenerated content.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ptr727

ptr727 commented Sep 30, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit 4e88050 into develop Sep 30, 2026
9 checks passed
@ptr727
ptr727 deleted the feature/auto-2026 branch September 30, 2026 07:11
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@9f1c07a). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2130   +/-   ##
==========================================
  Coverage           ?   56.47%           
==========================================
  Files              ?       16           
  Lines              ?     7455           
  Branches           ?        0           
==========================================
  Hits               ?     4210           
  Misses             ?     3245           
  Partials           ?        0           
Flag Coverage Δ
python-3.13 56.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ptr727 added a commit that referenced this pull request Sep 30, 2026
… a Second Site's Verify Token Pair, With Fifteen More (#2175)

## Summary

Promotes develop to main, carrying these pull requests:

- [#2172](#2172) Accept
Letters in Recorded Names in the Charset Rule and Prose Gate
- [#2173](#2173) Forward a
Second Site's Token Pair to the Deploy-Site Verify Hook
- [#2169](#2169) Record
HomeAutomation-Config's Merge-Bot and Gate Adoption in the Rollout
Tracking
- [#2164](#2164) Pass
--no-project to the Pre-Commit Snippet's uv run Hooks
- [#2161](#2161) Stop
Crediting an until read Loop as Bounded in the Guard
- [#2158](#2158) Drop the
Path Argument From the Pre-Commit Snippet's Mypy Swap
- [#2155](#2155) Reword
the Canonical CRLF-Exception Comments for a Carrier's Own Pin
- [#2153](#2153) End the
Guard's Stdin Redirect Scan at a Reserved Word
- [#2150](#2150) Describe
the Pip Form Consistently Across python-codestyle
- [#2144](#2144) Read the
Run Id From the Runner's Environment in the Artifact-Cleanup Steps
- [#2142](#2142) Diff a
Merge Commit's Prose Against Its Merged-In Parent in the Pre-Commit Hook
- [#2136](#2136) Qualify
the Local Review Skill's Merge-Base Command to Match the Engine
- [#2134](#2134) Quote the
Bare Placeholder in skills_install.py's Usage Block
- [#2132](#2132) Write the
Hub-Checkout Reach Into the session-handoff Chain Commands
- [#2130](#2130) Name the
Missing build-system Condition in the Lint-Only Profile Bullet
- [#2128](#2128) Skip a
Blockquoted List Marker in the Prose Gate's Semicolon Rule
- [#2119](#2119) State the
Three Gaps D4.7's Supersede-and-Dispatch Step Leaves Open

## Closes

Closes #2100
Closes #2031
Closes #1779
Closes #2148
Closes #1633
Closes #1188
Closes #1992
Closes #2032
Closes #2052
Closes #1481
Closes #2116
Closes #2107
Closes #2097
Closes #1512
Closes #2026
Closes #2101
Closes #2009

🤖 Generated with [Claude Code](https://claude.com/claude-code)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Deployment verification can now check a second site using its own
optional authentication token.
* **Documentation**
* Updated writing guidance to preserve the spelling and diacritics of
recorded names.
* Clarified Python project setup, formatting and testing guidance, and
line-ending rules.
* Expanded deployment and publishing guidance, including scenarios where
publishing runs overlap.
* **Bug Fixes**
* Prose checks now handle quoted lists and tables more accurately, and
merge checks avoid flagging comments brought in from the merged branch.
  * Improved checks for shell loops that read redirected input.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants