Skip to content

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

Description

@github-actions

Release Version: 1.4.14-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. OSBotify commented on Dec 19, 2023

    @OSBotify
    Contributor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.14-0 🚀

  2. mvtglobally commented on Dec 19, 2023

    @mvtglobally

    #32890 & #33033 PROD QA. Ok to check off?
    #32731 is reverted, so we need to QA?

  3. jasperhuangg commented on Dec 19, 2023

    @jasperhuangg
    Contributor

    #32890 & #33033 PROD QA. Ok to check off?

    yes!

    #32731 is reverted, so we need to QA?

    nope

    @mvtglobally thanks for asking for confirmation

  4. Julesssss commented on Dec 19, 2023

    @Julesssss
    Contributor

    Checking off #33283 as its expected behaviour

  5. amyevans commented on Dec 19, 2023

    @amyevans
    Contributor

    Checked off #33291 following revert of PR and retest

  6. mvtglobally commented on Dec 19, 2023

    @mvtglobally

    @Julesssss @jasperhuangg we are blocked with Android at the moment. If you could prioritize that Blocker would be great

  7. francoisl commented on Dec 19, 2023

    @francoisl
    Contributor

    Closing blocker #33313, backend fix was CP'ed to staging and confirmed working.

  8. self-assigned this
    on Dec 20, 2023
  9. jasperhuangg commented on Dec 20, 2023

    @jasperhuangg
    Contributor

    @mvtglobally We merged a revert of the offending PR that was causing the crash, I'll let you know as soon as it has been deployed to staging.

  10. jasperhuangg commented on Dec 20, 2023

    @jasperhuangg
    Contributor

    @mvtglobally can you update your Android builds and let me know if they're still crashing?

  11. mvtglobally commented on Dec 20, 2023

    @mvtglobally
  12. mvtglobally commented on Dec 20, 2023

    @mvtglobally

    Are we testing the build 1.4.14-1?

  13. 4 remaining items

  14. Julesssss commented on Dec 20, 2023

    @Julesssss
    Contributor

    Checked off #33277 as the PR that introduced the issue has been reverted

  15. mvtglobally commented on Dec 20, 2023

    @mvtglobally

    Regression is completed

    OPen Blockers.
    #33290
    #33314
    #33326
    #33348
    #33354
    #33357
    #33358
    #33367

    PRs
    #31010 is failing #33301. Repro in PROD checking off
    #31303 is failing #33290
    #31762 is failing #33367
    #32962 is failing #33322
    #32966 is blocked with old KI #19915 on Desktop. but rest is pass. Are we good to check off?
    #33359 Checking CP

  16. jasperhuangg commented on Dec 21, 2023

    @jasperhuangg
    Contributor

    Checking off #33290, CP'd a fix

  17. jasperhuangg commented on Dec 21, 2023

    @jasperhuangg
    Contributor

    Checking off #33314 NAB

  18. jasperhuangg commented on Dec 21, 2023

    @jasperhuangg
    Contributor

    Checking off #33348 NAB

  19. jasperhuangg commented on Dec 21, 2023

    @jasperhuangg
    Contributor

    Closing #33354, fix was CP'd

  20. jasperhuangg commented on Dec 21, 2023

    @jasperhuangg
    Contributor

    CP'd fix for #33358, checking off

  21. jasperhuangg commented on Dec 21, 2023

    @jasperhuangg
    Contributor

    Checking off #33367 CP'd fix

  22. jasperhuangg commented on Dec 21, 2023

    @jasperhuangg
    Contributor

    :shipit:

  23. os-botify commented on Dec 21, 2023

    @os-botify

    This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
    Reopening!

  24. melvin-bot commented on Dec 21, 2023

    @melvin-bot

    📣 @os-botify[bot]! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  25. jasperhuangg commented on Dec 21, 2023

    @jasperhuangg
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions