Repository navigation
Closed
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.4.17-8
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Allow setting merchant for split bill #30721
- Expo image #30905
- Fix/30190: Duplicate phone number can be invited to room #31010
- Migrate EmojiPickerMenu to FlashList #31479
- [TS migration] Migrate '[Remaining Group 1]' hook to TypeScript #32267
- [No QA] Improve AdHoc build comment #32367
- Create updateMoneyRequestAmountOrCurrency #32533
- feat: lottie animations prefetching #32789
- [TS migration] Migrate TabSelector components to typescript #33084
- [NoQA] add submits to prop to Policy ts #33246
- [NoQA] Clean up - Rename next step to be singular #33249
- [TS migration] Migrate 'ReportActionItemMoneyReportView.js' to Typescript #33255
- Accept save distance when editing in offline mode #33266
- [No QA][HelpDot] Reindex google search on push to main #33335
- (perf) Implement debounce in OptionList search #33347
- Better onyx updates logging #33371
- fix: Status – remove redundant privatePersonalDetails dependencies #33440
- Fix preview for report with manual and smartscan expense at the same time #33516
- [CP Staging] Fix amount isn't saved when editting split scan request #33599
- [CP Staging] Fixed bank account icon #33604
- [CP Staging] fix: card icon not rendering properly on android release build #33629
- [CP Staging] Fix typo when setting Zoom icon fill #33631
- [CP Staging] fix: Make the "@here" mention icon green #33634
- [CP Staging] fix receipt empty thumbnail not displayed in native #33636
- [CP Staging] fix pdf not displaying on native #33642
Deploy Blockers:
- [HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Scan Split - Entered amount is not saved in split scan details view #33587
- [HOLD for payment 2024-02-15] [$500] Request - Merchant and category rows disappear in the confirmation page after adding receipt #33588
- [HOLD for payment 2024-01-09][$250] Mentions - @ Here icon is black #33589
- [HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$125] Profile - Zoom icon is black in dark and light mode, it is hardly visible in dark mode #33590
- [HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Android - Modal thumbnail is not displayed for workspace manual request #33591
- [HOLD for payment 2024-01-04] [$125] Web - Emoji - Flag emoji category is missing #33593
- [HOLD for payment 2024-01-04] [$250] Android - Workspace - Card icon is shown as a green square icon #33594
- [HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Bank Account - Green square in place of BA icon #33602
- [$500] Avatar - Avatar is blank instead of placeholder and no spinner when loading it offline #33614
- [HOLD for payment 2024-01-17] [$500] Avatar - Default Avatar photo is not fully rendered #33616
- Android - Attachments - Attachments (MP4, Docx, webp) in conversation history are flickering #33618
- Distance - App redirects to expense report when returning online after editing distance offline #33622
- [HOLD for payment 2024-03-14] [$500] Android - Scan - Receipt flashes briefly when viewing for the first time #33625
- [HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Chat - PDF is not displayed in chat after uploading #33626
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
mountiny commentedon Dec 26, 2023
@rushatgabhane Should #33335 be noQA?
OSBotify commentedon Dec 26, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.17-1 🚀
rushatgabhane commentedon Dec 26, 2023
@mountiny yes it should be No QA. Updated the title
mountiny commentedon Dec 26, 2023
Checking #31010 off as that was reverted in previous deploy
kbecciv commentedon Dec 26, 2023
Regression is 80% progress.
#31010 is failing with #30190, checked off per comment #33576 (comment)
#33347 is failing with #33611, repro on Prod - checking off
#33440 failing on Web with #33592, repro on Prod - checking off
#33516 failing on mWeb, Desktop and IOS app with #33512, repro on Prod - checking off.
#32267 is failing with #33628, repro on Prod - checking off
Deploy Blockers:
#33587
#33588
#33589
#33590
#33591
#33594
#33602
#33614
#33616
mountiny commentedon Dec 26, 2023
mountiny commentedon Dec 26, 2023
mountiny commentedon Dec 26, 2023
kbecciv commentedon Dec 27, 2023
Regression is completed.
#31010 is failing with #30190, checked off per comment #33576 (comment)
#33347 is failing with #33611, repro on Prod - checking off
#33440 failing on Web with #33592, repro on Prod - checking off
#33516 failing on mWeb, Desktop and IOS app with #33512, repro on Prod - checking off.
#32267 is failing with #33628, repro on Prod - checking off
Deploy Blocker:
#33626
mountiny commentedon Dec 27, 2023
#33599 fixed in staging
#33604 fixed in staging
#33629 fixed in staging
#33631 fixed in staging
#33634 fixed in staging
#33636 fixed in staging
mountiny commentedon Dec 27, 2023