Repository navigation
Deploy Checklist: New Expensify 2023-09-20 #27837
Description
Release Version: 1.3.72-11
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Add avatar preview feature #22145
- Update Canceled task flow #24137
- Fix: compose box becomes overlapped by the keyboard #24502
- converted baseErrorBoundary to function component with react-error-bo… #25421
- Migrate index.js to function component #25818
- Clear the image error when going back from other menus #26148
- Copy email with text when IOU settled message is copied #26151
- Fix/17365 nostrikethrough solution #26176
- [No QA] [TS migration] Migrate 'DomUtils' lib to TypeScript #26198
- Fix - user not able to save last enable date of birth #26271
- Improvement: Sidebar Links Performance #26447
- Replace receipt #26508
- fix: BUG: [distance] request confirmation offline doesn't show TBD #26836
- Show local time in money request and 1:1 chat threads #26845
- Fix background image is missing in Android native app #26923
- [No QA] [TS migration] Migrate 'QueuedOnyxUpdates.js' lib to TypeScript #26944
- Fix/26753: Colon added to completed reopened task messages when copy pasting #27119
- Fix: App does not translate copy to clipboard text for requested money action #27142
- Fix: Conversation history does not scroll down after sending a message and IOU #27162
- Feat: Add Billable Toggle UI #27172
- Distance: fix outdated values for onyx connection #27199
- Force markdown text to LTR #27216
- fix transition for task assignee modals #27220
- Adjust tests to the batching updates feature #27230
- perf: disable hover when scrolling on web and desktop #27236
- fix: 26178 Context menu does not close after user goes to the previous page #27268
- Add documentation for creating accessible pressable elements #27272
- [No QA][TS migration] Migrate 'MoneyRequestUtils.js' lib to TypeScript #27276
- Remove data from being sideloaded in the money request header #27286
- Remove clearAfter for internal release #27304
- Web - The horizontal line separating the header and the messages #27307
- Deprecate paypal #27308
- Upgrade react native to 0.72.4 #27320
- [No QA] [TS Migration] Migrate 'focusWithDelay' lib to TypeScript #27321
- [No QA][TS migration] Migrate 'IOUUtils.js' lib to TypeScript #27332
- [No QA][TS migration] Migrate 'PersistedRequests.js' lib to TypeScript #27349
- [No QA][TS migration] Migrate 'Download.js' lib to TypeScript #27351
- fix: 27054 Conversations do not load if you interrupt the Internet connection when logging in #27380
- fix: parent thread disappears in LHN when deleting the thread first chat #27410
- [No QA] [TS migration] Migrate 'cropOrRotateImage' lib to TypeScript #27419
- [No QA][TS migration] Migrate 'AppStateMonitor' lib to TypeScript #27428
- [No QA] [TS migration] Migrate 'SessionUtils.js' lib to TypeScript #27430
- fix: not increase request count for pay request #27435
- use gap in login button row container for consistency #27441
- [No QA][TS migration] Migrate 'FormHelper.js' lib to TypeScript #27443
- fix: move amount diff to check in edit money request #27451
- fix: Android Emoji selected from emoji picker can't be deleted from emoji picker #27489
- fix: empty checking of report #27499
- [No QA] [TS migration] Migrate 'getOperatingSystem' lib to TypeScript #27517
- [No QA][TS migration] Migrate 'KeyReportActionsByReportActionID.js' lib to TypeScript #27529
- fix: prevent fetching address suggestions in forced offline mode #27542
- Fix: "Assign task" appear in modal of "+" actions button in thread of flagging #27552
- Fix/request map cut off #27574
- fix requester avatar and name are not shown for distance request #27581
- Update CONTRIBUTING.md #27614
- Fix spacing of skeleton view #27629
- fix: text disappear before modal closure #27635
- Fix attachment modal doesn't close when pressing search shortcut #27639
- Remove visibilityListeners when report gets unfocused #27642
- Use the enable payments route when paying an IOU request via the Expensify Wallet #27655
- Update Transaction with new field definitions #27674
- [No QA] Update Podfile #27681
- Fix missing margin between name and request money preview box #27692
- [TS migration] migrate 'EmojiTrie.js' lib #27693
- Reset emoji suggestion pop-up automatically after an emoji has been inserted #27711
- fix issue 27333 #27727
- fix select show no result found #27729
- Fix three-dot button tooltip flickers #27732
- [CP Staging] Fix empty workspace detail in money request page #27742
- fix translation for my note #27761
- Remove the STW button #27763
- [CP Staging] revert: "fix: 26178 Context menu does not close after user goes to the previous page" #27798
- Sophiepintoraetz patch 1 #27823
- Update react-native-google-places-autocomplete #27825
- [CP Staging] fix select workspace request money #27868
- [CP Stag] fix onyx betas key missing on chat selector page #27907
- [CP Staging] Allow creating distance requests while offline #27908
- [CP Staging] Add currentStep to navigation hook to prevent lock in 2fa setup step #27938
- [CP Stag] Only use tab animation when in tab navigator #27974
Deploy Blockers:
- [$500] [HOLD for payment 2023-10-02] No way to create new room even from policyRoom beta enabled account #27094
- [$500] [HOLD for payment 2023-09-27] Android - Infinite loading after opening personal details page #27560
- [HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - Wrong navigation after back from add-bank-account page #27673
- [HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - App Fails to Redirect to Announcement Page After Split Bill #27677
- [HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - Pressing CTRL+SHIFT+K opens Send message page with random URL params #27710
- [HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Split bill - Page freezes when attempting to create split bill #27713
- [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Assign task - Long task description goes beyond the scope, doesn’t disappear after delete #27722
- ReconnectApp is called after sending or receiving message with reliableUpdates beta #27754
- [HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] [$500] IOU- In announce room, checkbox circle to unselect split bill participants is not responsive #27774
- [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] Dev: Web - App crashing on creating new workspace #27782
- [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-02] Android - Private notes - Code block creates empty lines below it in the note preview #27802
- [HOLD for payment 2023-10-09] [Awaiting payment Oct 2 2023 / $500] Web - green dot appears even if task is deleted #27805
- [HOLD for payment 2023-10-09] Web - Copying 'paid elsewhere' text copies the wrong text #27858
- [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] Web - App crash on request money with Workspace chat #27864
- [HOLD for payment 2023-10-10] [$500] Web - Receipt scan request container corners are not rounded while it is in progress #27869
- [HOLD for payment 2023-10-02] Chat - IOU - Hover is not being shown after stopping to scroll #27873
- [HOLD for payment 2023-10-25] [$500] LHN - New 1:1 DM appears briefly in LHN without avatar and username when IOU is received #27878
- Assign task - Green dot in LHN is displayed after the task has been cancelled #27890
- [HOLD for payment 2023-10-13] [$500] Chat - Creating a new line in composer causes the composer to jump when expanding #27892
- [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] IOU - Next button disabled when requesting a new distance IOU offline #27895
- [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Android - Bank Account - Connect bank account page blinks when navigate from Bills page #27901
- [$500] [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] RM - App crashed when tap replace receipt #27903
- [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] Pressing 'Next' while setting up 2FA does not redirect the user #27928
- [HOLD for payment 2023-10-23] [$500] Android native - Default Scrollbar is visible when scrolling in a chat #27931
- [$500] Request Money - Selecting and unselecting an account when requesting money creates a delay #27949
- [HOLD for payment 2024-01-09] [HOLD for payment 2023-12-26] HIGH: [$500] Show workspace interstitial when trying to create a room with no workspace #27995
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Sep 20, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.72-3 🚀
jasperhuangg commentedon Sep 20, 2023
Checking off #27802
kavimuru commentedon Sep 20, 2023
@thienlnam Interim report summary:
Regression TR is with 50% progress.
PRs - Team is working on the PRs
#26836 failing with #27895 - repro in production. Checking off
#27119 failing with #27884 - Reprod in production, checking it off
#27286 failing with #27893 - Is this ok to checkoff?
#27441 failing with #26566 - not fixed in android
kavimuru commentedon Sep 21, 2023
@thienlnam Interim report summary:
Regression TR is with 63% progress.
PRs - Team is working on the iOS slots
#27286 failing with #27893 - Is this ok to checkoff?
#27441 failing with #26566 - not fixed in android
#26508 failing with #27903
thienlnam commentedon Sep 21, 2023
Asked about this here #27286 (comment)
kavimuru commentedon Sep 21, 2023
@thienlnam This is the current status of the progress
Regression is 12% left in the TR
#27307 failing with #26529 - not fixed in iOS
kavimuru commentedon Sep 21, 2023
@thienlnam Regression just 2 steps left to be completed. We are waiting for the build to be updated in android to validate #27908
#27441 failing with #26566 - not fixed in android
#26508 failing with #27903
#27307 failing with #26529 - not fixed in iOS
#27304 failing with #24423 (offline testing)
#27742 failing with #27864
#27499 failing with #27888
#27868 failing with #27959 repro in production checking off
#27727 failing with #27328 in android. Issue closed, ok to check it off?
mvtglobally commentedon Sep 21, 2023
Staging is down for some time.
kavimuru commentedon Sep 21, 2023
Regression is complete.
Build version 1.3.72-9 is still not available in android to validate #27908
#27441 failing with #26566 - not fixed in android
#26508 failing with #27903
#27307 failing with #26529 - not fixed in iOS
#27304 failing with #24423 (offline testing)
#27742 failing with #27864
#27499 failing with #27888
#27727 failing with #27328 in android. Issue closed, ok to check it off?
thienlnam commentedon Sep 22, 2023
They're continuing in the issue - fine to mark off
We're working on the deploy blocker fix here #27974
CPed a fix for this
Yeah this looks fine to check off
thienlnam commentedon Sep 22, 2023