Skip to content

docs(credits): record #8176 credit lost in #8214's squash - #8219

Merged
lidge-jun merged 1 commit into
devfrom
codex/credits-8176-8214
Nov 6, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/credits-8176-8214

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Verification

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Documentation
    • Added a follow-up note clarifying the credit recorded for the landed change and that the related pull request remains open for other work.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 6, 2026 05:26
@lidge-jun lidge-jun added the documentation Improvements or additions to documentation label Nov 6, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T05:27:49.060257Z f529189 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

CREDITS.md adds a follow-up that records attribution and landing details for overlapping Messages-related work. It also notes that PR #8176 remains open for its remaining work.

Changes: Credits follow-up

Layer / File(s) Summary
Document landing and attribution details
CREDITS.md
Adds a follow-up about the co-author trailer omitted from the squash message, records the credited author and landing commit, and notes that PR #8176 remains open for other work.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: luvs01

Merge Risk: Minimal · up to f5291

The attribution follow-up presents no identified merge-blocking risk and is mergeable after normal documentation checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately describes the credit recorded in CREDITS.md for work from #8176 that landed in #8214.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 7757a2f and f529189.

Files selected for processing: 1

  • CREDITS.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev under MAINTAINERS.md (lidge-jun, admin). Checked head f529189; all 26 PR checks passed; no review threads. Docs-only forward credit repair for #8176.

@lidge-jun
lidge-jun merged commit 99c5153 into dev Nov 6, 2026
31 of 33 checks passed
@lidge-jun
lidge-jun deleted the codex/credits-8176-8214 branch November 6, 2026 05:42
jack-o-mania added a commit to alexalok/opencodex that referenced this pull request Nov 6, 2026
…20)

* feat: configure approval-review reasoning and allow native reviewers

* test: update response source guards for approval review effort

* fix(claude): normalize direct context overflow errors with parity coverage (lidge-jun#8148)

* fix(claude): normalize direct context overflow errors

* test(claude): cover generic overflow parity and document direct errors

Preserve the existing direct-encoder fix and cover four generic error codes across streaming and folded responses.

Verified tree matches local commit 25f1104c7631e713199de631505c1dba01ff49d3.

* test(messages): align generic overflow normalization expectations

* fix(responses): lower ocx envelopes on native v1 compact (lidge-jun#8042) (lidge-jun#8151)

Canonical ChatGPT and official OpenAI native /responses/compact sends
forwarded OpenCodex-owned ocx1:/ocx2: compaction envelopes verbatim, so the
upstream rejected them as invalid_encrypted_content. Only the custom gateway
send lowered them. Run scrubOcxCompactionItems on the non-gateway send as
well, so the envelopes become plain user summaries like on ordinary turns,
while native blobs stay byte-identical for these decoding destinations.

Co-authored-by: Ingwannu <ingwannu@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix(codex): preserve pre-output hold across safe WS heartbeats (lidge-jun#8188)

* fix(codex): preserve pre-output hold across safe WS heartbeats

* test(codex): cover heartbeat cancellation and sequence bounds

* test(codex): assert the relayed refusal frame reaches the body

The parameterised "relayed in the body" cases only checked the status, so a
regression that dropped the frame would still pass. Assert the event marker and
message, and say in the transport contract that sequence_number is also bounded
to a non-negative safe integer.

* fix(terminal-guard): pass completion summaries that follow tool results (lidge-jun#8154)

* fix(terminal-guard): pass completion summaries that follow tool results

The Anthropic terminal guard read the latest user text and ignored tool
activity after it, so a normal turn (request -> tool calls -> tool
results -> short "done" summary) was classified suspicious_no_tool. The
relay then appended the plan-only nudge and re-asked the model, which
re-ran tools it had already run and repeated the cycle on every client
turn.

Tool calls or results after the latest user message now mark the turn as
already executed; only a renewed plan announcement (PLAN_INTENT_RE) is
still continued.

* fix(terminal-guard): stop the tool-activity pass at a stalled plan announcement

A text-only plan announcement after the last tool activity means the turn
stalled there, so a following completion is continued again, matching
recentTurnHasToolActivity. Pin the boundary for next-step wording: first-person
plans still continue, while a summary that suggests a next step to the user
passes.

---------

Co-authored-by: yazzang-homelab <278053055+yazzang-homelab@users.noreply.github.com>

* fix(mistral): keep replayed images within each model's per-request cap (lidge-jun#8174)

Mistral rejects requests that carry more images than a model accepts,
counting the whole replayed history: most vision models refuse a ninth
image with HTTP 400, and DeepSeek V4.1 Flash answers an opaque HTTP 503
(code 3800) past 20. A screenshot-heavy session then fails on every turn.

For the first-party Mistral destination, messagesToChatFormat now keeps
the newest image_url parts within the model's cap and replaces older ones
with a text note naming the cap, in the outbound copy only. The cap is the
new modelCapabilities.<id>.mistralMaxImages axis: an operator declaration
over the measured rows on the mistral registry entry, else the documented 8.

Co-authored-by: Henry Fontanier <14199823+fontanierh@users.noreply.github.com>

* fix(openai-chat): flatten root tool schemas for Claude chat gateways (lidge-jun#8163)

* fix(openai-chat): flatten Claude gateway root tool schemas

Apply the supplied Claude Chat gateway compatibility patch to current dev.
Flatten root oneOf/anyOf/allOf by upstream model id while preserving nested
schemas and literal values. Keep existing Zen and Azure sanitization intact.

Cover root compositions, required fields, wire-model overrides, non-Claude
exclusion, nested schema preservation and input immutability. Register the
new suite in the existing providers layout shard and document the lossy
root normalization contract.

* fix(openai-chat): preserve Claude root reference arguments

Preserve own __proto__ argument names and resolve local root-branch ref
chains with a shared 64-dereference budget per tool schema. Keep nested
schemas and existing Zen/Azure handling unchanged. Preserve the original
composition for cyclic, missing, external, over-budget or nested-composition
references instead of emitting an incomplete flattened argument catalog.

Add regression coverage for local references, safety fallbacks, property
precedence and non-final Claude name segments. Clarify allOf required-field
promotion and reference limits in the public and architecture docs.

* fix(openai-chat): retain unread inline composition arguments

* fix(openai-chat): flatten empty nested property maps

* test(service): make service definition probes portable (lidge-jun#8201)

Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com>
Co-authored-by: Omar <13569609+omar391@users.noreply.github.com>

* fix(responses): join repeated tool outputs for one call (lidge-jun#8199)

* fix(responses): join repeated tool outputs for one call

Co-authored-by: tachyon6 <songjunjun62754@gmail.com>

* fix(chat): preserve late tool output chronology

* docs(chat): clarify repeated output folding boundary

---------

Co-authored-by: tachyon6 <songjunjun62754@gmail.com>

* fix(transport): release disposed SOCKS5 readers and timeout closures (lidge-jun#8203)

Co-authored-by: youhuangla <71770193+youhuangla@users.noreply.github.com>

* fix(claude): avoid retries for definite context overflow (lidge-jun#8211)

* fix(claude): avoid retries for definite context overflow

Co-authored-by: gitrvc-hub <rvcalilap@gmail.com>

* fix(retry): reject negated overflow verdicts

* fix(claude): preserve overflow verdicts across sentences

* fix(claude): preserve verdicts across separate sentences

---------

Co-authored-by: gitrvc-hub <rvcalilap@gmail.com>

* fix(antigravity): include Argon level with thought summaries (lidge-jun#8208)

Preserve suffix-only requests when summaries are hidden and reject inherited effort-map keys.

Co-authored-by: Andrew (agent) <59988150+andrew05060414@users.noreply.github.com>

* fix(claude): preserve translated system cache boundary (lidge-jun#8212)

* fix(claude): preserve translated system cache boundary

Co-authored-by: Vadym O <bolein95@gmail.com>

* fix(claude): retain cache boundary after identity normalization

* test(claude): cover mismatched system cache prefix

---------

Co-authored-by: Vadym O <bolein95@gmail.com>

* fix(web-search): strip Lite marker from classic search (lidge-jun#8202)

* fix(web-search): omit lite marker from classic search

Preserve classic search wire semantics for configured and selected headers.

Co-authored-by: Ege Arhan <egearhany@gmail.com>

* docs(web-search): explain classic sidecar header exception

---------

Co-authored-by: Ege Arhan <egearhany@gmail.com>

* fix(web-search): report incomplete Anthropic search results (lidge-jun#8210)

* fix(web-search): report incomplete Anthropic search results

* fix(web-search): reject malformed Anthropic search frames

* fix(web-search): reject empty Anthropic stop reasons

* test(web-search): complete routed Anthropic search fixture

* fix(web-search): honor SSE controls and exact byte boundary

* fix(web-search): honor clean EOF at exact byte cap

* fix(web-search): separate consumer and upstream inactivity (lidge-jun#8213)

* fix(web-search): separate consumer and upstream inactivity

* fix(web-search): yield on synchronous empty chunks

* Preserve consumer timeout in image bridge

* test(messages): restore Windows fixture coverage (lidge-jun#8214)

* test(messages): fix Windows fixture path matching

* test(messages): prove sink and overlay execution

---------

Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com>

* docs(credits): record lidge-jun#8176 credit lost in lidge-jun#8214's squash (lidge-jun#8219)

* fix(responses): preserve adapter body stall status (lidge-jun#8200)

* fix(responses): preserve adapter body stall status

* docs(responses): describe adapter body stall failures

* fix(responses): preserve continuation stall status

* Preserve body stall across empty completion retry

* fix(tests): isolate Codex profile cases on Windows (lidge-jun#8217)

Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com>

* fix(tests): isolate Windows uninstall privilege scenarios (lidge-jun#8218)

Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com>

* fix(tests): pair Windows job store route fixture (lidge-jun#8225)

Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com>

* fix(tests): use native homes in systemd probe fixtures (lidge-jun#8226)

Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com>

* fix(models): list router-known IDs with effective metadata (lidge-jun#8215)

Carries lidge-jun#8187 by @ismell0992-afk.

Co-authored-by: ismell0992-afk <255305877+ismell0992-afk@users.noreply.github.com>

* fix(gui): prioritize critical credits in quota summary (lidge-jun#8223)

* Prioritize critical credits in quota headline

Co-authored-by: Rafael Moreira Lima <rrmlima@gmail.com>

* Fix quota headline selection for custom label collisions

Co-authored-by: Rafael Moreira Lima <rrmlima@gmail.com>

* Strengthen unlimited credits quota summary fixture

Co-authored-by: Rafael Moreira Lima <rrmlima@gmail.com>

* docs: record quota headline precedence

Co-authored-by: Rafael Moreira Lima <rrmlima@gmail.com>

* fix(gui): index quota headline windows by label

Co-authored-by: Rafael Moreira Lima <rrmlima@gmail.com>

* docs: clarify critical credit precedence in translations

Co-authored-by: Rafael Moreira Lima <rrmlima@gmail.com>

* docs: describe quota window projection

Co-authored-by: Rafael Moreira Lima <rrmlima@gmail.com>

---------

Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com>
Co-authored-by: Rafael Moreira Lima <rrmlima@gmail.com>

* fix(update): validate configuration before stopping services (lidge-jun#8227)

Carries lidge-jun#8081 by @rrmlima.

Co-authored-by: Rafael Moreira <rrmlima@gmail.com>

* docs: keep merged provider reference within size limit

* ci: allow Linux shards time to finish the full suite

---------

Co-authored-by: Epinephrine <luvs01@hanmail.net>
Co-authored-by: ingwannu <ingwannu@teamwicked.me>
Co-authored-by: Ingwannu <ingwannu@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: jaekwonhong <148875547+jaekwonhong@users.noreply.github.com>
Co-authored-by: Lee SaYah <dltkdi0830@dankook.ac.kr>
Co-authored-by: yazzang-homelab <278053055+yazzang-homelab@users.noreply.github.com>
Co-authored-by: Henry Fontanier <h.fontanier@gmail.com>
Co-authored-by: Henry Fontanier <14199823+fontanierh@users.noreply.github.com>
Co-authored-by: lcxhh <lcxhh521@gmail.com>
Co-authored-by: JUN <jun@lidgeai.com>
Co-authored-by: JUN <243035832+lidge-jun@users.noreply.github.com>
Co-authored-by: Omar <13569609+omar391@users.noreply.github.com>
Co-authored-by: tachyon6 <songjunjun62754@gmail.com>
Co-authored-by: youhuangla <71770193+youhuangla@users.noreply.github.com>
Co-authored-by: gitrvc-hub <rvcalilap@gmail.com>
Co-authored-by: Andrew (agent) <59988150+andrew05060414@users.noreply.github.com>
Co-authored-by: Vadym O <bolein95@gmail.com>
Co-authored-by: Ege Arhan <egearhany@gmail.com>
Co-authored-by: ismell0992-afk <255305877+ismell0992-afk@users.noreply.github.com>
Co-authored-by: Rafael Moreira Lima <rrmlima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant