Name the Leftover Old Tree When the Bash Loader Cannot Remove It

[ptr727]

The Linux loader's swap_in called remove_owned bare on a leftover owned .old tree, so an entry rm could not remove aborted the run with only rm's own error. It now stops with the loader's message naming the .old path and the remedy, matching what bootstrap.ps1 already says in the same state. A test with a locked entry in the leftover tree fails without the change.

Closes on promotion: #1790

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f95cada4-3aca-4c42-adbf-c5b928015a28

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@db4dbd0). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #2218   +/-   ##
==========================================
  Coverage           ?   56.61%           
==========================================
  Files              ?       16           
  Lines              ?     7482           
  Branches           ?        0           
==========================================
  Hits               ?     4236           
  Misses             ?     3246           
  Partials           ?        0           

Flag	Coverage Δ
python-3.13	56.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Copilot review overview

🟢 Approval recommended

The two-line change is traced-correct, parallels the existing PowerShell loader message, and is covered by a dedicated regression test whose setup reaches exactly the targeted failure path.

Review effort: Balanced
Findings: None

What changed in this PR

The Linux bootstrap loader's swap_in previously called remove_owned "$retired" bare when clearing a leftover owned .old tree. If an entry in that tree could not be removed (e.g. a locked directory), remove_tree returned non-zero and set -Eeuo pipefail aborted the run with only rm's raw error, leaving no indication of the .old path or the remedy, and every later kept-tree run failed the same way. This PR adds a || die refusal that names the .old path and the fix, bringing bootstrap.sh into parity with the message bootstrap.ps1 already emits in the same state.

Changes:

• Wrap remove_owned "$retired" in swap_in with || die, producing a path-naming refusal consistent with bootstrap.ps1:309.
• Add a regression test seeding a live tree, a staged .new, and a locked .old, asserting the swap stops, the message names the .old path, and the live tree is preserved.

File	Description
host-setup/​bootstrap.sh	Adds a `
tests/​test_bootstrap.py	Adds a test that a locked leftover .old beside a live tree fails the swap with the loader's message and leaves the live tree intact.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.