Tell Apart the Causes a Labels Payload Is Refused For

[ptr727]

Closes on promotion: #1372

labels_payload_ok now refuses a repeated label name (ignoring ASCII case) and an uppercase hex color, since GitHub stores colors lowercased (confirmed read-only against this repository's labels). It checks the payload in separate steps and reports each cause as itself: did not parse, not exactly one JSON document, not an array, empty, outside the field contract, repeated name, and a failing jq. cmd_apply and check_labels print that reason.

Tests in LabelsPayloadCase use constructed payloads and fail on the old code. The comment change needs the comments label.

Remaining gaps the local review found are filed as #2229.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f57289b2-d8e8-4fd3-bb14-be7e47005bfb

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@901d886). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #2230   +/-   ##
==========================================
  Coverage           ?   56.61%           
==========================================
  Files              ?       16           
  Lines              ?     7482           
  Branches           ?        0           
==========================================
  Hits               ?     4236           
  Misses             ?     3246           
  Partials           ?        0           

Flag	Coverage Δ
python-3.13	56.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Copilot review overview

🔵 Needs a closer look

It changes shared fleet tooling that gates configuration writes and relies on subtle, jq-version-dependent exit-code and error-message behavior, so a maintainer should confirm it before merge.

Review effort: Balanced
Findings: None

What changed in this PR

This PR hardens labels_payload_ok, the shared pre-flight validator for repo-config/labels.json in the fleet configuration script. Previously the predicate folded every failure cause into a single boolean with suppressed jq stderr, admitted duplicate label names and uppercase hex colors (both of which later read as permanent drift against GitHub's lowercased, name-unique storage), and could blame a valid payload when jq itself failed (for example a build lacking test/1). The function now runs each check as its own step, reports the specific cause, rejects case-insensitive duplicate names and uppercase hex, and distinguishes a jq failure from a bad payload. This addresses the three defects tracked in the linked issue; remaining tightening is deferred to a follow-up issue.

Changes:

• Rewrote labels_payload_ok into an ordered sequence of jq steps (parse, exactly-one-document, array, non-empty, field contract with lowercase-only hex, unique-name-ignoring-case), each emitting its own reason and separating a jq execution failure from a payload defect.
• Wired the returned reason into cmd_apply and check_labels via if ! why="$(labels_payload_ok)", so the abort/drift message names the specific cause.
• Added LabelsPayloadCase tests exercising the lifted function against constructed payloads (duplicate names, case-folded duplicates, uppercase color, each parse/structure cause, and a stubbed failing jq), plus a test that the committed labels.json still passes.

File	Description
repo-config/​configure.sh	Splits labels_payload_ok into per-cause steps with lowercase-hex and unique-name checks; callers surface the specific reason.
tests/​test_configure_project.py	New LabelsPayloadCase lifting the function to assert each refusal cause and that the committed payload is admitted.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.