Stop the Promotion Count on a Failed Fetch in backlog-burndown

[ptr727]

backlog-burndown "The Promotion Boundary" step 1 required a git fetch origin before counting origin/main..origin/develop, and named the stale-ref hazard, but never said what a failed fetch means. A failed fetch leaves the stale ref, the count reads zero, and the round reports nothing to promote while develop carries work.

This adds one sentence telling the reader to stop and report a failed fetch rather than running git rev-list anyway, matching the wording the same file already uses for its git fetch --prune origin read in "Grouping and File Claims". The generated distributions are regenerated with scripts/build_dist.py.

Closes on promotion: #1310

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation
  • Clarified that promotion stops and reports an error if fetching from the remote fails.
  • Confirmed that promotion includes all pending commits, and reports no work only when none are pending.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (1)

.github/copilot-instructions.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f99d353f-60d3-46cd-a838-d5f12e3eb47b

📥 Commits

Reviewing files that changed from the base of the PR and between 7a2e3c5 and 7e72c1b.

⛔ Files ignored due to path filters (3)

• .claude-plugin/fleet-skills/.source-digests/backlog-burndown is excluded by !.claude-plugin/fleet-skills/**
• .claude-plugin/fleet-skills/skills/backlog-burndown/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
• .github/skills/backlog-burndown/SKILL.md is excluded by !.github/skills/**

📒 Files selected for processing (1)

• .agents/skills/backlog-burndown/SKILL.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The backlog-burndown instructions now require stopping and reporting if git fetch origin fails. They retain the rule to promote when origin/main..origin/develop contains commits, and to report no work to promote only when the count is zero.

Changes

Promotion check

Layer / File(s)	Summary
Fetch and evaluate commits .agents/skills/backlog-burndown/SKILL.md	The instructions require stopping and reporting after a failed fetch. After a successful fetch, a nonzero commit count requires promotion, including work from earlier rounds; zero means no work to promote.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Merge Risk: ⚪ Minimal · up to 7e72c

The instructions now require stopping if the fetch fails, and the generated copies match. No material merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 7e72c

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

• observed — Modified behavior in .agents/skills/backlog-burndown/SKILL.md: The promotion check now explicitly stops and reports on a failed fetch instead of running git rev-list against potentially stale refs. A nonzero count still requires promotion, including when this round’s groups all deferred or parked; zero is the only no-promotion case.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: stopping promotion-count evaluation when git fetch origin fails in backlog-burndown.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@7a2e3c5). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #2239   +/-   ##
==========================================
  Coverage           ?   56.61%           
==========================================
  Files              ?       16           
  Lines              ?     7482           
  Branches           ?        0           
==========================================
  Hits               ?     4236           
  Misses             ?     3246           
  Partials           ?        0           

Flag	Coverage Δ
python-3.13	56.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Copilot review overview

🟢 Approval recommended

A single-sentence documentation fix that correctly closes the fail-open fetch hazard, with the generated distributions and source digest verified byte-consistent with the authored source.

Review effort: Balanced
Findings: None

What changed in this PR

This PR makes a one-sentence documentation fix to the backlog-burndown skill, closing a fail-open hazard in "The Promotion Boundary" step 1. Previously the step required running git fetch origin before counting git rev-list --count origin/main..origin/develop and named the stale-ref hazard, but never said what to do if the fetch failed — a failed fetch leaves the stale ref, the count reads zero, and the round silently reports "nothing to promote" while develop carries unpromoted work. The added clause instructs the reader to stop and report a failed fetch instead of running the comparison anyway.

The edit is authored in the hand-authored source (.agents/skills/) and propagated to the two generated distributions plus the regenerated source digest, so the fleet skill copies stay in sync.

Changes:

• Add "Stop and report a failed fetch rather than running git rev-list anyway." to the promotion-count step, making it fail-closed.
• Mirror the identical edit into the generated .github/skills and .claude-plugin/fleet-skills copies.
• Regenerate the per-skill source digest stamp to match the new source bytes.

I verified the new wording parallels the existing convention the same file already uses in "Grouping and File Claims" ("Stop and report a failed fetch rather than reading git branch -r anyway"), that all three SKILL.md copies are byte-identical in the changed region, and that the recomputed source-tree digest (8af02d71a6042fb6) matches both the stored stamp and the two generated trees. Prose is ASCII-clean, free of mid-sentence semicolons, and wrapped consistently with the surrounding tree.

File	Description
.agents/​skills/​backlog-burndown/​SKILL.md	Hand-authored source edit adding the fail-closed sentence to the promotion-count step
.github/​skills/​backlog-burndown/​SKILL.md	Generated copy regenerated to match the source edit
.claude-plugin/​fleet-skills/​skills/​backlog-burndown/​SKILL.md	Generated plugin copy regenerated to match the source edit
.claude-plugin/​fleet-skills/​.source-digests/​backlog-burndown	Regenerated per-skill digest stamp (verified correct)

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[ptr727]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.