Skip to content

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

Description

@github-actions

Release Version: 1.4.58-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. yuwenmemon commented on Mar 29, 2024

    @yuwenmemon
    Contributor

    Hey @kavimuru @isabelastisser @mvtglobally, there are a couple of new features here in this staging release we'd like testers to be aware of.

    1. Live Markdown - Before we start testing Enable Live Markdown Preview on web #38152, keep in mind we also upgraded the version of the Live Markdown package. So, it would be best to also make sure that everything is working properly not only on Web, but also on Android/iOS where the package has already been in use since January.

    2. Group Chats + Splits - @marcaaron would like to try to resolve any issues with Create Group Chats + Splits. #37458 unless there is something crazy major like features breaking left and right. So please do ping him if you see issues that could be related to it. We tested it pretty well - but it’s one of those foundational things that could lead to weird stuff (but hopefully not...).

  2. yuwenmemon commented on Mar 29, 2024

    @yuwenmemon
    Contributor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version 1.4.58-0

  3. amyevans commented on Mar 29, 2024

    @amyevans
    Contributor

    Checked off #39235, not a blocker and a PR is already in review

  4. tgolen commented on Mar 29, 2024

    @tgolen
    Contributor

    Checked off #39245 because I don't think it's severe enough to be a blocker. Marked it as external

  5. blimpich commented on Mar 29, 2024

    @blimpich
    Contributor

    Demoting #39250 because its fairly minor and might even be intended behavior.

  6. rlinoz commented on Mar 29, 2024

    @rlinoz
    Contributor

    Demoting #39257

  7. mountiny commented on Mar 29, 2024

    @mountiny
    Contributor

    Demoted #39306 its not really blocker for users

  8. marcaaron commented on Mar 29, 2024

    @marcaaron
    Contributor

    Checking off Demoting #39303

  9. francoisl commented on Mar 30, 2024

    @francoisl
    Contributor

    #39304 will be a backend fix, checked off.

  10. kavimuru commented on Apr 1, 2024

    @kavimuru

    Regression is 9% left in the TR
    #37817 failing with #39285
    #38191 failing with #38114 (comment)
    #38722 failing with #39264
    #38940 blocked in desktop with this #25790 (comment) - checking it off
    #38984 failing with #39256
    #38999 failing with #38935
    #39001 failing with #39253
    #39063 failing with #39320

  11. kavimuru commented on Apr 1, 2024

    @kavimuru

    Regression is completed in TestRail.
    Unchecked PRs:
    #37817 failing with #39285
    #38191 failing with #38114 (comment)
    #38722 failing with #39264
    #38940 blocked in desktop with this #25790 (comment)
    #38984 failing with #39256
    #38999 failing with #38935
    #39001 failing with #39253
    #39063 failing with #39320
    #33124 failing with #39335 and #39338
    #36657 failing with #39363 repro in PROD, checking it off.

  12. 18 remaining items

  13. deleted a comment from melvin-bot on Apr 2, 2024
  14. yuwenmemon commented on Apr 2, 2024

    @yuwenmemon
    Contributor

    Checking off #39340 as it's an API issue.

  15. Beamanator commented on Apr 2, 2024

    @Beamanator
    Contributor

    Checking off #39361 and #39377 as the revert PR was CP'd and confirmed fixed on staging

  16. Beamanator commented on Apr 2, 2024

    @Beamanator
    Contributor

    Checking off #39348 b/c it was marked NAB here

    Same with #39338, marked NAB here

  17. Beamanator commented on Apr 2, 2024

    @Beamanator
    Contributor

    So looks like the remaining checklist PR items are...:

    And 1 remaining open blocker #39320 which has a fix PR #39383 on staging, which is waiting to be tested

    And these PRs that were CP'd to staging to fix blockers:

  18. mountiny commented on Apr 2, 2024

    @mountiny
    Contributor

    checking off:

  19. mountiny commented on Apr 2, 2024

    @mountiny
    Contributor

    Checking off #38191 as the linked fail is not related

  20. mountiny commented on Apr 2, 2024

    @mountiny
    Contributor

    checking off #38722 as it was fixed with the partial revert #39302

  21. mountiny commented on Apr 2, 2024

    @mountiny
    Contributor

    checking off #37817 as the v4 camera pr was reverted

  22. mountiny commented on Apr 2, 2024

    @mountiny
    Contributor

    checking off #38984 as I could not repro the linked blocker anymore #39256

  23. mountiny commented on Apr 2, 2024

    @mountiny
    Contributor

    #38999
    Was failing with #38935, which is the original issue the PR was supposed to fix 😅 so seems like the PR didn't fix the issue, maybe it just didn't cause any new bugs so can be checked off?

    Did not cause a new bug/ blocker so we can check it off

  24. mountiny commented on Apr 2, 2024

    @mountiny
    Contributor

    checking off #39001 - failing issue marked as NAB

  25. mountiny commented on Apr 2, 2024

    @mountiny
    Contributor

    Checking off #39276 - tested in staging and it was a pass

  26. Beamanator commented on Apr 2, 2024

    @Beamanator
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions